mbox series

[v4,0/5] Replace the "slave_*" function names

Message ID 20241022180839.2712439-1-bvanassche@acm.org
Headers show
Series Replace the "slave_*" function names | expand

Message

Bart Van Assche Oct. 22, 2024, 6:07 p.m. UTC 
Hi Martin,

The text "slave_" in multiple function names does not make it clear what
the purpose of these functions is. Hence this patch series that renames all
SCSI functions that have the word "slave" in their function name. Please
consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v3:
 - Combined two Documentation/scsi/scsi_mid_low_api.rst patches into a single
   patch.

Changes compared to v2:
 - Renamed sdev_prep() into sdev_init().
 - Dropped the patches again that remove SCSI LLD changelog files.

Changes compared to v1:
 - Switch to the names proposed by Matthew Wilcox.
 - Included a patch that renames .device_configure() into .sdev_configure().
 - Split off the documentation changes into a separate patch as requested by
   Damien.
 - Added 5 patches that remove obsolete SCSI LLD changelog files.

Bart Van Assche (5):
  scsi: Rename .slave_alloc() and .slave_destroy()
  scsi: Rename .device_configure() into .sdev_configure()
  scsi: Convert SCSI drivers to .sdev_configure()
  scsi: core: Remove the .slave_configure() method
  scsi: core: Update API documentation

 Documentation/scsi/scsi_mid_low_api.rst   | 78 +++++++++++------------
 drivers/ata/ahci.h                        |  2 +-
 drivers/ata/libata-sata.c                 |  8 +--
 drivers/ata/libata-scsi.c                 | 19 +++---
 drivers/ata/pata_macio.c                  |  8 +--
 drivers/ata/sata_mv.c                     |  2 +-
 drivers/ata/sata_nv.c                     | 24 +++----
 drivers/ata/sata_sil24.c                  |  2 +-
 drivers/firewire/sbp2.c                   | 10 +--
 drivers/infiniband/ulp/srp/ib_srp.c       |  5 +-
 drivers/message/fusion/mptfc.c            | 14 ++--
 drivers/message/fusion/mptsas.c           | 14 ++--
 drivers/message/fusion/mptscsih.c         | 10 +--
 drivers/message/fusion/mptscsih.h         |  5 +-
 drivers/message/fusion/mptspi.c           | 19 +++---
 drivers/s390/scsi/zfcp_scsi.c             | 15 +++--
 drivers/s390/scsi/zfcp_sysfs.c            |  2 +-
 drivers/s390/scsi/zfcp_unit.c             |  2 +-
 drivers/scsi/3w-9xxx.c                    |  7 +-
 drivers/scsi/3w-sas.c                     |  7 +-
 drivers/scsi/3w-xxxx.c                    |  8 +--
 drivers/scsi/53c700.c                     | 19 +++---
 drivers/scsi/BusLogic.c                   |  7 +-
 drivers/scsi/BusLogic.h                   |  3 +-
 drivers/scsi/aacraid/linit.c              |  8 ++-
 drivers/scsi/advansys.c                   | 23 +++----
 drivers/scsi/aic7xxx/aic79xx_osm.c        |  8 +--
 drivers/scsi/aic7xxx/aic7xxx_osm.c        |  8 +--
 drivers/scsi/arcmsr/arcmsr_hba.c          |  8 ++-
 drivers/scsi/bfa/bfad_im.c                | 26 ++++----
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c         |  7 +-
 drivers/scsi/csiostor/csio_scsi.c         | 18 +++---
 drivers/scsi/dc395x.c                     | 12 ++--
 drivers/scsi/esp_scsi.c                   | 14 ++--
 drivers/scsi/fcoe/fcoe.c                  |  2 +-
 drivers/scsi/fnic/fnic_main.c             |  4 +-
 drivers/scsi/hisi_sas/hisi_sas.h          |  5 +-
 drivers/scsi/hisi_sas/hisi_sas_main.c     | 13 ++--
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c    |  4 +-
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c    |  4 +-
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c    | 10 +--
 drivers/scsi/hpsa.c                       | 20 +++---
 drivers/scsi/hptiop.c                     |  6 +-
 drivers/scsi/ibmvscsi/ibmvfc.c            | 14 ++--
 drivers/scsi/ibmvscsi/ibmvscsi.c          |  8 ++-
 drivers/scsi/ipr.c                        | 20 +++---
 drivers/scsi/ips.c                        |  6 +-
 drivers/scsi/ips.h                        |  3 +-
 drivers/scsi/iscsi_tcp.c                  |  6 +-
 drivers/scsi/libfc/fc_fcp.c               |  6 +-
 drivers/scsi/libsas/sas_scsi_host.c       | 11 ++--
 drivers/scsi/lpfc/lpfc_scsi.c             | 37 ++++++-----
 drivers/scsi/megaraid/megaraid_sas_base.c | 14 ++--
 drivers/scsi/mpi3mr/mpi3mr_os.c           | 20 +++---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c      | 24 +++----
 drivers/scsi/mvumi.c                      |  5 +-
 drivers/scsi/myrb.c                       | 21 +++---
 drivers/scsi/myrs.c                       | 13 ++--
 drivers/scsi/ncr53c8xx.c                  |  9 +--
 drivers/scsi/pmcraid.c                    | 22 +++----
 drivers/scsi/ps3rom.c                     |  5 +-
 drivers/scsi/qedf/qedf_main.c             |  5 +-
 drivers/scsi/qla1280.c                    |  6 +-
 drivers/scsi/qla2xxx/qla_os.c             | 12 ++--
 drivers/scsi/qla4xxx/ql4_os.c             |  6 +-
 drivers/scsi/qlogicpti.c                  |  5 +-
 drivers/scsi/scsi_debug.c                 | 19 +++---
 drivers/scsi/scsi_scan.c                  | 22 +++----
 drivers/scsi/scsi_sysfs.c                 |  4 +-
 drivers/scsi/smartpqi/smartpqi_init.c     | 13 ++--
 drivers/scsi/snic/snic_main.c             | 12 ++--
 drivers/scsi/stex.c                       |  4 +-
 drivers/scsi/storvsc_drv.c                |  7 +-
 drivers/scsi/sym53c8xx_2/sym_glue.c       | 15 +++--
 drivers/scsi/virtio_scsi.c                |  2 +-
 drivers/scsi/xen-scsifront.c              | 11 ++--
 drivers/staging/rts5208/rtsx.c            |  8 +--
 drivers/ufs/core/ufshcd.c                 | 20 +++---
 drivers/usb/image/microtek.c              |  4 +-
 drivers/usb/storage/scsiglue.c            | 10 +--
 drivers/usb/storage/uas.c                 | 10 +--
 include/linux/libata.h                    | 19 +++---
 include/scsi/libfc.h                      |  2 +-
 include/scsi/libsas.h                     |  9 ++-
 include/scsi/scsi_device.h                |  4 +-
 include/scsi/scsi_host.h                  | 24 +++----
 86 files changed, 508 insertions(+), 479 deletions(-)

Comments

Martin K. Petersen Dec. 5, 2024, 8 p.m. UTC | #1 
Randy,

> Can we expect to see this merged for 6.13-rcN soonish?
>
> I am working on some patches that would like to be applied
> after this series.

Already merged, it's in 6.14/scsi-staging.
Randy Dunlap Dec. 5, 2024, 9:05 p.m. UTC | #2 
On 12/5/24 12:00 PM, Martin K. Petersen wrote:
> 
> Randy,
> 
>> Can we expect to see this merged for 6.13-rcN soonish?
>>
>> I am working on some patches that would like to be applied
>> after this series.
> 
> Already merged, it's in 6.14/scsi-staging.

Ah good. I was looking at the linux-next tree.

thanks.
Martin K. Petersen Dec. 10, 2024, 2:35 a.m. UTC | #3 
On Tue, 22 Oct 2024 11:07:52 -0700, Bart Van Assche wrote:

> The text "slave_" in multiple function names does not make it clear what
> the purpose of these functions is. Hence this patch series that renames all
> SCSI functions that have the word "slave" in their function name. Please
> consider this patch series for the next merge window.
> 
> Thanks,
> 
> [...]

Applied to 6.14/scsi-queue, thanks!

[1/5] scsi: Rename .slave_alloc() and .slave_destroy()
      https://git.kernel.org/mkp/scsi/c/ed638918f4df
[2/5] scsi: Rename .device_configure() into .sdev_configure()
      https://git.kernel.org/mkp/scsi/c/47c2e30afcec
[3/5] scsi: Convert SCSI drivers to .sdev_configure()
      https://git.kernel.org/mkp/scsi/c/49515b7fe50c
[4/5] scsi: core: Remove the .slave_configure() method
      https://git.kernel.org/mkp/scsi/c/0f98212d96a2
[5/5] scsi: core: Update API documentation
      https://git.kernel.org/mkp/scsi/c/b0d3b8514abd