diff mbox series

[4/4] arm64: dts: qcom: sm8750-qrd: Enable CDSP and mention MPSS

Message ID 20241122-b4-sm8750-cdsp-v1-4-9a69a889d1b7@linaro.org
State New
Headers show
Series arm64: dts: qcom: sm8750: CDSP and modem | expand

Commit Message

Krzysztof Kozlowski Nov. 22, 2024, 3:26 p.m. UTC
Enable the CDSP and MPSS (modem) on QRD8750 board.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Not tested on QRD hardware.
---
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Konrad Dybcio Dec. 5, 2024, 5:35 p.m. UTC | #1
On 22.11.2024 4:26 PM, Krzysztof Kozlowski wrote:
> Enable the CDSP and MPSS (modem) on QRD8750 board.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Not tested on QRD hardware.

Not great given the status = "fail" on MTP..

Konrad
Krzysztof Kozlowski Dec. 6, 2024, 8:57 a.m. UTC | #2
On 05/12/2024 18:35, Konrad Dybcio wrote:
> On 22.11.2024 4:26 PM, Krzysztof Kozlowski wrote:
>> Enable the CDSP and MPSS (modem) on QRD8750 board.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Not tested on QRD hardware.
> 
> Not great given the status = "fail" on MTP..

Well, someone will try it. Either it crashes or not. If it crashes, then
person will send report or patch to change it. If it does not, then it
will mean it is tested.

This is a shiny new platform, so no one expects this platform to work
flawlessly and no users are impacted by such untested code. Merging this
has only benefits: more test coverage by early adopters.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 341774bb042ff88af8acf49c2f0ef14f9994dfc9..840a6d8f8a24670a01376f8fce511da222159016 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -789,6 +789,20 @@  &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/sm8750/cdsp.mbn",
+			"qcom/sm8750/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_mpss {
+	firmware-name = "qcom/sm8750/modem.mbn",
+			"qcom/sm8750/modem_dtb.mbn";
+
+	status = "okay";
+};
+
 &tlmm {
 	/* reserved for secure world */
 	gpio-reserved-ranges = <36 4>, <74 1>;