| Message ID | 20241127115107.11549-1-quic_janathot@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable Bluetooth on qcs6490-rb3gen2 board | expand |
On Wed, Nov 27, 2024 at 12:51 PM Janaki Ramaiah Thota <quic_janathot@quicinc.com> wrote: > > - Patch 1/2 enable WCN6750 Bluetooth node for qcs6490-rb3gen2 board > along with onchip PMU. > - Patch 2/2 add qcom,wcn6750-pmu bindings. > > Janaki Ramaiah Thota (2): > arm64: dts: qcom: qcs6490-rb3gen2: enable Bluetooth > regulator: dt-bindings: qcom,qca6390-pmu: document WCN6750 > > .../bindings/regulator/qcom,qca6390-pmu.yaml | 27 +++ > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 174 +++++++++++++++++- > drivers/bluetooth/hci_qca.c | 2 +- > drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 +++ > 4 files changed, 223 insertions(+), 2 deletions(-) > > -- Is there no associated change to the pwrseq-qcom-wcn driver? Bart
On 27/11/2024 12:51, Janaki Ramaiah Thota wrote: > Add a PMU node for the WCN6750 module present on the qcs6490-rb3gen board > and use the power sequencer for the same. > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 174 ++++++++++++++++++- > drivers/bluetooth/hci_qca.c | 2 +- > drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 +++ > 3 files changed, 196 insertions(+), 2 deletions(-) DTS is always separate and cannot go via the same (driver) tree, Missing bindings. Missing changelog, it's v4 so what happened here? Best regards, Krzysztof
On Wed, Nov 27, 2024 at 05:21:05PM +0530, Janaki Ramaiah Thota wrote: > - Patch 1/2 enable WCN6750 Bluetooth node for qcs6490-rb3gen2 board > along with onchip PMU. > - Patch 2/2 add qcom,wcn6750-pmu bindings. - Bindings come before DT changes - Driver changes should be separate, one patch per subtree (so one for BT, one for pwrseq). > > Janaki Ramaiah Thota (2): > arm64: dts: qcom: qcs6490-rb3gen2: enable Bluetooth > regulator: dt-bindings: qcom,qca6390-pmu: document WCN6750 > > .../bindings/regulator/qcom,qca6390-pmu.yaml | 27 +++ > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 174 +++++++++++++++++- > drivers/bluetooth/hci_qca.c | 2 +- > drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 +++ > 4 files changed, 223 insertions(+), 2 deletions(-) > > --
On Wed, Nov 27, 2024 at 05:21:07PM +0530, Janaki Ramaiah Thota wrote: > Add description of the PMU node for the WCN6750 module. > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > .../bindings/regulator/qcom,qca6390-pmu.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof