| Message ID | 20241118095402.516989-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] gpio: altera: Add missed base and label initialisations | expand |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Mon, 18 Nov 2024 11:28:02 +0200, Andy Shevchenko wrote: > During conversion driver to modern APIs the base field initial value > of the GPIO chip was moved from -1 to 0, which triggers a warning. > Add missed base initialisation as it was in the original code. > > Initialise the GPIO chip label correctly as it was done by > of_mm_gpiochip_add_data() before the below mentioned change. > > [...] Applied, thanks! [1/1] gpio: altera: Add missed base and label initialisations commit: c7899503ad9c06a0c6ee2796301139731cf1f5ab Best regards,
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index 039fef26546e..73e660c5e38a 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -261,6 +261,11 @@ static int altera_gpio_probe(struct platform_device *pdev) altera_gc->gc.set = altera_gpio_set; altera_gc->gc.owner = THIS_MODULE; altera_gc->gc.parent = &pdev->dev; + altera_gc->gc.base = -1; + + altera_gc->gc.label = devm_kasprintf(dev, GFP_KERNEL, "%pfw", dev_fwnode(dev)); + if (!altera_gc->gc.label) + return -ENOMEM; altera_gc->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(altera_gc->regs))
During conversion driver to modern APIs the base field initial value of the GPIO chip was moved from -1 to 0, which triggers a warning. Add missed base initialisation as it was in the original code. Initialise the GPIO chip label correctly as it was done by of_mm_gpiochip_add_data() before the below mentioned change. Fixes: 50dded8d9d62 ("gpio: altera: Drop legacy-of-mm-gpiochip.h header") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: explained why label should be initialised (Bart) drivers/gpio/gpio-altera.c | 5 +++++ 1 file changed, 5 insertions(+)