| Message ID | 20241025055054.23170-1-quic_mapa@quicinc.com |
|---|---|
| Headers | show |
| Series | scsi: ufs-qcom: Enable Dumping of Hibern8, MCQ, and Testbus Registers | expand |
On Fri, Oct 25, 2024 at 11:20:51AM +0530, Manish Pandey wrote: > Submitting a series of patches aimed at enhancing the debugging and monitoring capabilities > of the UFS-QCOM driver. These patches introduce new functionalities that will significantly > aid in diagnosing and resolving issues related to hardware and software operations. > TBH, the current state of dumping UFSHC registers itself is just annoying as it pollutes the kernel ring buffer. I don't think any peripheral driver in the kernel does this. Please dump only relevant registers, not everything that you feel like dumping. - Mani > Manish Pandey (3): > scsi: ufs-qcom: Add support for dumping HW and SW hibern8 count > scsi: ufs-qcom: Add support for dumping MCQ registers > scsi: ufs-qcom: Add support for testbus registers > > drivers/ufs/host/ufs-qcom.c | 141 ++++++++++++++++++++++++++++++++++++ > drivers/ufs/host/ufs-qcom.h | 11 +++ > 2 files changed, 152 insertions(+) > > -- > 2.17.1 > >
On 11/11/24 11:50 PM, Manivannan Sadhasivam wrote: > On Fri, Oct 25, 2024 at 11:20:51AM +0530, Manish Pandey wrote: >> Submitting a series of patches aimed at enhancing the debugging and monitoring capabilities >> of the UFS-QCOM driver. These patches introduce new functionalities that will significantly >> aid in diagnosing and resolving issues related to hardware and software operations. >> > > TBH, the current state of dumping UFSHC registers itself is just annoying as it > pollutes the kernel ring buffer. I don't think any peripheral driver in the > kernel does this. Please dump only relevant registers, not everything that you > feel like dumping. I wouldn't mind if the code for dumping UFSHC registers would be removed. Thanks, Bart.