diff mbox series

[RESEND,v2,2/2] leds: pwm: Add optional DT property default-brightness

Message ID 20241105185006.1380166-3-gnstark@salutedevices.com
State New
Headers show
Series leds: pwm: Add default-brightness property | expand

Commit Message

George Stark Nov. 5, 2024, 6:50 p.m. UTC 
When probing if default LED state is on then default brightness will be
applied instead of max brightness.

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
 drivers/leds/leds-pwm.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Comments

Lee Jones Nov. 12, 2024, 12:14 p.m. UTC | #1 
On Tue, 05 Nov 2024 21:50:06 +0300, George Stark wrote:
> When probing if default LED state is on then default brightness will be
> applied instead of max brightness.
> 
> 

Applied, thanks!

[2/2] leds: pwm: Add optional DT property default-brightness
      commit: 8cb08101835d98fd69cfa2a2b06146eddc057df6

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index e1b414b40353..a591cc399704 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -63,6 +63,20 @@  static int led_pwm_set(struct led_classdev *led_cdev,
 	return pwm_apply_might_sleep(led_dat->pwm, &led_dat->pwmstate);
 }
 
+static int led_pwm_default_brightness_get(struct fwnode_handle *fwnode,
+					  int max_brightness)
+{
+	unsigned int default_brightness;
+	int ret;
+
+	ret = fwnode_property_read_u32(fwnode, "default-brightness",
+				       &default_brightness);
+	if (ret < 0 || default_brightness > max_brightness)
+		default_brightness = max_brightness;
+
+	return default_brightness;
+}
+
 __attribute__((nonnull))
 static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
 		       struct led_pwm *led, struct fwnode_handle *fwnode)
@@ -104,7 +118,8 @@  static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
 	/* set brightness */
 	switch (led->default_state) {
 	case LEDS_DEFSTATE_ON:
-		led_data->cdev.brightness = led->max_brightness;
+		led_data->cdev.brightness =
+			led_pwm_default_brightness_get(fwnode, led->max_brightness);
 		break;
 	case LEDS_DEFSTATE_KEEP:
 		{