| Message ID | 20241105180444.770951-1-quic_rajkbhag@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Add wifi device node with WSI for QCN9274 in RDP433 | expand |
On 05/11/2024 19:04, Raj Kumar Bhagat wrote: > The RDP433 is a Qualcomm Reference Design Platform based on the > IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, > PCIe2, and PCIe3. These devices are also interconnected via a WLAN > Serial Interface (WSI) connection. This WSI connection is essential > for exchanging control information among these devices. > > This patch series describes the WSI interface found in QCN9274 in > device tree and uses this device tree node in the Ath12k driver to get the > details of WSI connection for Multi Link Operation (MLO) among multiple > QCN9274 devices. > > NOTES: > 1. As ath12k MLO patches are not ready yet, this patchset does not apply > to the ath.git ath-next branch and that's why the patchset is marked > as RFC. These are the work-in-progress patches we have at the moment. > The full set of MLO patches is available at: > https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 > > 2. The dependency marked below applies only to the DTS patch. The > dt-bindings patches do not have this dependency. > > Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 > Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ > > v3: > - Created a separate binding "qcom,ath12k-wsi.yaml" to describe ath12k PCI > devices with WSI interface. Thanks for the changes. When you finish with testing/RFC, please send proper version for review (just remember to keep numbering, next one is v4 regardless whether this is RFC or not). Best regards, Krzysztof
On 07/11/2024 13:03, Dmitry Baryshkov wrote: > On Thu, 7 Nov 2024 at 11:29, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 07/11/2024 12:06, Dmitry Baryshkov wrote: >>> On Thu, Nov 07, 2024 at 11:23:20AM +0100, Krzysztof Kozlowski wrote: >>>> On 05/11/2024 19:04, Raj Kumar Bhagat wrote: >>>>> The RDP433 is a Qualcomm Reference Design Platform based on the >>>>> IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, >>>>> PCIe2, and PCIe3. These devices are also interconnected via a WLAN >>>>> Serial Interface (WSI) connection. This WSI connection is essential >>>>> for exchanging control information among these devices. >>>>> >>>>> This patch series describes the WSI interface found in QCN9274 in >>>>> device tree and uses this device tree node in the Ath12k driver to get the >>>>> details of WSI connection for Multi Link Operation (MLO) among multiple >>>>> QCN9274 devices. >>>>> >>>>> NOTES: >>>>> 1. As ath12k MLO patches are not ready yet, this patchset does not apply >>>>> to the ath.git ath-next branch and that's why the patchset is marked >>>>> as RFC. These are the work-in-progress patches we have at the moment. >>>>> The full set of MLO patches is available at: >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 >>>>> >>>>> 2. The dependency marked below applies only to the DTS patch. The >>>>> dt-bindings patches do not have this dependency. >>>>> >>>>> Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 >>>>> Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ >>>>> >>>>> v3: >>>>> - Created a separate binding "qcom,ath12k-wsi.yaml" to describe ath12k PCI >>>>> devices with WSI interface. >>>> >>>> Thanks for the changes. When you finish with testing/RFC, please send >>>> proper version for review (just remember to keep numbering, next one is >>>> v4 regardless whether this is RFC or not). >>> >>> Isn't the 'RFC' being an invitation for review per the nature of the tag >>> itself? >> >> No, RFC means patch is not ready, might change. This was brought on the >> lists multiple times and some maintainers clearly ignore RFC. Including me. > > Thanks, point noted. I'll stop marking my patches with RFC tag. Wait, you can keep marking them RFC! It all depends what do you want to achieve. Get some comments on early work or actual review for something you believe is a finished work. I looked here briefly, no comments from me and I assume that was the intention of RFC. Best regards, Krzysztof
On Thu, Nov 07, 2024 at 01:16:56PM +0100, Krzysztof Kozlowski wrote: > On 07/11/2024 13:03, Dmitry Baryshkov wrote: > > On Thu, 7 Nov 2024 at 11:29, Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On 07/11/2024 12:06, Dmitry Baryshkov wrote: > >>> On Thu, Nov 07, 2024 at 11:23:20AM +0100, Krzysztof Kozlowski wrote: > >>>> On 05/11/2024 19:04, Raj Kumar Bhagat wrote: > >>>>> The RDP433 is a Qualcomm Reference Design Platform based on the > >>>>> IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, > >>>>> PCIe2, and PCIe3. These devices are also interconnected via a WLAN > >>>>> Serial Interface (WSI) connection. This WSI connection is essential > >>>>> for exchanging control information among these devices. > >>>>> > >>>>> This patch series describes the WSI interface found in QCN9274 in > >>>>> device tree and uses this device tree node in the Ath12k driver to get the > >>>>> details of WSI connection for Multi Link Operation (MLO) among multiple > >>>>> QCN9274 devices. > >>>>> > >>>>> NOTES: > >>>>> 1. As ath12k MLO patches are not ready yet, this patchset does not apply > >>>>> to the ath.git ath-next branch and that's why the patchset is marked > >>>>> as RFC. These are the work-in-progress patches we have at the moment. > >>>>> The full set of MLO patches is available at: > >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 > >>>>> > >>>>> 2. The dependency marked below applies only to the DTS patch. The > >>>>> dt-bindings patches do not have this dependency. > >>>>> > >>>>> Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 > >>>>> Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ > >>>>> > >>>>> v3: > >>>>> - Created a separate binding "qcom,ath12k-wsi.yaml" to describe ath12k PCI > >>>>> devices with WSI interface. > >>>> > >>>> Thanks for the changes. When you finish with testing/RFC, please send > >>>> proper version for review (just remember to keep numbering, next one is > >>>> v4 regardless whether this is RFC or not). > >>> > >>> Isn't the 'RFC' being an invitation for review per the nature of the tag > >>> itself? > >> > >> No, RFC means patch is not ready, might change. This was brought on the > >> lists multiple times and some maintainers clearly ignore RFC. Including me. > > > > Thanks, point noted. I'll stop marking my patches with RFC tag. > > Wait, you can keep marking them RFC! It all depends what do you want to > achieve. Get some comments on early work or actual review for something > you believe is a finished work. > > I looked here briefly, no comments from me and I assume that was the > intention of RFC. Okay
Krzysztof Kozlowski <krzk@kernel.org> writes: > On 07/11/2024 13:03, Dmitry Baryshkov wrote: > >> On Thu, 7 Nov 2024 at 11:29, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> >>> On 07/11/2024 12:06, Dmitry Baryshkov wrote: >>>> On Thu, Nov 07, 2024 at 11:23:20AM +0100, Krzysztof Kozlowski wrote: >>>>> On 05/11/2024 19:04, Raj Kumar Bhagat wrote: >>>>>> The RDP433 is a Qualcomm Reference Design Platform based on the >>>>>> IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, >>>>>> PCIe2, and PCIe3. These devices are also interconnected via a WLAN >>>>>> Serial Interface (WSI) connection. This WSI connection is essential >>>>>> for exchanging control information among these devices. >>>>>> >>>>>> This patch series describes the WSI interface found in QCN9274 in >>>>>> device tree and uses this device tree node in the Ath12k driver to get the >>>>>> details of WSI connection for Multi Link Operation (MLO) among multiple >>>>>> QCN9274 devices. >>>>>> >>>>>> NOTES: >>>>>> 1. As ath12k MLO patches are not ready yet, this patchset does not apply >>>>>> to the ath.git ath-next branch and that's why the patchset is marked >>>>>> as RFC. These are the work-in-progress patches we have at the moment. >>>>>> The full set of MLO patches is available at: >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 >>>>>> >>>>>> 2. The dependency marked below applies only to the DTS patch. The >>>>>> dt-bindings patches do not have this dependency. >>>>>> >>>>>> Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 >>>>>> Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ >>>>>> >>>>>> v3: >>>>>> - Created a separate binding "qcom,ath12k-wsi.yaml" to describe ath12k PCI >>>>>> devices with WSI interface. >>>>> >>>>> Thanks for the changes. When you finish with testing/RFC, please send >>>>> proper version for review (just remember to keep numbering, next one is >>>>> v4 regardless whether this is RFC or not). >>>> >>>> Isn't the 'RFC' being an invitation for review per the nature of the tag >>>> itself? >>> >>> No, RFC means patch is not ready, might change. This was brought on the >>> lists multiple times and some maintainers clearly ignore RFC. Including me. >> >> Thanks, point noted. I'll stop marking my patches with RFC tag. > > Wait, you can keep marking them RFC! It all depends what do you want to > achieve. Get some comments on early work or actual review for something > you believe is a finished work. > > I looked here briefly, no comments from me and I assume that was the > intention of RFC. Exactly, we just wanted to have early feedback how to handle this feature. We will now incorporate these changes to our work-in-progress ath12kl-mlo branches, test them and once everything else in ath12k is ready we will submit the next patchset without RFC tag.
The RDP433 is a Qualcomm Reference Design Platform based on the IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, PCIe2, and PCIe3. These devices are also interconnected via a WLAN Serial Interface (WSI) connection. This WSI connection is essential for exchanging control information among these devices. This patch series describes the WSI interface found in QCN9274 in device tree and uses this device tree node in the Ath12k driver to get the details of WSI connection for Multi Link Operation (MLO) among multiple QCN9274 devices. NOTES: 1. As ath12k MLO patches are not ready yet, this patchset does not apply to the ath.git ath-next branch and that's why the patchset is marked as RFC. These are the work-in-progress patches we have at the moment. The full set of MLO patches is available at: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 2. The dependency marked below applies only to the DTS patch. The dt-bindings patches do not have this dependency. Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ v3: - Created a separate binding "qcom,ath12k-wsi.yaml" to describe ath12k PCI devices with WSI interface. - The "wsi" node is dropped. - The property "qcom,wsi-master" renamed to "qcom,wsi-controller". - Updated description for "qcom,wsi-controller". - The "qcom,wsi-group-id" property is dropped. - The ath12k driver changes added to dynamically assign wsi group IDs. - DTS changes done to make device node name generic (wifi). - The patch series title is updated. v2: https://patchwork.kernel.org/project/linux-wireless/cover/20241029173050.2188150-1-quic_rajkbhag@quicinc.com/ - "Graph with endpoint” is used to define the actual WSI connection in the DT binding. - The qcom,wsi-index and qcom,wsi-num-devices properties are dropped from the binding. These are now determined in the driver using the graph with endpoint. - The qcom,wsi-master property is added to the binding to define the WSI master. - The qcom,ath12k-calibration-variant property is added to the binding for ath12k devices. - DTS changes are made based on the “graph with endpoint” binding. - The ath12k driver is updated to read graph nodes, determine the number of devices in WSI, and assign the wsi-index for each device. - The ath12k driver now assigns hardware link IDs based on the order of WSI connections. v1: https://patchwork.kernel.org/project/linux-wireless/cover/20241023060352.605019-1-quic_rajkbhag@quicinc.com/ Aditya Kumar Singh (1): wifi: ath12k: Assign unique hardware link IDs during QMI host capability Harshitha Prem (1): wifi: ath12k: Parse multiple device information from device tree Karthikeyan Periyasamy (1): wifi: ath12k: Send partner device details in QMI MLO capability Raj Kumar Bhagat (2): dt-bindings: net: wireless: Describe ath12k PCI module with WSI arm64: dts: qcom: ipq9574: Add WiFi nodes for RDP433 .../net/wireless/qcom,ath12k-wsi.yaml | 205 ++++++++++++++++++ arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 105 ++++++++- drivers/net/wireless/ath/ath12k/core.c | 178 +++++++++++++-- drivers/net/wireless/ath/ath12k/core.h | 10 + drivers/net/wireless/ath/ath12k/qmi.c | 120 ++++++++-- 5 files changed, 588 insertions(+), 30 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-wsi.yaml base-commit: 7603a9349b2fc64152a734f253cf8d8e5befb6db prerequisite-patch-id: d1334693a2e8da65ae7b458ee4adb459850ad2e7 prerequisite-patch-id: 87f73b342f67c2636390a7da1294cee90f1fff48 prerequisite-patch-id: 46d8302766527d16cdd90c59ded6cbae0ec4ad70 prerequisite-patch-id: b17db6783b1c35f3e8812f621730fe0a1a57a14e