mbox series

[v3,0/5] iio: hid-sensors-prox: Add support for more channels

Message ID 20241101-hpd-v3-0-e9c80b7c7164@chromium.org
Headers show
Series iio: hid-sensors-prox: Add support for more channels | expand

Message

Ricardo Ribalda Nov. 1, 2024, 7:46 a.m. UTC
EgisVision 620 provides two additional channels:
- proximity
- attention

Add support for them.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v3:
- Make attention CHAN_INFO_PROCESSED.
- Fix comment style.
- Multiply attention by 100 to make it a percentage.
- Link to v2: https://lore.kernel.org/r/20241028-hpd-v2-0-18f6e79154d7@chromium.org

Changes in v2 (Thanks Jonathan):
- Create new attention channel type.
- Improve documentation for HID usages.
- Link to v1: https://lore.kernel.org/r/20241024-hpd-v1-0-2a125882f1f8@chromium.org

---
Ricardo Ribalda (5):
      iio: hid-sensors: Add proximity and attention IDs
      iio: hid-sensors-prox: Factor-in hid_sensor_push_data
      iio: Add channel type for attention
      iio: hid-sensors-prox: Make proximity channel indexed
      iio: hid-sensor-prox: Add support for more channels

 Documentation/ABI/testing/sysfs-bus-iio |   8 ++
 drivers/iio/industrialio-core.c         |   1 +
 drivers/iio/light/hid-sensor-prox.c     | 195 ++++++++++++++++++--------------
 include/linux/hid-sensor-ids.h          |   2 +
 include/uapi/linux/iio/types.h          |   1 +
 tools/iio/iio_event_monitor.c           |   2 +
 6 files changed, 122 insertions(+), 87 deletions(-)
---
base-commit: c2ee9f594da826bea183ed14f2cc029c719bf4da
change-id: 20241023-hpd-edeb37f1ffc4

Best regards,

Comments

Jonathan Cameron Nov. 1, 2024, 3:32 p.m. UTC | #1
On Fri, 01 Nov 2024 07:46:26 +0000
Ricardo Ribalda <ribalda@chromium.org> wrote:

> EgisVision 620 provides two additional channels:
> - proximity
> - attention
> 
> Add support for them.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Looks good to me. I'll queue it up, but Jiri / Srinivas if either of you have time
to take a look as well that would be great of course.

I'll only push this out as testing for now to let 0-day take a look.


> ---
> Changes in v3:
> - Make attention CHAN_INFO_PROCESSED.
> - Fix comment style.
> - Multiply attention by 100 to make it a percentage.
> - Link to v2: https://lore.kernel.org/r/20241028-hpd-v2-0-18f6e79154d7@chromium.org
> 
> Changes in v2 (Thanks Jonathan):
> - Create new attention channel type.
> - Improve documentation for HID usages.
> - Link to v1: https://lore.kernel.org/r/20241024-hpd-v1-0-2a125882f1f8@chromium.org
> 
> ---
> Ricardo Ribalda (5):
>       iio: hid-sensors: Add proximity and attention IDs
>       iio: hid-sensors-prox: Factor-in hid_sensor_push_data
>       iio: Add channel type for attention
>       iio: hid-sensors-prox: Make proximity channel indexed
>       iio: hid-sensor-prox: Add support for more channels
> 
>  Documentation/ABI/testing/sysfs-bus-iio |   8 ++
>  drivers/iio/industrialio-core.c         |   1 +
>  drivers/iio/light/hid-sensor-prox.c     | 195 ++++++++++++++++++--------------
>  include/linux/hid-sensor-ids.h          |   2 +
>  include/uapi/linux/iio/types.h          |   1 +
>  tools/iio/iio_event_monitor.c           |   2 +
>  6 files changed, 122 insertions(+), 87 deletions(-)
> ---
> base-commit: c2ee9f594da826bea183ed14f2cc029c719bf4da
> change-id: 20241023-hpd-edeb37f1ffc4
> 
> Best regards,