mbox series

[v2,0/2] Enable Display Port for Qualcomm SA8775P-ride platform

Message ID 20241008112516.17702-1-quic_mukhopad@quicinc.com
Headers show
Series Enable Display Port for Qualcomm SA8775P-ride platform | expand

Message

Soutrik Mukhopadhyay Oct. 8, 2024, 11:25 a.m. UTC 
This series adds the DPTX0 and DPTX1 nodes, as a part of mdss0
on Qualcomm SA8775P SoC. It also enables Display Port on Qualcomm
SA8775P-ride platform.

---
This patch depends on following series:
https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0cef@quicinc.com/
https://lore.kernel.org/all/20241001-patchv3_1-v3-0-d23284f45977@quicinc.com/
https://lore.kernel.org/all/20241004103046.22209-1-quic_mukhopad@quicinc.com/
Link to v1: https://lore.kernel.org/all/20240916091344.27607-1-quic_mukhopad@quicinc.com/

v2: Fixed review comments from Dmitry, Konrad and Bjorn
	- Added a new patchset to separate out the soc and board parts.[Konrad]
	- Patchset 1 now comprises of the soc parts and patchset 2 includes board specific changes.[Bjorn]
	- Patchset 2 enables all the DP ports validated on the sa8775p-ride platform.[Bjorn]
	- Fixed indentation errors in the dtsi file containing the soc information.[Dmitry][Konrad]
	- Updated clocks to be used by respective PHYs.[Dmitry]
	- Added mdss0_dp1 device node.[Dmitry]
	- Updated the names of PHYs using label prefix "mdssM_dpN" for clarity.[Bjorn]
	- Avoided use of referring any label in the board(dts) file in the dtsi(platform) file.[Bjorn]

---

Soutrik Mukhopadhyay (2):
  arm64: dts: qcom: sa8775p: add DisplayPort device nodes
  arm64: dts: qcom: sa8775p-ride: Enable Display Port

 arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi |  54 ++++++
 arch/arm64/boot/dts/qcom/sa8775p.dtsi      | 216 ++++++++++++++++++++-
 2 files changed, 269 insertions(+), 1 deletion(-)

Comments

Dmitry Baryshkov Oct. 8, 2024, 12:16 p.m. UTC | #1 
On Tue, Oct 08, 2024 at 04:55:16PM GMT, Soutrik Mukhopadhyay wrote:
> Enable DPTX0 and DPTX1 along with their corresponding PHYs for
> sa8775p-ride platform.

What is connected to those DP lanes? If they are routed directly to the
DisplayPort connectors, please add corresponding devices (see
dp-connector).

> 
> Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 54 ++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
> 
>
Soutrik Mukhopadhyay Oct. 29, 2024, 6:08 a.m. UTC | #2 
On 10/28/2024 3:15 PM, Dmitry Baryshkov wrote:
> On Mon, 28 Oct 2024 at 10:49, Soutrik Mukhopadhyay
> <quic_mukhopad@quicinc.com> wrote:
>>
>> On 10/8/2024 5:46 PM, Dmitry Baryshkov wrote:
>>> On Tue, Oct 08, 2024 at 04:55:16PM GMT, Soutrik Mukhopadhyay wrote:
>>>> Enable DPTX0 and DPTX1 along with their corresponding PHYs for
>>>> sa8775p-ride platform.
>>> What is connected to those DP lanes? If they are routed directly to the
>>> DisplayPort connectors, please add corresponding devices (see
>>> dp-connector).
>>
>> We are defining the functionality of gpio101 and gpio102 as "edp0_hot"
>> and "edp1_hot"
>>
>> respectively. This ensures that the hot plug will be directly routed via
>> the display interrupt
>>
>> line "mdss0" to the display port driver and no external dependencies on
>> dp-connector is
>>
>> necessary.
> Please describe the hardware, not the driver necessities.
> If the board has a DP connector, please add the node. E.g. it allows
> one to specify the label and the type used by the connector.
>
> Also could you please fix your email client so that you don't have
> strange/unnecessary line wraps and empty lines?

Addition of DP connector node with the hpd-gpio property does not allow 
hpd to be detected since the gpio

101/102 have the "edp0_hot" as function. If the hpd-gpio property is 
removed from the DP connector node,

the probe of DP connector will fail.


>