mbox series

[0/5] Ceph deadcoding

Message ID 20241006011956.373622-1-linux@treblig.org
Headers show
Series Ceph deadcoding | expand

Message

Dr. David Alan Gilbert Oct. 6, 2024, 1:19 a.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  This series is a set of deadcoding in fs/ceph and net/ceph.
It's strictly function deletion so should have no change
in behaviour.

(get_maintainer was suggesting the netdev team as well
as ceph? Is that correct???)

Build & boot tested on x86-64.

Dave

Dr. David Alan Gilbert (5):
  libceph: Remove unused ceph_pagelist functions
  libceph: Remove unused pagevec functions
  libceph: Remove unused ceph_osdc_watch_check
  libceph: Remove unused ceph_crypto_key_encode
  ceph: Remove fs/ceph deadcode

 fs/ceph/caps.c                  | 14 ---------
 fs/ceph/mds_client.c            |  8 -----
 fs/ceph/mds_client.h            |  2 --
 fs/ceph/super.h                 |  1 -
 include/linux/ceph/libceph.h    |  6 ----
 include/linux/ceph/osd_client.h |  2 --
 include/linux/ceph/pagelist.h   | 12 --------
 net/ceph/crypto.c               | 12 --------
 net/ceph/crypto.h               |  1 -
 net/ceph/osd_client.c           | 34 ---------------------
 net/ceph/pagelist.c             | 38 ------------------------
 net/ceph/pagevec.c              | 52 ---------------------------------
 12 files changed, 182 deletions(-)

Comments

Ilya Dryomov Oct. 27, 2024, 7:53 p.m. UTC | #1
On Sun, Oct 6, 2024 at 3:19 AM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Hi,
>   This series is a set of deadcoding in fs/ceph and net/ceph.
> It's strictly function deletion so should have no change
> in behaviour.
>
> (get_maintainer was suggesting the netdev team as well
> as ceph? Is that correct???)
>
> Build & boot tested on x86-64.
>
> Dave
>
> Dr. David Alan Gilbert (5):
>   libceph: Remove unused ceph_pagelist functions
>   libceph: Remove unused pagevec functions
>   libceph: Remove unused ceph_osdc_watch_check
>   libceph: Remove unused ceph_crypto_key_encode
>   ceph: Remove fs/ceph deadcode
>
>  fs/ceph/caps.c                  | 14 ---------
>  fs/ceph/mds_client.c            |  8 -----
>  fs/ceph/mds_client.h            |  2 --
>  fs/ceph/super.h                 |  1 -
>  include/linux/ceph/libceph.h    |  6 ----
>  include/linux/ceph/osd_client.h |  2 --
>  include/linux/ceph/pagelist.h   | 12 --------
>  net/ceph/crypto.c               | 12 --------
>  net/ceph/crypto.h               |  1 -
>  net/ceph/osd_client.c           | 34 ---------------------
>  net/ceph/pagelist.c             | 38 ------------------------
>  net/ceph/pagevec.c              | 52 ---------------------------------
>  12 files changed, 182 deletions(-)

Applied.

Thanks,

                Ilya
Ilya Dryomov Oct. 27, 2024, 8:16 p.m. UTC | #2
On Sun, Oct 6, 2024 at 3:19 AM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Hi,
>   This series is a set of deadcoding in fs/ceph and net/ceph.
> It's strictly function deletion so should have no change
> in behaviour.
>
> (get_maintainer was suggesting the netdev team as well
> as ceph? Is that correct???)

Hi David,

No, it's not correct.  It's probably caused by

F:    net/

entry in "NETWORKING [GENERAL]" section.  I don't recall
get_maintainer.pl doing that in the past, but I could be wrong.
Anyway, I'll send a patch to exclude net/ceph there.

Thanks,

                Ilya
Dr. David Alan Gilbert Oct. 27, 2024, 8:45 p.m. UTC | #3
* Ilya Dryomov (idryomov@gmail.com) wrote:
> On Sun, Oct 6, 2024 at 3:19 AM <linux@treblig.org> wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Hi,
> >   This series is a set of deadcoding in fs/ceph and net/ceph.
> > It's strictly function deletion so should have no change
> > in behaviour.
> >
> > (get_maintainer was suggesting the netdev team as well
> > as ceph? Is that correct???)
> 
> Hi David,
> 
> No, it's not correct.  It's probably caused by
> 
> F:    net/
> 
> entry in "NETWORKING [GENERAL]" section.  I don't recall
> get_maintainer.pl doing that in the past, but I could be wrong.

THanks, I didn't think it was right.

> Anyway, I'll send a patch to exclude net/ceph there.

Thanks, and thanks for applying the cleanup.

Dave

> Thanks,
> 
>                 Ilya
>