Message ID | 20241022155658.1647350-1-antonio.borneo@foss.st.com |
---|---|
Headers | show |
Series | pinctrl: stm32: Add new features and support for more SoC | expand |
On Tue, Oct 22, 2024 at 05:56:48PM +0200, Antonio Borneo wrote: > From: Fabien Dessenne <fabien.dessenne@foss.st.com> > > Document the RSVD (Reserved) mux function, used to reserve pins > for a coprocessor not running Linux. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> > --- > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 8 ++++++++ > include/dt-bindings/pinctrl/stm32-pinfunc.h | 1 + > 2 files changed, 9 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Oct 22, 2024 at 05:56:48PM +0200, Antonio Borneo wrote: > From: Fabien Dessenne <fabien.dessenne@foss.st.com> > > Document the RSVD (Reserved) mux function, used to reserve pins > for a coprocessor not running Linux. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> > --- > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 8 ++++++++ > include/dt-bindings/pinctrl/stm32-pinfunc.h | 1 + > 2 files changed, 9 insertions(+) > BTW, which *existing* SoCs use it? Aren't you adding it for the new platform? Best regards, Krzysztof
On Wed, 2024-10-23 at 10:47 +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 22, 2024 at 05:56:48PM +0200, Antonio Borneo wrote: > > From: Fabien Dessenne <fabien.dessenne@foss.st.com> > > > > Document the RSVD (Reserved) mux function, used to reserve pins > > for a coprocessor not running Linux. > > > > Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com> > > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> > > --- > > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 8 ++++++++ > > include/dt-bindings/pinctrl/stm32-pinfunc.h | 1 + > > 2 files changed, 9 insertions(+) > > > > BTW, which *existing* SoCs use it? Aren't you adding it for the new > platform? > This is already used in ST downstream kernel for STM32MP15x In this example https://github.com/STMicroelectronics/linux/blob/v6.1-stm32mp/arch/arm/boot/dts/stm32mp157f-dk2-m4-examples.dts#L112 the GPIOs for LED and for PWM are assigned to the Cortex-M4 and Linux (on Cortex-A7) is not supposed to touch them. Regards, Antonio
On Tue, Oct 22, 2024 at 5:59 PM Antonio Borneo <antonio.borneo@foss.st.com> wrote: > This series introduces the support for the new SoC > - STM32MP215, > - STM32MP235, > > by adding the support for the new functionalities > - irq affinity, > - Resource Isolation Framework (RIF), > - Reserved (RSVD) pinmux function, > - IO synchronization parameters, > - compile the driver as module. > > Some minor code reorganization is also introduced. Overallt the code looks good to me (I see bindings are being discussed and I might have some comment on that as well.) I wonder if Maxime can look over the code as well? He's the only STM32 maintainer who hasn't written any of the patches and I think he knows the driver pretty well. Yours, Linus Walleij