mbox series

[v3,0/3] build qemu with gcc and tsan

Message ID 20240910174013.1433331-1-pierrick.bouvier@linaro.org
Headers show
Series build qemu with gcc and tsan | expand

Message

Pierrick Bouvier Sept. 10, 2024, 5:40 p.m. UTC
While working on a concurrency bug, I gave a try to tsan builds for QEMU. I
noticed it didn't build out of the box with recent gcc, so I fixed compilation.
In more, updated documentation to explain how to build a sanitized glib to avoid
false positives related to glib synchronisation primitives.

v3
- rebased on top of master
- previous conversation shifted on why clang does not implement some warnings
- hopefully we can review the content of patches this time

v2
- forgot to signoff commits

Pierrick Bouvier (3):
  meson: hide tsan related warnings
  target/i386: fix build warning (gcc-12 -fsanitize=thread)
  docs/devel: update tsan build documentation

 docs/devel/testing/main.rst | 26 ++++++++++++++++++++++----
 meson.build                 | 10 +++++++++-
 target/i386/kvm/kvm.c       |  4 ++--
 3 files changed, 33 insertions(+), 7 deletions(-)

Comments

Thomas Huth Sept. 25, 2024, 7:31 a.m. UTC | #1
On 10/09/2024 19.40, Pierrick Bouvier wrote:
> While working on a concurrency bug, I gave a try to tsan builds for QEMU. I
> noticed it didn't build out of the box with recent gcc, so I fixed compilation.
> In more, updated documentation to explain how to build a sanitized glib to avoid
> false positives related to glib synchronisation primitives.
> 
> v3
> - rebased on top of master
> - previous conversation shifted on why clang does not implement some warnings
> - hopefully we can review the content of patches this time
> 
> v2
> - forgot to signoff commits
> 
> Pierrick Bouvier (3):
>    meson: hide tsan related warnings
>    target/i386: fix build warning (gcc-12 -fsanitize=thread)
>    docs/devel: update tsan build documentation
> 
>   docs/devel/testing/main.rst | 26 ++++++++++++++++++++++----
>   meson.build                 | 10 +++++++++-
>   target/i386/kvm/kvm.c       |  4 ++--
>   3 files changed, 33 insertions(+), 7 deletions(-)
> 

Series
Reviewed-by: Thomas Huth <thuth@redhat.com>
Alex Bennée Sept. 25, 2024, 10:43 a.m. UTC | #2
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> While working on a concurrency bug, I gave a try to tsan builds for QEMU. I
> noticed it didn't build out of the box with recent gcc, so I fixed compilation.
> In more, updated documentation to explain how to build a sanitized glib to avoid
> false positives related to glib synchronisation primitives.

Queued to testing/next, thanks.
Pierrick Bouvier Oct. 21, 2024, 4:12 p.m. UTC | #3
On 9/25/24 03:43, Alex Bennée wrote:
> Alex Bennée <alex.bennee@linaro.org> writes:
> 
> Queued to testing/next, thanks.
> 

Gentle ping. I can't see this series on testing/next. Was it lost on the 
way?

Thanks,
Pierrick