| Message ID | 20241013051239.22564-1-jonathan@marek.ca |
|---|---|
| Headers | show |
| Series | efi/libstub: fix efi_parse_options() ignoring the default command line | expand |
On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@marek.ca> wrote: > > v2: > - changed to check for NUL character instead of size==1 > - reworked cleanup patch to remove cmd_line_len > - moved 3rd commit out of this series > > Jonathan Marek (2): > efi/libstub: fix efi_parse_options() ignoring the default command line > efi/libstub: remove unnecessary cmd_line_len from > efi_convert_cmdline() > Thanks. I'm inclined to fold these together and just merge them as a single patch. Any objections?
On 10/13/24 1:30 PM, Ard Biesheuvel wrote: > On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@marek.ca> wrote: >> >> v2: >> - changed to check for NUL character instead of size==1 >> - reworked cleanup patch to remove cmd_line_len >> - moved 3rd commit out of this series >> >> Jonathan Marek (2): >> efi/libstub: fix efi_parse_options() ignoring the default command line >> efi/libstub: remove unnecessary cmd_line_len from >> efi_convert_cmdline() >> > > Thanks. I'm inclined to fold these together and just merge them as a > single patch. Any objections? > No objections (its not important to me, but if you want to get the fix into stable I think the separate commits makes that easier?)
On Sun, 13 Oct 2024 at 21:25, Jonathan Marek <jonathan@marek.ca> wrote: > > On 10/13/24 1:30 PM, Ard Biesheuvel wrote: > > On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@marek.ca> wrote: > >> > >> v2: > >> - changed to check for NUL character instead of size==1 > >> - reworked cleanup patch to remove cmd_line_len > >> - moved 3rd commit out of this series > >> > >> Jonathan Marek (2): > >> efi/libstub: fix efi_parse_options() ignoring the default command line > >> efi/libstub: remove unnecessary cmd_line_len from > >> efi_convert_cmdline() > >> > > > > Thanks. I'm inclined to fold these together and just merge them as a > > single patch. Any objections? > > > > No objections (its not important to me, but if you want to get the fix > into stable I think the separate commits makes that easier?) Yeah good point. I am not going to send these out as fixes anyway, given that they affect boot behavior, and there are some other things to fix.
v2: - changed to check for NUL character instead of size==1 - reworked cleanup patch to remove cmd_line_len - moved 3rd commit out of this series Jonathan Marek (2): efi/libstub: fix efi_parse_options() ignoring the default command line efi/libstub: remove unnecessary cmd_line_len from efi_convert_cmdline() drivers/firmware/efi/libstub/efi-stub-helper.c | 3 +-- drivers/firmware/efi/libstub/efi-stub.c | 7 +++---- drivers/firmware/efi/libstub/efistub.h | 2 +- drivers/firmware/efi/libstub/x86-stub.c | 3 +-- 4 files changed, 6 insertions(+), 9 deletions(-)