diff mbox series

Make AVB_VERIFY depend on FASTBOOT

Message ID 20241002144845.1439316-1-jerome.forissier@linaro.org
State Superseded
Headers show
Series Make AVB_VERIFY depend on FASTBOOT | expand

Commit Message

Jerome Forissier Oct. 2, 2024, 2:48 p.m. UTC
AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 common/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Mattijs Korpershoek Oct. 8, 2024, 1:15 p.m. UTC | #1
Hi Jerome,

Thank you for the patch.

On mer., oct. 02, 2024 at 16:48, Jerome Forissier <jerome.forissier@linaro.org> wrote:

> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  common/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 957de0c5c02..c011ab6e820 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -850,6 +850,7 @@ config AVB_VERIFY
>  	depends on LIBAVB
>  	depends on MMC
>  	depends on PARTITION_UUIDS
> +	depends on FASTBOOT
>  	help
>  	  This option enables compilation of bootloader-dependent operations,
>  	  used by Android Verified Boot 2.0 library (libavb). Includes:
> -- 
> 2.40.1
Mattijs Korpershoek Oct. 11, 2024, 12:32 p.m. UTC | #2
Hi,

On Wed, 02 Oct 2024 16:48:45 +0200, Jerome Forissier wrote:
> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
> 
> 

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)

[1/1] Make AVB_VERIFY depend on FASTBOOT
      https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/ce1023de730ffa37beae46a5276061a74a041a09

--
Mattijs
diff mbox series

Patch

diff --git a/common/Kconfig b/common/Kconfig
index 957de0c5c02..c011ab6e820 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -850,6 +850,7 @@  config AVB_VERIFY
 	depends on LIBAVB
 	depends on MMC
 	depends on PARTITION_UUIDS
+	depends on FASTBOOT
 	help
 	  This option enables compilation of bootloader-dependent operations,
 	  used by Android Verified Boot 2.0 library (libavb). Includes: