mbox series

[0/2] Some cfg80211 deadcode removal

Message ID 20241006225303.121445-1-linux@treblig.org
Headers show
Series Some cfg80211 deadcode removal | expand

Message

Dr. David Alan Gilbert Oct. 6, 2024, 10:53 p.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  These are a few unused functions a script of mine
found.  They've been unused for a few years.

Dave

Dr. David Alan Gilbert (2):
  cfg80211: Remove unused cfg80211_background_cac_abort
  cfg80211: Remove unused cfg80211_vendor_ functions

 include/net/cfg80211.h | 54 ------------------------------------------
 net/wireless/mlme.c    |  8 -------
 net/wireless/nl80211.c | 11 ---------
 3 files changed, 73 deletions(-)

Comments

Johannes Berg Oct. 7, 2024, 11:04 a.m. UTC | #1
On Sun, 2024-10-06 at 23:53 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> cfg80211_vendor_cmd_get_sender() and cfg80211_vendor_event_alloc_ucast()
> were added in 2019 by commit
> 55c1fdf0d6c5 ("cfg80211: allow sending vendor events unicast")
> 
> but never used.
> 

Yeah ... we have out-of-tree code using this for CSI matrix stuff
(sensing), but I guess we can keep this API out-of-tree just as well,
though it'll make it harder to integrate in ChromeOS.

johannes
Dr. David Alan Gilbert Oct. 7, 2024, 11:29 a.m. UTC | #2
* Johannes Berg (johannes@sipsolutions.net) wrote:
> On Sun, 2024-10-06 at 23:53 +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > cfg80211_vendor_cmd_get_sender() and cfg80211_vendor_event_alloc_ucast()
> > were added in 2019 by commit
> > 55c1fdf0d6c5 ("cfg80211: allow sending vendor events unicast")
> > 
> > but never used.
> > 
> 
> Yeah ... we have out-of-tree code using this for CSI matrix stuff
> (sensing), but I guess we can keep this API out-of-tree just as well,
> though it'll make it harder to integrate in ChromeOS.

Obviously it's the maintainers call as which way to go.
I guess the best outcome would be for that out-of-tree code to land in
the tree!

Dave

> johannes
>