| Message ID | 20241004094101.113349-1-sakari.ailus@linux.intel.com |
|---|---|
| Headers | show |
| Series | treewide: Switch to __pm_runtime_put_autosuspend() | expand |
Am Fri, 4 Oct 2024 12:41:23 +0300 schrieb Sakari Ailus <sakari.ailus@linux.intel.com>: > pm_runtime_put_autosuspend() will soon be changed to include a call to > pm_runtime_mark_last_busy(). This patch switches the current users to > __pm_runtime_put_autosuspend() which will continue to have the > functionality of old pm_runtime_put_autosuspend(). > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/input/keyboard/omap4-keypad.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/keyboard/omap4-keypad.c > b/drivers/input/keyboard/omap4-keypad.c index > 040b340995d8..cc8d77601fc7 100644 --- > a/drivers/input/keyboard/omap4-keypad.c +++ > b/drivers/input/keyboard/omap4-keypad.c @@ -196,7 +196,7 @@ static > irqreturn_t omap4_keypad_irq_thread_fn(int irq, void *dev_id) > kbd_read_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS)); > pm_runtime_mark_last_busy(dev); > - pm_runtime_put_autosuspend(dev); > + __pm_runtime_put_autosuspend(dev); > > return IRQ_HANDLED; > } > @@ -234,7 +234,7 @@ static int omap4_keypad_open(struct input_dev > *input) > out: > pm_runtime_mark_last_busy(dev); > - pm_runtime_put_autosuspend(dev); > + __pm_runtime_put_autosuspend(dev); > hmm, if pm_runtime_put_autosuspend() will include the call to pm_runtime_mark_last_busy(), then why is this change needed? After the change, the mark_last_busy could be removed. Regards, Andreas
Hi Andreas, On Fri, Oct 04, 2024 at 11:55:11AM +0200, Andreas Kemnade wrote: > Am Fri, 4 Oct 2024 12:41:23 +0300 > schrieb Sakari Ailus <sakari.ailus@linux.intel.com>: > > > pm_runtime_put_autosuspend() will soon be changed to include a call to > > pm_runtime_mark_last_busy(). This patch switches the current users to > > __pm_runtime_put_autosuspend() which will continue to have the > > functionality of old pm_runtime_put_autosuspend(). > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > --- > > drivers/input/keyboard/omap4-keypad.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/input/keyboard/omap4-keypad.c > > b/drivers/input/keyboard/omap4-keypad.c index > > 040b340995d8..cc8d77601fc7 100644 --- > > a/drivers/input/keyboard/omap4-keypad.c +++ > > b/drivers/input/keyboard/omap4-keypad.c @@ -196,7 +196,7 @@ static > > irqreturn_t omap4_keypad_irq_thread_fn(int irq, void *dev_id) > > kbd_read_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS)); > > pm_runtime_mark_last_busy(dev); > > - pm_runtime_put_autosuspend(dev); > > + __pm_runtime_put_autosuspend(dev); > > > > return IRQ_HANDLED; > > } > > @@ -234,7 +234,7 @@ static int omap4_keypad_open(struct input_dev > > *input) > > out: > > pm_runtime_mark_last_busy(dev); > > - pm_runtime_put_autosuspend(dev); > > + __pm_runtime_put_autosuspend(dev); > > > hmm, if pm_runtime_put_autosuspend() will include the call to > pm_runtime_mark_last_busy(), then why is this change needed? > After the change, the mark_last_busy could be removed. It could, in which case we'd be living with pm_runtime_mark_last_busy() called twice, for some time, and for some code, possibly even in a release kernel, depending on how well the patches "stick". It likely wouldn't be harmful. Still, to avoid making functional changes to more than 350 files I know little about, I've instead posted this set to prepare for pm_runtime_put_autosuspend() functionality change while keeping the functionality of the code exactly the same. Also added Ilpo who had a similar question.
Hi Ulf, On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote: > > > > > > > > Hello everyone, > > > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost > > > > always used together, apart from bugs which are likely common. Going > > > > forward, most new users should be using pm_runtime_put_autosuspend(). > > > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed, > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend() > > > > and pm_runtime_mark_last_busy(). > > > > > > That sounds like it could cause a lot of churns. > > > > > > Why not add a new helper function that does the > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy() > > > things? Then we can start moving users over to this new interface, > > > rather than having this intermediate step? > > > > I think the API would be nicer if we used the shortest and simplest > > function names for the most common use cases. Following > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that > > most common use case. That's why I like Sakari's approach of repurposing > > pm_runtime_put_autosuspend(), and introducing > > __pm_runtime_put_autosuspend() for the odd cases where > > pm_runtime_mark_last_busy() shouldn't be called. > > Okay, so the reason for this approach is because we couldn't find a > short and descriptive name that could be used in favor of > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe > you like it - or not. :-) I like the idea at least :-) > I don't know what options you guys discussed, but to me the entire > "autosuspend"-suffix isn't really that necessary in my opinion. There > are more ways than calling pm_runtime_put_autosuspend() that triggers > us to use the RPM_AUTO flag for rpm_suspend(). For example, just > calling pm_runtime_put() has the similar effect. To be honest, I'm lost there. pm_runtime_put() calls __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT | RPM_ASYNC | RPM_AUTO). > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called > during rpm_resume() too, for example. So why bother about having > "mark_last_busy" in the new name too. > > That said, my suggestion is simply "pm_runtime_put_suspend". Can we do even better, and make pm_runtime_put() to handle autosuspend automatically when autosuspend is enabled ? > If you don't like it, I will certainly not object to your current > approach, even if I think it leads to unnecessary churns. > > [...] > > Kind regards > Uffe
On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Ulf, > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote: > > > > > > > > > > Hello everyone, > > > > > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to > > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed > > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost > > > > > always used together, apart from bugs which are likely common. Going > > > > > forward, most new users should be using pm_runtime_put_autosuspend(). > > > > > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed, > > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend() > > > > > and pm_runtime_mark_last_busy(). > > > > > > > > That sounds like it could cause a lot of churns. > > > > > > > > Why not add a new helper function that does the > > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy() > > > > things? Then we can start moving users over to this new interface, > > > > rather than having this intermediate step? > > > > > > I think the API would be nicer if we used the shortest and simplest > > > function names for the most common use cases. Following > > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that > > > most common use case. That's why I like Sakari's approach of repurposing > > > pm_runtime_put_autosuspend(), and introducing > > > __pm_runtime_put_autosuspend() for the odd cases where > > > pm_runtime_mark_last_busy() shouldn't be called. > > > > Okay, so the reason for this approach is because we couldn't find a > > short and descriptive name that could be used in favor of > > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe > > you like it - or not. :-) > > I like the idea at least :-) > > > I don't know what options you guys discussed, but to me the entire > > "autosuspend"-suffix isn't really that necessary in my opinion. There > > are more ways than calling pm_runtime_put_autosuspend() that triggers > > us to use the RPM_AUTO flag for rpm_suspend(). For example, just > > calling pm_runtime_put() has the similar effect. > > To be honest, I'm lost there. pm_runtime_put() calls > __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while > pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT | > RPM_ASYNC | RPM_AUTO). __pm_runtime_idle() ends up calling rpm_idle(), which may call rpm_suspend() - if it succeeds to idle the device. In that case, it tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar to what is happening when calling pm_runtime_put_autosuspend(). > > > > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called > > during rpm_resume() too, for example. So why bother about having > > "mark_last_busy" in the new name too. > > > > That said, my suggestion is simply "pm_runtime_put_suspend". > > Can we do even better, and make pm_runtime_put() to handle autosuspend > automatically when autosuspend is enabled ? As stated above, this is already the case. > > > If you don't like it, I will certainly not object to your current > > approach, even if I think it leads to unnecessary churns. > > > > [...] > > > > Kind regards > > Uffe > > -- > Regards, > > Laurent Pinchart Kind regards Uffe
On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > > > Hi Ulf, > > > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote: > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to > > > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed > > > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost > > > > > > always used together, apart from bugs which are likely common. Going > > > > > > forward, most new users should be using pm_runtime_put_autosuspend(). > > > > > > > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed, > > > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend() > > > > > > and pm_runtime_mark_last_busy(). > > > > > > > > > > That sounds like it could cause a lot of churns. > > > > > > > > > > Why not add a new helper function that does the > > > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy() > > > > > things? Then we can start moving users over to this new interface, > > > > > rather than having this intermediate step? > > > > > > > > I think the API would be nicer if we used the shortest and simplest > > > > function names for the most common use cases. Following > > > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that > > > > most common use case. That's why I like Sakari's approach of repurposing > > > > pm_runtime_put_autosuspend(), and introducing > > > > __pm_runtime_put_autosuspend() for the odd cases where > > > > pm_runtime_mark_last_busy() shouldn't be called. > > > > > > Okay, so the reason for this approach is because we couldn't find a > > > short and descriptive name that could be used in favor of > > > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe > > > you like it - or not. :-) > > > > I like the idea at least :-) > > > > > I don't know what options you guys discussed, but to me the entire > > > "autosuspend"-suffix isn't really that necessary in my opinion. There > > > are more ways than calling pm_runtime_put_autosuspend() that triggers > > > us to use the RPM_AUTO flag for rpm_suspend(). For example, just > > > calling pm_runtime_put() has the similar effect. > > > > To be honest, I'm lost there. pm_runtime_put() calls > > __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while > > pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT | > > RPM_ASYNC | RPM_AUTO). > > __pm_runtime_idle() ends up calling rpm_idle(), which may call > rpm_suspend() - if it succeeds to idle the device. In that case, it > tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar > to what is happening when calling pm_runtime_put_autosuspend(). Right. For almost everybody, except for a small bunch of drivers that actually have a .runtime_idle() callback, pm_runtime_put() is literally equivalent to pm_runtime_put_autosuspend(). So really the question is why anyone who doesn't provide a .runtime_idle() callback bothers with using this special pm_runtime_put_autosuspend() thing, which really means "do a runtime_put(), but skip my .runtime_idle() callback". > > > > > > > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called > > > during rpm_resume() too, for example. So why bother about having > > > "mark_last_busy" in the new name too. > > > > > > That said, my suggestion is simply "pm_runtime_put_suspend". > > > > Can we do even better, and make pm_runtime_put() to handle autosuspend > > automatically when autosuspend is enabled ? > > As stated above, this is already the case. What really is needed appears to be a combination of pm_runtime_mark_last_busy() with pm_runtime_put(). Granted, pm_runtime_put() could do the pm_runtime_mark_last_busy() thing automatically if autosuspend is enabled and the only consequence of it might be delaying a suspend of the device until its autosuspend timer expires, which should not be a problem in the vast majority of cases.
Hello, On Mon, Oct 07, 2024 at 09:49:24PM +0300, Laurent Pinchart wrote: > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > > > > > Hello everyone, > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed > > > to include a call to pm_runtime_mark_last_busy(). The two are almost > > > always used together, apart from bugs which are likely common. Going > > > forward, most new users should be using pm_runtime_put_autosuspend(). > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed, > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend() > > > and pm_runtime_mark_last_busy(). > > > > That sounds like it could cause a lot of churns. > > > > Why not add a new helper function that does the > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy() > > things? Then we can start moving users over to this new interface, > > rather than having this intermediate step? > > I think the API would be nicer if we used the shortest and simplest > function names for the most common use cases. Following > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that > most common use case. That's why I like Sakari's approach of repurposing > pm_runtime_put_autosuspend(), and introducing > __pm_runtime_put_autosuspend() for the odd cases where > pm_runtime_mark_last_busy() shouldn't be called. That's ok for me. However this patch series isn't the optimal path to there because most drivers (i.e. those that already today do pm_runtime_mark_last_busy() in combination with pm_runtime_put_autosuspend()) have to be patched twice. The saner route is: Only convert the drivers with a sole pm_runtime_put_autosuspend() (i.e. without pm_runtime_mark_last_busy()) to __pm_runtime_put_autosuspend(). Then add the mark_last_busy() bits to pm_runtime_put_autosuspend() and then drop the explicit calls to pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend(). (Note this doesn't take into account Rafael's position that pm_runtime_put() might be the saner option. My argument applies for that conversion analogously.) Best regards Uwe
Hello everyone, This set will switch the users of pm_runtime_put_autosuspend() to __pm_runtime_put_autosuspend() while the former will soon be re-purposed to include a call to pm_runtime_mark_last_busy(). The two are almost always used together, apart from bugs which are likely common. Going forward, most new users should be using pm_runtime_put_autosuspend(). Once this conversion is done and pm_runtime_put_autosuspend() re-purposed, I'll post another set to merge the calls to __pm_runtime_put_autosuspend() and pm_runtime_mark_last_busy(). The diff in these patches have been generated using the following Coccinelle script (besides a manual change in drivers/iio/magnetometer/af8133j.c): ----------8<------------------- @@ expression E1; @@ - pm_runtime_put_autosuspend(E1) + __pm_runtime_put_autosuspend(E1) ----------8<------------------- These patches are on top of today's linux-next (i.e. next-20241004). Sakari Ailus (51): accel/ivpu: Switch to __pm_runtime_put_autosuspend() bluetooth: Switch to __pm_runtime_put_autosuspend() bus: sunxi-rsb: Switch to __pm_runtime_put_autosuspend() hwrng: Switch to __pm_runtime_put_autosuspend() clk: Switch to __pm_runtime_put_autosuspend() crypto: Switch to __pm_runtime_put_autosuspend() dmaengine: Switch to __pm_runtime_put_autosuspend() gpio: Switch to __pm_runtime_put_autosuspend() drm/amd: Switch to __pm_runtime_put_autosuspend() drm/nouveau: Switch to __pm_runtime_put_autosuspend() drm/radeon: Switch to __pm_runtime_put_autosuspend() drm/panfrost: Switch to __pm_runtime_put_autosuspend() drivers: drm: Switch to __pm_runtime_put_autosuspend() HSI: omap_ssi_port: Switch to __pm_runtime_put_autosuspend() stm class: Switch to __pm_runtime_put_autosuspend() i2c: Switch to __pm_runtime_put_autosuspend() i3c: master: svc: Switch to __pm_runtime_put_autosuspend() i3c: dw: Switch to __pm_runtime_put_autosuspend() iio: Switch to __pm_runtime_put_autosuspend() Input: omap4-keypad: Switch to __pm_runtime_put_autosuspend() Input: cs40l50: Switch to __pm_runtime_put_autosuspend() iommu/arm-smmu: Switch to __pm_runtime_put_autosuspend() irqchip/imx-irqsteer: Switch to __pm_runtime_put_autosuspend() mailbox: mtk-cmdq-mailbox: Switch to __pm_runtime_put_autosuspend() media: Switch to __pm_runtime_put_autosuspend() mfd: Switch to __pm_runtime_put_autosuspend() mei: Switch to __pm_runtime_put_autosuspend() mmc: Switch to __pm_runtime_put_autosuspend() mtd: rawnand: gpmi: Switch to __pm_runtime_put_autosuspend() net: Switch to __pm_runtime_put_autosuspend() nfc: trf7970a: Switch to __pm_runtime_put_autosuspend() PCI/portdrv: Switch to __pm_runtime_put_autosuspend() phy: motorola: phy-mapphone-mdm6600: Switch to __pm_runtime_put_autosuspend() phy: ti: phy-twl4030-usb: Switch to __pm_runtime_put_autosuspend() power: Switch to __pm_runtime_put_autosuspend() pwm: img: Switch to __pm_runtime_put_autosuspend() regulator: stm32-vrefbuf: Switch to __pm_runtime_put_autosuspend() remoteproc: omap: Switch to __pm_runtime_put_autosuspend() slimbus: Switch to __pm_runtime_put_autosuspend() soundwire: Switch to __pm_runtime_put_autosuspend() spi: Switch to __pm_runtime_put_autosuspend() staging: Switch to __pm_runtime_put_autosuspend() thunderbolt: Switch to __pm_runtime_put_autosuspend() serial: Switch to __pm_runtime_put_autosuspend() usb: Switch to __pm_runtime_put_autosuspend() w1: omap-hdq: Switch to __pm_runtime_put_autosuspend() staging: greybus: Switch to __pm_runtime_put_autosuspend() ALSA: hda: Switch to __pm_runtime_put_autosuspend() ASoC: Switch to __pm_runtime_put_autosuspend() ALSA: intel_hdmi: Switch to __pm_runtime_put_autosuspend() soc: apple: mailbox: Switch to __pm_runtime_put_autosuspend() drivers/accel/ivpu/ivpu_drv.c | 2 +- drivers/accel/ivpu/ivpu_pm.c | 8 +- drivers/bluetooth/btmtksdio.c | 2 +- drivers/bluetooth/hci_bcm.c | 6 +- drivers/bluetooth/hci_h5.c | 4 +- drivers/bluetooth/hci_intel.c | 6 +- drivers/bus/sunxi-rsb.c | 4 +- drivers/char/hw_random/cctrng.c | 2 +- drivers/char/hw_random/omap3-rom-rng.c | 2 +- drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +- drivers/clk/imx/clk-scu.c | 2 +- drivers/clk/qcom/lpassaudiocc-sc7280.c | 4 +- drivers/clk/qcom/lpasscorecc-sc7180.c | 4 +- drivers/crypto/ccree/cc_pm.c | 2 +- drivers/crypto/hisilicon/qm.c | 2 +- drivers/crypto/omap-aes-gcm.c | 2 +- drivers/crypto/omap-aes.c | 2 +- drivers/crypto/omap-des.c | 2 +- drivers/crypto/omap-sham.c | 2 +- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +- .../crypto/rockchip/rk3288_crypto_skcipher.c | 2 +- drivers/crypto/stm32/stm32-crc32.c | 4 +- drivers/crypto/stm32/stm32-cryp.c | 2 +- drivers/crypto/stm32/stm32-hash.c | 2 +- drivers/dma/at_xdmac.c | 24 +-- drivers/dma/pl330.c | 14 +- drivers/dma/qcom/bam_dma.c | 10 +- drivers/dma/qcom/hidma.c | 18 +- drivers/dma/qcom/hidma_dbg.c | 2 +- drivers/dma/qcom/hidma_mgmt.c | 4 +- drivers/dma/ste_dma40.c | 16 +- drivers/dma/ti/cppi41.c | 10 +- drivers/dma/xilinx/zynqmp_dma.c | 2 +- drivers/gpio/gpio-arizona.c | 10 +- drivers/gpio/gpio-mxc.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 120 ++++++------ drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- .../gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 178 +++++++++--------- .../drm/bridge/analogix/analogix_dp_core.c | 2 +- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +- drivers/gpu/drm/bridge/parade-ps8640.c | 4 +- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 4 +- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 4 +- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 +- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +- drivers/gpu/drm/imx/dcss/dcss-crtc.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/msm_gpu.c | 2 +- drivers/gpu/drm/msm/msm_iommu.c | 4 +- drivers/gpu/drm/msm/msm_submitqueue.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +- drivers/gpu/drm/nouveau/nouveau_display.c | 4 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 10 +- drivers/gpu/drm/panel/panel-edp.c | 8 +- .../gpu/drm/panel/panel-samsung-atna33xc20.c | 6 +- drivers/gpu/drm/panel/panel-simple.c | 6 +- drivers/gpu/drm/panfrost/panfrost_job.c | 4 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 +- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 4 +- drivers/gpu/drm/panthor/panthor_device.c | 2 +- drivers/gpu/drm/panthor/panthor_sched.c | 6 +- drivers/gpu/drm/radeon/radeon_acpi.c | 2 +- drivers/gpu/drm/radeon/radeon_connectors.c | 20 +- drivers/gpu/drm/radeon/radeon_display.c | 6 +- drivers/gpu/drm/radeon/radeon_drv.c | 4 +- drivers/gpu/drm/radeon/radeon_fbdev.c | 4 +- drivers/gpu/drm/radeon/radeon_kms.c | 10 +- drivers/gpu/drm/tegra/submit.c | 2 +- drivers/gpu/drm/tidss/tidss_drv.c | 2 +- drivers/gpu/drm/vc4/vc4_v3d.c | 2 +- drivers/hsi/controllers/omap_ssi_port.c | 42 ++--- drivers/hwtracing/stm/core.c | 8 +- drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +- drivers/i2c/busses/i2c-amd-mp2.h | 2 +- drivers/i2c/busses/i2c-at91-master.c | 2 +- drivers/i2c/busses/i2c-cadence.c | 2 +- drivers/i2c/busses/i2c-davinci.c | 4 +- drivers/i2c/busses/i2c-designware-master.c | 2 +- drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +- drivers/i2c/busses/i2c-hix5hd2.c | 2 +- drivers/i2c/busses/i2c-i801.c | 4 +- drivers/i2c/busses/i2c-img-scb.c | 6 +- drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +- drivers/i2c/busses/i2c-imx.c | 4 +- drivers/i2c/busses/i2c-mv64xxx.c | 2 +- drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +- drivers/i2c/busses/i2c-omap.c | 6 +- drivers/i2c/busses/i2c-qcom-cci.c | 2 +- drivers/i2c/busses/i2c-qcom-geni.c | 2 +- drivers/i2c/busses/i2c-qup.c | 4 +- drivers/i2c/busses/i2c-riic.c | 4 +- drivers/i2c/busses/i2c-rzv2m.c | 2 +- drivers/i2c/busses/i2c-sprd.c | 4 +- drivers/i2c/busses/i2c-stm32f7.c | 10 +- drivers/i2c/busses/i2c-xiic.c | 2 +- drivers/i3c/master/dw-i3c-master.c | 16 +- drivers/i3c/master/svc-i3c-master.c | 16 +- drivers/iio/accel/bmc150-accel-core.c | 2 +- drivers/iio/accel/bmi088-accel-core.c | 6 +- drivers/iio/accel/fxls8962af-core.c | 2 +- drivers/iio/accel/kxcjk-1013.c | 2 +- drivers/iio/accel/kxsd9.c | 6 +- drivers/iio/accel/mma8452.c | 2 +- drivers/iio/accel/mma9551_core.c | 2 +- drivers/iio/accel/msa311.c | 12 +- drivers/iio/adc/ab8500-gpadc.c | 2 +- drivers/iio/adc/at91-sama5d2_adc.c | 20 +- drivers/iio/adc/rcar-gyroadc.c | 2 +- drivers/iio/adc/stm32-adc-core.c | 2 +- drivers/iio/adc/stm32-adc.c | 12 +- drivers/iio/adc/sun4i-gpadc-iio.c | 4 +- drivers/iio/adc/ti-ads1015.c | 2 +- drivers/iio/adc/ti-ads1100.c | 2 +- drivers/iio/adc/ti-ads1119.c | 4 +- drivers/iio/chemical/atlas-sensor.c | 4 +- .../common/hid-sensors/hid-sensor-trigger.c | 2 +- drivers/iio/dac/stm32-dac.c | 6 +- drivers/iio/gyro/bmg160_core.c | 2 +- drivers/iio/gyro/fxas21002c_core.c | 2 +- drivers/iio/gyro/mpu3050-core.c | 6 +- drivers/iio/gyro/mpu3050-i2c.c | 2 +- .../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +- .../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +- .../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +- .../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +- drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 +- drivers/iio/imu/kmx61.c | 2 +- drivers/iio/light/apds9306.c | 6 +- drivers/iio/light/apds9960.c | 4 +- drivers/iio/light/bh1780.c | 2 +- drivers/iio/light/gp2ap002.c | 4 +- drivers/iio/light/isl29028.c | 2 +- drivers/iio/light/ltrf216a.c | 2 +- drivers/iio/light/pa12203001.c | 2 +- drivers/iio/light/rpr0521.c | 2 +- drivers/iio/light/tsl2583.c | 2 +- drivers/iio/light/tsl2591.c | 4 +- drivers/iio/light/us5182d.c | 2 +- drivers/iio/light/vcnl4000.c | 2 +- drivers/iio/light/vcnl4035.c | 2 +- drivers/iio/magnetometer/af8133j.c | 4 +- drivers/iio/magnetometer/ak8974.c | 4 +- drivers/iio/magnetometer/ak8975.c | 2 +- drivers/iio/magnetometer/bmc150_magn.c | 2 +- drivers/iio/magnetometer/tmag5273.c | 4 +- drivers/iio/magnetometer/yamaha-yas530.c | 4 +- drivers/iio/pressure/bmp280-core.c | 10 +- drivers/iio/pressure/icp10100.c | 2 +- drivers/iio/pressure/mpl115.c | 4 +- drivers/iio/pressure/zpa2326.c | 4 +- .../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +- drivers/iio/proximity/srf04.c | 2 +- drivers/iio/temperature/mlx90614.c | 4 +- drivers/iio/temperature/mlx90632.c | 4 +- drivers/iio/temperature/mlx90635.c | 4 +- drivers/input/keyboard/omap4-keypad.c | 8 +- drivers/input/misc/cs40l50-vibra.c | 8 +- drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- drivers/irqchip/irq-imx-irqsteer.c | 2 +- drivers/mailbox/mtk-cmdq-mailbox.c | 10 +- drivers/media/i2c/alvium-csi2.c | 2 +- drivers/media/i2c/ccs/ccs-core.c | 10 +- drivers/media/i2c/dw9719.c | 2 +- drivers/media/i2c/gc0308.c | 6 +- drivers/media/i2c/gc2145.c | 8 +- drivers/media/i2c/imx283.c | 6 +- drivers/media/i2c/imx290.c | 6 +- drivers/media/i2c/imx296.c | 4 +- drivers/media/i2c/imx415.c | 4 +- drivers/media/i2c/mt9m114.c | 12 +- drivers/media/i2c/ov2680.c | 2 +- drivers/media/i2c/ov4689.c | 6 +- drivers/media/i2c/ov5640.c | 8 +- drivers/media/i2c/ov5645.c | 6 +- drivers/media/i2c/ov5693.c | 2 +- drivers/media/i2c/ov64a40.c | 8 +- drivers/media/i2c/ov7251.c | 2 +- drivers/media/i2c/ov8858.c | 4 +- drivers/media/i2c/thp7312.c | 8 +- drivers/media/i2c/video-i2c.c | 8 +- .../media/platform/nvidia/tegra-vde/h264.c | 4 +- drivers/media/platform/qcom/venus/vdec.c | 4 +- drivers/media/platform/qcom/venus/venc.c | 4 +- .../platform/raspberrypi/pisp_be/pisp_be.c | 4 +- .../media/platform/st/sti/delta/delta-v4l2.c | 4 +- drivers/media/platform/st/sti/hva/hva-hw.c | 8 +- .../media/platform/verisilicon/hantro_drv.c | 2 +- drivers/media/rc/gpio-ir-recv.c | 2 +- drivers/mfd/arizona-irq.c | 2 +- drivers/mfd/cs40l50-core.c | 2 +- drivers/mfd/cs42l43.c | 2 +- drivers/misc/mei/client.c | 14 +- drivers/mmc/core/core.c | 4 +- drivers/mmc/host/atmel-mci.c | 4 +- drivers/mmc/host/dw_mmc-rockchip.c | 2 +- drivers/mmc/host/dw_mmc.c | 2 +- drivers/mmc/host/mmci.c | 2 +- drivers/mmc/host/omap_hsmmc.c | 6 +- drivers/mmc/host/sdhci-msm.c | 2 +- drivers/mmc/host/sdhci-of-at91.c | 2 +- drivers/mmc/host/sdhci-omap.c | 4 +- drivers/mmc/host/sdhci-pci-core.c | 2 +- drivers/mmc/host/sdhci-pxav3.c | 6 +- drivers/mmc/host/sdhci-sprd.c | 2 +- drivers/mmc/host/sdhci-xenon.c | 2 +- drivers/mmc/host/sdhci_am654.c | 2 +- drivers/mmc/host/tmio_mmc_core.c | 2 +- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 10 +- drivers/net/ethernet/cadence/macb_main.c | 10 +- drivers/net/ethernet/freescale/fec_main.c | 16 +- drivers/net/ethernet/renesas/ravb_main.c | 8 +- drivers/net/ethernet/ti/davinci_mdio.c | 14 +- drivers/net/ipa/ipa_interrupt.c | 2 +- drivers/net/ipa/ipa_main.c | 2 +- drivers/net/ipa/ipa_modem.c | 8 +- drivers/net/ipa/ipa_smp2p.c | 4 +- drivers/net/ipa/ipa_uc.c | 4 +- drivers/net/wireless/ath/wil6210/pm.c | 2 +- drivers/net/wireless/ti/wl18xx/debugfs.c | 6 +- drivers/net/wireless/ti/wlcore/cmd.c | 2 +- drivers/net/wireless/ti/wlcore/debugfs.c | 22 +-- drivers/net/wireless/ti/wlcore/main.c | 72 +++---- drivers/net/wireless/ti/wlcore/scan.c | 2 +- drivers/net/wireless/ti/wlcore/sysfs.c | 2 +- drivers/net/wireless/ti/wlcore/testmode.c | 4 +- drivers/net/wireless/ti/wlcore/tx.c | 2 +- drivers/net/wireless/ti/wlcore/vendor_cmd.c | 6 +- drivers/net/wwan/qcom_bam_dmux.c | 4 +- drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 6 +- drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 6 +- drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 4 +- drivers/nfc/trf7970a.c | 2 +- drivers/pci/pcie/portdrv.c | 2 +- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +- drivers/phy/ti/phy-twl4030-usb.c | 8 +- drivers/power/supply/bq24190_charger.c | 28 +-- drivers/power/supply/twl4030_charger.c | 2 +- drivers/pwm/pwm-img.c | 4 +- drivers/regulator/stm32-vrefbuf.c | 12 +- drivers/remoteproc/omap_remoteproc.c | 6 +- drivers/slimbus/core.c | 2 +- drivers/slimbus/messaging.c | 4 +- drivers/soc/apple/mailbox.c | 2 +- drivers/soundwire/bus.c | 2 +- drivers/soundwire/cadence_master.c | 2 +- drivers/soundwire/qcom.c | 6 +- drivers/spi/atmel-quadspi.c | 10 +- drivers/spi/spi-cadence-quadspi.c | 4 +- drivers/spi/spi-cadence.c | 2 +- drivers/spi/spi-dw-pci.c | 2 +- drivers/spi/spi-fsl-espi.c | 4 +- drivers/spi/spi-fsl-lpspi.c | 4 +- drivers/spi/spi-imx.c | 6 +- drivers/spi/spi-mtk-nor.c | 2 +- drivers/spi/spi-omap2-mcspi.c | 6 +- drivers/spi/spi-pxa2xx-pci.c | 2 +- drivers/spi/spi-s3c64xx.c | 6 +- drivers/spi/spi-sprd.c | 2 +- drivers/spi/spi-stm32-qspi.c | 14 +- drivers/spi/spi-stm32.c | 4 +- drivers/spi/spi-ti-qspi.c | 4 +- drivers/spi/spi-zynqmp-gqspi.c | 2 +- drivers/spi/spi.c | 6 +- drivers/staging/greybus/gbphy.h | 2 +- drivers/staging/media/rkvdec/rkvdec.c | 2 +- drivers/thunderbolt/debugfs.c | 22 +-- drivers/thunderbolt/domain.c | 4 +- drivers/thunderbolt/icm.c | 14 +- drivers/thunderbolt/nhi.c | 2 +- drivers/thunderbolt/retimer.c | 4 +- drivers/thunderbolt/switch.c | 6 +- drivers/thunderbolt/tb.c | 18 +- drivers/thunderbolt/usb4_port.c | 4 +- drivers/tty/serial/8250/8250_omap.c | 18 +- drivers/tty/serial/8250/8250_port.c | 4 +- drivers/tty/serial/fsl_lpuart.c | 2 +- drivers/tty/serial/serial_core.c | 2 +- drivers/tty/serial/uartlite.c | 4 +- drivers/tty/serial/xilinx_uartps.c | 2 +- drivers/usb/cdns3/cdns3-gadget.c | 2 +- drivers/usb/cdns3/cdnsp-gadget.c | 2 +- drivers/usb/chipidea/core.c | 2 +- drivers/usb/chipidea/otg_fsm.c | 2 +- drivers/usb/dwc3/core.c | 2 +- drivers/usb/dwc3/dwc3-am62.c | 2 +- drivers/usb/dwc3/dwc3-imx8mp.c | 2 +- drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 2 +- drivers/usb/host/xhci-mtk.c | 2 +- drivers/usb/misc/apple-mfi-fastcharge.c | 2 +- drivers/usb/mtu3/mtu3_plat.c | 2 +- drivers/usb/musb/musb_core.c | 10 +- drivers/usb/musb/musb_debugfs.c | 10 +- drivers/usb/musb/musb_dsps.c | 2 +- drivers/usb/musb/musb_gadget.c | 8 +- drivers/usb/musb/omap2430.c | 2 +- drivers/w1/masters/omap_hdq.c | 10 +- include/linux/greybus/bundle.h | 2 +- sound/hda/hdac_device.c | 2 +- sound/pci/hda/cs35l41_hda.c | 8 +- sound/pci/hda/cs35l56_hda.c | 2 +- sound/pci/hda/hda_intel.c | 2 +- sound/pci/hda/tas2781_hda_i2c.c | 6 +- sound/soc/atmel/mchp-spdifrx.c | 12 +- sound/soc/codecs/arizona-jack.c | 12 +- sound/soc/codecs/arizona.c | 2 +- sound/soc/codecs/cs35l41.c | 4 +- sound/soc/codecs/cs35l45.c | 2 +- sound/soc/codecs/cs35l56-sdw.c | 4 +- sound/soc/codecs/cs35l56-shared.c | 2 +- sound/soc/codecs/cs35l56.c | 2 +- sound/soc/codecs/cs42l42-sdw.c | 2 +- sound/soc/codecs/cs42l42.c | 4 +- sound/soc/codecs/cs42l43-jack.c | 10 +- sound/soc/codecs/cs42l43.c | 4 +- sound/soc/codecs/hda.c | 6 +- sound/soc/codecs/madera.c | 6 +- sound/soc/codecs/max98363.c | 2 +- sound/soc/codecs/max98373-sdw.c | 2 +- sound/soc/codecs/rt1017-sdca-sdw.c | 2 +- sound/soc/codecs/rt1308-sdw.c | 2 +- sound/soc/codecs/rt1316-sdw.c | 2 +- sound/soc/codecs/rt1318-sdw.c | 2 +- sound/soc/codecs/rt1320-sdw.c | 2 +- sound/soc/codecs/rt5682-sdw.c | 2 +- sound/soc/codecs/rt700.c | 4 +- sound/soc/codecs/rt711-sdca.c | 4 +- sound/soc/codecs/rt711.c | 4 +- sound/soc/codecs/rt712-sdca-dmic.c | 2 +- sound/soc/codecs/rt712-sdca.c | 4 +- sound/soc/codecs/rt715-sdca.c | 2 +- sound/soc/codecs/rt715.c | 2 +- sound/soc/codecs/rt722-sdca.c | 4 +- sound/soc/codecs/wcd-mbhc-v2.c | 4 +- sound/soc/codecs/wsa881x.c | 2 +- sound/soc/codecs/wsa884x.c | 2 +- sound/soc/intel/atom/sst/sst_pvt.c | 2 +- sound/soc/intel/avs/core.c | 2 +- sound/soc/intel/avs/debugfs.c | 4 +- sound/soc/intel/avs/pcm.c | 2 +- sound/soc/intel/catpt/pcm.c | 12 +- sound/soc/intel/catpt/sysfs.c | 2 +- sound/soc/soc-component.c | 2 +- sound/soc/sof/control.c | 2 +- sound/soc/sof/debug.c | 2 +- sound/soc/sof/ipc3-dtrace.c | 2 +- sound/soc/sof/ipc4-loader.c | 2 +- sound/soc/sof/pcm.c | 2 +- sound/soc/sof/sof-client-ipc-flood-test.c | 2 +- .../soc/sof/sof-client-ipc-kernel-injector.c | 2 +- sound/soc/sof/sof-client-ipc-msg-injector.c | 2 +- sound/soc/sof/sof-client-probes.c | 6 +- sound/x86/intel_hdmi_audio.c | 6 +- 373 files changed, 1076 insertions(+), 1076 deletions(-)