| Message ID | 20241004-maint-net-hdrs-v1-0-41fd555aacc5@kernel.org |
|---|---|
| Headers | show |
| Series | MAINTAINERS: Networking file coverage updates | expand |
On Fri, 2024-10-04 at 11:03 +0100, Simon Horman wrote: > We already exclude wireless drivers from the netdev@ traffic, to > delegate it to linux-wireless@, and avoid overwhelming netdev@. > > Many of the following wireless-related sections MAINTAINERS > are already not included in the NETWORKING [GENERAL] section. > For consistency, exclude those that are. > > * 802.11 (including CFG80211/NL80211) > * MAC80211 > * RFKILL > > Signed-off-by: Simon Horman <horms@kernel.org> Makes sense to me! Acked-by: Johannes Berg <johannes@sipsolutions.net> johannes
Simon Horman <horms@kernel.org> writes: > We already exclude wireless drivers from the netdev@ traffic, to > delegate it to linux-wireless@, and avoid overwhelming netdev@. > > Many of the following wireless-related sections MAINTAINERS > are already not included in the NETWORKING [GENERAL] section. > For consistency, exclude those that are. > > * 802.11 (including CFG80211/NL80211) > * MAC80211 > * RFKILL > > Signed-off-by: Simon Horman <horms@kernel.org> > --- > MAINTAINERS | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c27f3190737f..ea3ea2c0d3fa 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16197,8 +16197,19 @@ F: lib/random32.c > F: net/ > F: tools/net/ > F: tools/testing/selftests/net/ > +X: Documentation/networking/mac80211-injection.rst > +X: Documentation/networking/mac80211_hwsim/ > +X: Documentation/networking/regulatory.rst > +X: include/net/cfg80211.h > +X: include/net/ieee80211_radiotap.h > +X: include/net/iw_handler.h > +X: include/net/mac80211.h > +X: include/net/wext.h Should we add also lib80211.h?
On Fri, 04 Oct 2024 11:03:20 +0100 Simon Horman wrote: > 2. Excluding some files relating to Wireless from NETWORKING [GENERAL], > making their handling consistent with other files related to > Wireless. LGTM, FWIW, on the wireless side I generally add stuff which seems like it causing people to mis-post. But no objections to listing more files either way.
On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote: > Simon Horman <horms@kernel.org> writes: > > > We already exclude wireless drivers from the netdev@ traffic, to > > delegate it to linux-wireless@, and avoid overwhelming netdev@. > > > > Many of the following wireless-related sections MAINTAINERS > > are already not included in the NETWORKING [GENERAL] section. > > For consistency, exclude those that are. > > > > * 802.11 (including CFG80211/NL80211) > > * MAC80211 > > * RFKILL > > > > Signed-off-by: Simon Horman <horms@kernel.org> > > --- > > MAINTAINERS | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index c27f3190737f..ea3ea2c0d3fa 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -16197,8 +16197,19 @@ F: lib/random32.c > > F: net/ > > F: tools/net/ > > F: tools/testing/selftests/net/ > > +X: Documentation/networking/mac80211-injection.rst > > +X: Documentation/networking/mac80211_hwsim/ > > +X: Documentation/networking/regulatory.rst > > +X: include/net/cfg80211.h > > +X: include/net/ieee80211_radiotap.h > > +X: include/net/iw_handler.h > > +X: include/net/mac80211.h > > +X: include/net/wext.h > > Should we add also lib80211.h? Thanks, I missed that one. Perhaps it should have: * An F: entry in the MAC80211 * An X: entry in the NETWORKING [GENERAL] If so, perhaps I can just add that to a v2 of this patch. Let me know what you think.
On Mon, 2024-10-07 at 15:13 +0100, Simon Horman wrote: > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote: > > Simon Horman <horms@kernel.org> writes: > > > > > We already exclude wireless drivers from the netdev@ traffic, to > > > delegate it to linux-wireless@, and avoid overwhelming netdev@. > > > > > > Many of the following wireless-related sections MAINTAINERS > > > are already not included in the NETWORKING [GENERAL] section. > > > For consistency, exclude those that are. > > > > > > * 802.11 (including CFG80211/NL80211) > > > * MAC80211 > > > * RFKILL > > > > > > Signed-off-by: Simon Horman <horms@kernel.org> > > > --- > > > MAINTAINERS | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index c27f3190737f..ea3ea2c0d3fa 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -16197,8 +16197,19 @@ F: lib/random32.c > > > F: net/ > > > F: tools/net/ > > > F: tools/testing/selftests/net/ > > > +X: Documentation/networking/mac80211-injection.rst > > > +X: Documentation/networking/mac80211_hwsim/ > > > +X: Documentation/networking/regulatory.rst > > > +X: include/net/cfg80211.h > > > +X: include/net/ieee80211_radiotap.h > > > +X: include/net/iw_handler.h > > > +X: include/net/mac80211.h > > > +X: include/net/wext.h > > > > Should we add also lib80211.h? > > Thanks, I missed that one. Perhaps it should have: > > * An F: entry in the MAC80211 I suppose it should rather be in the 802.11 entry rather than the MAC80211 one. I don't like the code anyway, but it's there for now :) johannes
Simon Horman <horms@kernel.org> writes: > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote: > >> Simon Horman <horms@kernel.org> writes: >> >> > We already exclude wireless drivers from the netdev@ traffic, to >> > delegate it to linux-wireless@, and avoid overwhelming netdev@. >> > >> > Many of the following wireless-related sections MAINTAINERS >> > are already not included in the NETWORKING [GENERAL] section. >> > For consistency, exclude those that are. >> > >> > * 802.11 (including CFG80211/NL80211) >> > * MAC80211 >> > * RFKILL >> > >> > Signed-off-by: Simon Horman <horms@kernel.org> >> > --- >> > MAINTAINERS | 11 +++++++++++ >> > 1 file changed, 11 insertions(+) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index c27f3190737f..ea3ea2c0d3fa 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -16197,8 +16197,19 @@ F: lib/random32.c >> > F: net/ >> > F: tools/net/ >> > F: tools/testing/selftests/net/ >> > +X: Documentation/networking/mac80211-injection.rst >> > +X: Documentation/networking/mac80211_hwsim/ >> > +X: Documentation/networking/regulatory.rst >> > +X: include/net/cfg80211.h >> > +X: include/net/ieee80211_radiotap.h >> > +X: include/net/iw_handler.h >> > +X: include/net/mac80211.h >> > +X: include/net/wext.h >> >> Should we add also lib80211.h? > > Thanks, I missed that one. Perhaps it should have: > > * An F: entry in the MAC80211 > * An X: entry in the NETWORKING [GENERAL] > > If so, perhaps I can just add that to a v2 of this patch. > Let me know what you think. Like Johannes said, the cfg80211 entry is more approriate but otherwise sounds like a good plan, thanks!
On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote: > Simon Horman <horms@kernel.org> writes: > > > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote: > > > > > Simon Horman <horms@kernel.org> writes: > > > > > > > We already exclude wireless drivers from the netdev@ traffic, to > > > > delegate it to linux-wireless@, and avoid overwhelming netdev@. > > > > > > > > Many of the following wireless-related sections MAINTAINERS > > > > are already not included in the NETWORKING [GENERAL] section. > > > > For consistency, exclude those that are. > > > > > > > > * 802.11 (including CFG80211/NL80211) > > > > * MAC80211 > > > > * RFKILL > > > > > > > > Signed-off-by: Simon Horman <horms@kernel.org> > > > > --- > > > > MAINTAINERS | 11 +++++++++++ > > > > 1 file changed, 11 insertions(+) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index c27f3190737f..ea3ea2c0d3fa 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -16197,8 +16197,19 @@ F: lib/random32.c > > > > F: net/ > > > > F: tools/net/ > > > > F: tools/testing/selftests/net/ > > > > +X: Documentation/networking/mac80211-injection.rst > > > > +X: Documentation/networking/mac80211_hwsim/ > > > > +X: Documentation/networking/regulatory.rst > > > > +X: include/net/cfg80211.h > > > > +X: include/net/ieee80211_radiotap.h > > > > +X: include/net/iw_handler.h > > > > +X: include/net/mac80211.h > > > > +X: include/net/wext.h > > > > > > Should we add also lib80211.h? > > > > Thanks, I missed that one. Perhaps it should have: > > > > * An F: entry in the MAC80211 > > * An X: entry in the NETWORKING [GENERAL] > > > > If so, perhaps I can just add that to a v2 of this patch. > > Let me know what you think. > > Like Johannes said, the cfg80211 entry is more approriate but otherwise > sounds like a good plan, thanks! Actually scratch that, please just ignore it. I'm going to remove that header file entirely and move the functionality into libipw in the ipw2x00 drivers. johannes
Hi, The aim of this proposal is to make the handling of some files, related to Networking and Wireless, more consistently. It does so by: 1. Adding some more headers to the UDP section, making it consistent with the TCP section. 2. Excluding some files relating to Wireless from NETWORKING [GENERAL], making their handling consistent with other files related to Wireless. The aim of this is to make things more consistent. And for MAINTAINERS to better reflect the situation on the ground. I am more than happy to be told that the current state of affairs is fine. Or for other ideas to be discussed. --- Simon Horman (2): MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL] MAINTAINERS: Add headers and mailing list to UDP section MAINTAINERS | 15 +++++++++++++++ 1 file changed, 15 insertions(+) base-commit: 096c0fa42afa92b6ffa4e441c4c72a2f805c5a88