| Message ID | 20241002232804.3867-5-exxxxkc@getgoogleoff.me |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: dts: qcom-ipq5018-linksys-jamaica: Include dts from arm64 | expand |
On 10/4/24 7:44 PM, Linus Walleij wrote: > On Thu, Oct 3, 2024 at 1:29 AM Karl Chan <exxxxkc@getgoogleoff.me> wrote: > >> There are some ipq5018 based device's firmware only can able to boot >> arm32 but the pinctrl driver dont allow it to be compiled on >> arm32.Therefore this patch needed for those devices. >> >> Signed-off-by: Karl Chan <exxxxkc@getgoogleoff.me> > (...) >> - depends on ARM64 || COMPILE_TEST >> + depends on ARM || ARM64 || COMPILE_TEST > Can we get some more context for this? > > Is this another one of those cases where the SoC is actually a > 64bit core but vendors just choose to run it in 32bit mode because > that is what they want or what is the reason here? AFAIK > IPQ5018 is always Cortex-A53? > > I just want to know if this is something we should encourage > or leave out-of-tree. > > Yours, > Linus Walleij Yeah it is like those MSM8916 based device that only has 32bit firmware.(e.g. samsung e5). AFIK , other ipq5018 based linksys router has 64bit firmware but this one dont. Also this router seem to be identical to linksys ER5500 but with 32bit firmware and isp exclusive. (It is PCCW isp exclusive router (See https://support.linksys.com/kb/article/3723-en/) )
diff --git a/drivers/pinctrl/qcom/Kconfig.msm b/drivers/pinctrl/qcom/Kconfig.msm index 8fe459d082ed..65cec6c50994 100644 --- a/drivers/pinctrl/qcom/Kconfig.msm +++ b/drivers/pinctrl/qcom/Kconfig.msm @@ -24,7 +24,7 @@ config PINCTRL_IPQ4019 config PINCTRL_IPQ5018 tristate "Qualcomm Technologies, Inc. IPQ5018 pin controller driver" - depends on ARM64 || COMPILE_TEST + depends on ARM || ARM64 || COMPILE_TEST help This is the pinctrl, pinmux, pinconf and gpiolib driver for the Qualcomm Technologies Inc. TLMM block found on the
There are some ipq5018 based device's firmware only can able to boot arm32 but the pinctrl driver dont allow it to be compiled on arm32.Therefore this patch needed for those devices. Signed-off-by: Karl Chan <exxxxkc@getgoogleoff.me> --- drivers/pinctrl/qcom/Kconfig.msm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)