| Message ID | 20240925194921.18933-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1ee68f172482ab3d165468b989026fe67d6ea908 |
| Headers | show |
| Series | [1/2] HID: hid-goodix: drop unsupported and undocumented DT part | expand |
On Wed, 25 Sep 2024, Krzysztof Kozlowski wrote: > This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID > Touchscreen") because it duplicates existing binding leadings to errors: > > goodix,gt7986u.example.dtb: > touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed: > ['goodix,gt7986u'] is too short > 'goodix,gt7375p' was expected > > This was reported on mailing list on 6th of September, but no reaction > happened from contributor or maintainer to fix it. > > Therefore let's drop binding which breaks and duplicates existing one. > > Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I've applied both patches now and will expedite them to Linus. Thanks,
On 25/09/2024 23:07, Jiri Kosina wrote: > On Wed, 25 Sep 2024, Krzysztof Kozlowski wrote: > >> This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID >> Touchscreen") because it duplicates existing binding leadings to errors: >> >> goodix,gt7986u.example.dtb: >> touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed: >> ['goodix,gt7986u'] is too short >> 'goodix,gt7375p' was expected >> >> This was reported on mailing list on 6th of September, but no reaction >> happened from contributor or maintainer to fix it. >> >> Therefore let's drop binding which breaks and duplicates existing one. >> >> Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") >> Reported-by: Rob Herring <robh@kernel.org> >> Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/ >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I've applied both patches now and will expedite them to Linus. Thanks Jiri, Charles, If you ever receive a report about an issue in your patch, you should respond to it and address it. Regardless whether it is on the lists only or already merged. If you do not respond to issues reported for your commits, it might cause impression that you only care about getting your stuff into the kernel and whatever after does not matter. As maintainer I would not take more patches from you in such case, I bet other maintainers would be reluctant to take them too. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml deleted file mode 100644 index a7d42a5d6128..000000000000 --- a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml +++ /dev/null @@ -1,71 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: GOODIX GT7986U SPI HID Touchscreen - -maintainers: - - Charles Wang <charles.goodix@gmail.com> - -description: Supports the Goodix GT7986U touchscreen. - This touch controller reports data packaged according to the HID protocol, - but is incompatible with Microsoft's HID-over-SPI protocol. - -allOf: - - $ref: /schemas/spi/spi-peripheral-props.yaml# - -properties: - compatible: - enum: - - goodix,gt7986u - - reg: - maxItems: 1 - - interrupts: - maxItems: 1 - - reset-gpios: - maxItems: 1 - - goodix,hid-report-addr: - $ref: /schemas/types.yaml#/definitions/uint32 - description: - The register address for retrieving HID report data. - This address is related to the device firmware and may - change after a firmware update. - - spi-max-frequency: true - -additionalProperties: false - -required: - - compatible - - reg - - interrupts - - reset-gpios - - goodix,hid-report-addr - -examples: - - | - #include <dt-bindings/interrupt-controller/irq.h> - #include <dt-bindings/gpio/gpio.h> - - spi { - #address-cells = <1>; - #size-cells = <0>; - - touchscreen@0 { - compatible = "goodix,gt7986u"; - reg = <0>; - interrupt-parent = <&gpio>; - interrupts = <25 IRQ_TYPE_LEVEL_LOW>; - reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; - spi-max-frequency = <10000000>; - goodix,hid-report-addr = <0x22c8c>; - }; - }; - -...
This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") because it duplicates existing binding leadings to errors: goodix,gt7986u.example.dtb: touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed: ['goodix,gt7986u'] is too short 'goodix,gt7375p' was expected This was reported on mailing list on 6th of September, but no reaction happened from contributor or maintainer to fix it. Therefore let's drop binding which breaks and duplicates existing one. Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") Reported-by: Rob Herring <robh@kernel.org> Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- It is sad that original commit author ignored the report for two weeks. This should have never been sent to Linus as pull request. --- .../bindings/input/goodix,gt7986u.yaml | 71 ------------------- 1 file changed, 71 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml