| Message ID | 20240919-exynosdrm-decon-v1-6-8c3e3ccffad5@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | Samsung Exynos 7870 DECON driver support | expand |
On 19/09/2024 17:20, Kaustabh Chakraborty wrote: > Add the compatible string of Exynos7870 to the existing list. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> ... and the DTS is <please provide lore ink in changelog>? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2024-09-20 12:39, Krzysztof Kozlowski wrote: > On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >> Add the compatible string of Exynos7870 to the existing list. >> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > > ... and the DTS is <please provide lore ink in changelog>? Didn't quite understand. The patch adds the compatible string for Exynos7870 DECON in documentation. There's no DTS involved in here, right? > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof
On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>> Add the compatible string of Exynos7870 to the existing list. >>> >>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >> >> ... and the DTS is <please provide lore ink in changelog>? > > Didn't quite understand. The patch adds the compatible string > for Exynos7870 DECON in documentation. There's no DTS involved > in here, right? Provide lore link to the DTS submission. Best regards, Krzysztof
On 2024-09-25 19:25, Krzysztof Kozlowski wrote: > On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>>> Add the compatible string of Exynos7870 to the existing list. >>>> >>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>> >>> ... and the DTS is <please provide lore ink in changelog>? >> >> Didn't quite understand. The patch adds the compatible string >> for Exynos7870 DECON in documentation. There's no DTS involved >> in here, right? > > Provide lore link to the DTS submission. There aren't any DTS submissions *yet* which use the compatible. Is that an issue? > > Best regards, > Krzysztof
On 25/09/2024 21:36, Kaustabh Chakraborty wrote: > On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >>> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>>>> Add the compatible string of Exynos7870 to the existing list. >>>>> >>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>> >>>> ... and the DTS is <please provide lore ink in changelog>? >>> >>> Didn't quite understand. The patch adds the compatible string >>> for Exynos7870 DECON in documentation. There's no DTS involved >>> in here, right? >> >> Provide lore link to the DTS submission. > > There aren't any DTS submissions *yet* which use the compatible. > Is that an issue? > Yeah, users are supposed to be upstream. Not downstream. Best regards, Krzysztof
On 2024-09-25 19:56, Krzysztof Kozlowski wrote: > On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >>> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >>>> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>>>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>>>>> Add the compatible string of Exynos7870 to the existing list. >>>>>> >>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>>> >>>>> ... and the DTS is <please provide lore ink in changelog>? >>>> >>>> Didn't quite understand. The patch adds the compatible string >>>> for Exynos7870 DECON in documentation. There's no DTS involved >>>> in here, right? >>> >>> Provide lore link to the DTS submission. >> >> There aren't any DTS submissions *yet* which use the compatible. >> Is that an issue? >> > > Yeah, users are supposed to be upstream. Not downstream. I understand that. I had plans to submit it in the future. If that's how it's meant to be done, I'll have to revisit this submission at a later date then. > > Best regards, > Krzysztof
On 25/09/2024 22:05, Kaustabh Chakraborty wrote: > On 2024-09-25 19:56, Krzysztof Kozlowski wrote: >> On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >>> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >>>> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >>>>> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>>>>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>>>>>> Add the compatible string of Exynos7870 to the existing list. >>>>>>> >>>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>>>> >>>>>> ... and the DTS is <please provide lore ink in changelog>? >>>>> >>>>> Didn't quite understand. The patch adds the compatible string >>>>> for Exynos7870 DECON in documentation. There's no DTS involved >>>>> in here, right? >>>> >>>> Provide lore link to the DTS submission. >>> >>> There aren't any DTS submissions *yet* which use the compatible. >>> Is that an issue? >>> >> >> Yeah, users are supposed to be upstream. Not downstream. > > I understand that. I had plans to submit it in the future. > If that's how it's meant to be done, I'll have to revisit this > submission at a later date then. > Partial, asynchronous bringup of a device is fine, so if the basic support is there, I understand that drivers come in different pace. Although I don't understand why DTS for this piece of hardware would come in different pace, considering you cannot test it without DTS. You have there DTS, so it should be sent. But even without the DTS for DECON, the problem is earlier - lack of basic support for this device. There is nothing for this chip. This means it cannot be tested and is trickier to verify. That's not the usual upstreaming way we expect, especially that you did not provide rationale for such way. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml index 992c23ca7a4e..53916e4c95d8 100644 --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml @@ -19,7 +19,9 @@ description: | properties: compatible: - const: samsung,exynos7-decon + enum: + - samsung,exynos7-decon + - samsung,exynos7870-decon clocks: maxItems: 4
Add the compatible string of Exynos7870 to the existing list. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- .../devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)