mbox series

[for-9.2,0/2] accel/kvm: Fix two minor Coverity nits

Message ID 20240815131206.3231819-1-peter.maydell@linaro.org
Headers show
Series accel/kvm: Fix two minor Coverity nits | expand

Message

Peter Maydell Aug. 15, 2024, 1:12 p.m. UTC 
This patchset fixes a couple of minor Coverity nits:
 * a can't-happen integer overflow when assigning from a long to
   an int in kvm_init_vcpu()
 * some unreachable code in kvm_dirty_ring_reaper_thread()

Since there's no actual incorrect behaviour, these are 9.2
material.

thanks
-- PMM

Peter Maydell (2):
  kvm: Make 'mmap_size' be 'int' in kvm_init_vcpu(),
    do_kvm_destroy_vcpu()
  kvm: Remove unreachable code in kvm_dirty_ring_reaper_thread()

 accel/kvm/kvm-all.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Peter Maydell Sept. 6, 2024, 3:10 p.m. UTC | #1 
On Thu, 15 Aug 2024 at 14:12, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> This patchset fixes a couple of minor Coverity nits:
>  * a can't-happen integer overflow when assigning from a long to
>    an int in kvm_init_vcpu()
>  * some unreachable code in kvm_dirty_ring_reaper_thread()
>
> Since there's no actual incorrect behaviour, these are 9.2
> material.
>
> thanks
> -- PMM
>
> Peter Maydell (2):
>   kvm: Make 'mmap_size' be 'int' in kvm_init_vcpu(),
>     do_kvm_destroy_vcpu()
>   kvm: Remove unreachable code in kvm_dirty_ring_reaper_thread()

Ping for review on patch 2, please?

(I can take these through target-arm if you like.)

thanks
-- PMM
Peter Maydell Sept. 19, 2024, 12:14 p.m. UTC | #2 
On Fri, 6 Sept 2024 at 16:10, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 15 Aug 2024 at 14:12, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > This patchset fixes a couple of minor Coverity nits:
> >  * a can't-happen integer overflow when assigning from a long to
> >    an int in kvm_init_vcpu()
> >  * some unreachable code in kvm_dirty_ring_reaper_thread()
> >
> > Since there's no actual incorrect behaviour, these are 9.2
> > material.
> >
> > thanks
> > -- PMM
> >
> > Peter Maydell (2):
> >   kvm: Make 'mmap_size' be 'int' in kvm_init_vcpu(),
> >     do_kvm_destroy_vcpu()
> >   kvm: Remove unreachable code in kvm_dirty_ring_reaper_thread()
>
> Ping for review on patch 2, please?
>
> (I can take these through target-arm if you like.)

It's been two weeks, and patch 2 is pretty trivial, so I'm
going to take these through target-arm.next.

-- PMM