| Message ID | 20240913-add_initial_support_for_qcs615-v2-0-9236223e7dab@quicinc.com |
|---|---|
| Headers | show |
| Series | Add initial support for QCS615 SoC and QCS615 RIDE board | expand |
在 9/13/2024 10:24 PM, Rob Herring (Arm) 写道: > > On Fri, 13 Sep 2024 19:55:22 +0800, Lijuan Gao wrote: >> This introduces the Device Tree for the QCS615 platform. >> >> Features added and enabled: >> - CPUs with PSCI idle states >> - Interrupt-controller with PDC wakeup support >> - Timers, TCSR Clock Controllers >> - Reserved Shared memory >> - QFPROM >> - TLMM >> - Watchdog >> - RPMH controller >> - Sleep stats driver >> >> This series are splited into three parts: >> - 1-3: Binding files for QCS615 SoC and PDC (Reviewed) >> - 4 : Soc table entry (Reviewed) >> - 5-6: Initial DTSI and RIDE board device tree >> >> Bindings Dependencies: >> watchdog: https://lore.kernel.org/all/20240912-add_watchdog_compatible_for_qcs615-v1-1-ec22b5ad9891@quicinc.com/ >> qfprom: https://lore.kernel.org/all/20240912-add_qfprom_compatible_for_qcs615-v1-1-9ef2e26c14ee@quicinc.com/ >> tcsr: https://lore.kernel.org/all/20240912-add_tcsr_compatible_for_qcs615-v1-1-5b85dd4d42ad@quicinc.com/ >> >> Build Dependencies: >> tlmm: https://lore.kernel.org/all/20240910-add_qcs615_pinctrl_driver-v1-0-36f4c0d527d8@quicinc.com/ >> >> Patch made the following verifications: >> - Successfully pass dt_binding_check with DT_CHECKER_FLAGS=-m for earch binding file >> - Successfully pass dtbs_check with W=1 for dts >> - Verified CPU Hotplug and online CPUs on QCS615 ride board >> - Checked pinctrl-maps path >> - Verified Watchdog functional with "echo 1 > /dev/watchdog", can trigger >> a watchdog bark and later bite >> - Verified functional with DCC console function on QCS615 ride board >> - RPMH controller driver probed successfully >> - Sleep stats driver probed successfully and checked qcom_stats >> node on QCS615 ride board >> >> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com> >> --- >> Changes in v2: >> - Collected reviewed-bys >> - Removed extra blank line >> - Removed redundant function >> - Renamed xo-board to xo-board-clk and move it and sleep-clk to board dts >> - Renamed system-sleep to cluster_sleep_2 >> - Removed cluster1 >> - Added entry-method for idle-states >> - Added DTS chassis type >> - Added TCSR Clock Controllers >> - Added Reserved Shared memory >> - Added QFPROM >> - Added TLMM >> - Added Watchdog >> - Added RPMH controller >> - Added Sleep stats driver >> - Link to v1: https://lore.kernel.org/r/20240828-add_initial_support_for_qcs615-v1-0-5599869ea10f@quicinc.com >> >> --- >> Lijuan Gao (6): >> dt-bindings: arm: qcom: document QCS615 and the reference board >> dt-bindings: arm: qcom,ids: add SoC ID for QCS615 >> dt-bindings: qcom,pdc: document QCS615 Power Domain Controller >> soc: qcom: socinfo: Add QCS615 SoC ID table entry >> arm64: dts: qcom: add initial support for QCS615 DTSI >> arm64: dts: qcom: add base QCS615 RIDE dts >> >> Documentation/devicetree/bindings/arm/qcom.yaml | 6 + >> .../bindings/interrupt-controller/qcom,pdc.yaml | 1 + >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 34 ++ >> arch/arm64/boot/dts/qcom/qcs615.dtsi | 511 +++++++++++++++++++++ >> drivers/soc/qcom/socinfo.c | 1 + >> include/dt-bindings/arm/qcom,ids.h | 1 + >> 7 files changed, 555 insertions(+) >> --- >> base-commit: 100cc857359b5d731407d1038f7e76cd0e871d94 >> change-id: 20240910-add_initial_support_for_qcs615-1a96c3469728 >> >> Best regards, >> -- >> Lijuan Gao <quic_lijuang@quicinc.com> >> >> >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y qcom/qcs615-ride.dtb' for 20240913-add_initial_support_for_qcs615-v2-0-9236223e7dab@quicinc.com: > > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: efuse@780000: compatible:0: 'qcom,qcs615-qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,msm8226-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcm2290-qfprom', 'qcom,qcs404-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sc8280xp-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom', 'qcom,sm8450-qfprom', 'qcom,sm8550-qfprom', 'qcom,sm8650-qfprom'] > from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: efuse@780000: Unevaluated properties are not allowed ('compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: /soc@0/efuse@780000: failed to match any schema with compatible: ['qcom,qcs615-qfprom', 'qcom,qfprom'] > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: /soc@0/syscon@1fc0000: failed to match any schema with compatible: ['qcom,qcs615-tcsr', 'syscon'] > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: /soc@0/pinctrl@3100000: failed to match any schema with compatible: ['qcom,qcs615-tlmm'] > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: watchdog@17c10000: compatible: 'oneOf' conditional failed, one must be fixed: > ['qcom,apss-wdt-qcs615', 'qcom,kpss-wdt'] is too long > ['qcom,apss-wdt-qcs615', 'qcom,kpss-wdt'] is too short > 'qcom,apss-wdt-qcs615' is not one of ['qcom,kpss-wdt-ipq4019', 'qcom,apss-wdt-ipq5018', 'qcom,apss-wdt-ipq5332', 'qcom,apss-wdt-ipq9574', 'qcom,apss-wdt-msm8226', 'qcom,apss-wdt-msm8974', 'qcom,apss-wdt-msm8994', 'qcom,apss-wdt-qcm2290', 'qcom,apss-wdt-qcs404', 'qcom,apss-wdt-sa8255p', 'qcom,apss-wdt-sa8775p', 'qcom,apss-wdt-sc7180', 'qcom,apss-wdt-sc7280', 'qcom,apss-wdt-sc8180x', 'qcom,apss-wdt-sc8280xp', 'qcom,apss-wdt-sdm845', 'qcom,apss-wdt-sdx55', 'qcom,apss-wdt-sdx65', 'qcom,apss-wdt-sm6115', 'qcom,apss-wdt-sm6350', 'qcom,apss-wdt-sm8150', 'qcom,apss-wdt-sm8250'] > 'qcom,kpss-wdt' was expected > 'qcom,scss-timer' was expected > 'qcom,apss-wdt-qcs615' is not one of ['qcom,kpss-wdt-apq8064', 'qcom,kpss-wdt-ipq8064', 'qcom,kpss-wdt-mdm9615', 'qcom,kpss-wdt-msm8960'] > 'qcom,msm-timer' was expected > 'qcom,kpss-timer' was expected > from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml# > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: /soc@0/watchdog@17c10000: failed to match any schema with compatible: ['qcom,apss-wdt-qcs615', 'qcom,kpss-wdt'] > There are some dependencies. The above errors are fixed by the following patches： 1. failed to match any schema with compatible: ['qcom,qcs615-qfprom', 'qcom,qfprom'] Fixed by https://lore.kernel.org/all/20240912-add_qfprom_compatible_for_qcs615-v1-1-9ef2e26c14ee@quicinc.com/ 2. failed to match any schema with compatible: ['qcom,qcs615-tcsr', 'syscon'] Fixed by https://lore.kernel.org/all/20240912-add_tcsr_compatible_for_qcs615-v1-1-5b85dd4d42ad@quicinc.com/ 3. failed to match any schema with compatible: ['qcom,qcs615-tlmm'] Fixed by https://lore.kernel.org/all/20240910-add_qcs615_pinctrl_driver-v1-0-36f4c0d527d8@quicinc.com/ 4. failed to match any schema with compatible: ['qcom,apss-wdt-qcs615', 'qcom,kpss-wdt'] Fixed by https://lore.kernel.org/all/20240912-add_watchdog_compatible_for_qcs615-v1-1-ec22b5ad9891@quicinc.com/ > > > >
This introduces the Device Tree for the QCS615 platform. Features added and enabled: - CPUs with PSCI idle states - Interrupt-controller with PDC wakeup support - Timers, TCSR Clock Controllers - Reserved Shared memory - QFPROM - TLMM - Watchdog - RPMH controller - Sleep stats driver This series are splited into three parts: - 1-3: Binding files for QCS615 SoC and PDC (Reviewed) - 4 : Soc table entry (Reviewed) - 5-6: Initial DTSI and RIDE board device tree Bindings Dependencies: watchdog: https://lore.kernel.org/all/20240912-add_watchdog_compatible_for_qcs615-v1-1-ec22b5ad9891@quicinc.com/ qfprom: https://lore.kernel.org/all/20240912-add_qfprom_compatible_for_qcs615-v1-1-9ef2e26c14ee@quicinc.com/ tcsr: https://lore.kernel.org/all/20240912-add_tcsr_compatible_for_qcs615-v1-1-5b85dd4d42ad@quicinc.com/ Build Dependencies: tlmm: https://lore.kernel.org/all/20240910-add_qcs615_pinctrl_driver-v1-0-36f4c0d527d8@quicinc.com/ Patch made the following verifications: - Successfully pass dt_binding_check with DT_CHECKER_FLAGS=-m for earch binding file - Successfully pass dtbs_check with W=1 for dts - Verified CPU Hotplug and online CPUs on QCS615 ride board - Checked pinctrl-maps path - Verified Watchdog functional with "echo 1 > /dev/watchdog", can trigger a watchdog bark and later bite - Verified functional with DCC console function on QCS615 ride board - RPMH controller driver probed successfully - Sleep stats driver probed successfully and checked qcom_stats node on QCS615 ride board Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com> --- Changes in v2: - Collected reviewed-bys - Removed extra blank line - Removed redundant function - Renamed xo-board to xo-board-clk and move it and sleep-clk to board dts - Renamed system-sleep to cluster_sleep_2 - Removed cluster1 - Added entry-method for idle-states - Added DTS chassis type - Added TCSR Clock Controllers - Added Reserved Shared memory - Added QFPROM - Added TLMM - Added Watchdog - Added RPMH controller - Added Sleep stats driver - Link to v1: https://lore.kernel.org/r/20240828-add_initial_support_for_qcs615-v1-0-5599869ea10f@quicinc.com --- Lijuan Gao (6): dt-bindings: arm: qcom: document QCS615 and the reference board dt-bindings: arm: qcom,ids: add SoC ID for QCS615 dt-bindings: qcom,pdc: document QCS615 Power Domain Controller soc: qcom: socinfo: Add QCS615 SoC ID table entry arm64: dts: qcom: add initial support for QCS615 DTSI arm64: dts: qcom: add base QCS615 RIDE dts Documentation/devicetree/bindings/arm/qcom.yaml | 6 + .../bindings/interrupt-controller/qcom,pdc.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/qcs615-ride.dts | 34 ++ arch/arm64/boot/dts/qcom/qcs615.dtsi | 511 +++++++++++++++++++++ drivers/soc/qcom/socinfo.c | 1 + include/dt-bindings/arm/qcom,ids.h | 1 + 7 files changed, 555 insertions(+) --- base-commit: 100cc857359b5d731407d1038f7e76cd0e871d94 change-id: 20240910-add_initial_support_for_qcs615-1a96c3469728 Best regards,