Message ID | 20240913123103.21226-6-kabel@kernel.org |
---|---|
State | New |
Headers | show |
Series | Turris Omnia LED driver changes | expand |
On Fri, Sep 13, 2024 at 02:30:57PM +0200, Marek Behún wrote: > Extend the cznic,turris-omnia-leds binding with interrupts property, > specifying the global LED brightness changed by button press interrupt. > > Signed-off-by: Marek Behún <kabel@kernel.org> > --- > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > index 34ef5215c150..f52f6304c79e 100644 > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > @@ -23,6 +23,12 @@ properties: > description: I2C slave address of the microcontroller. > maxItems: 1 > > + interrupts: > + description: > + Specifier for the global LED brightness changed by front button press > + interrupt. This "front button press" concerns me that you just hooked here gpio-key. Are you sure that this is the physical interrupt line going to this device? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml index 34ef5215c150..f52f6304c79e 100644 --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml @@ -23,6 +23,12 @@ properties: description: I2C slave address of the microcontroller. maxItems: 1 + interrupts: + description: + Specifier for the global LED brightness changed by front button press + interrupt. + maxItems: 1 + "#address-cells": const: 1 @@ -56,6 +62,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/leds/common.h> i2c { @@ -65,6 +72,7 @@ examples: led-controller@2b { compatible = "cznic,turris-omnia-leds"; reg = <0x2b>; + interrupts-extended = <&mcu 11 IRQ_TYPE_NONE>; #address-cells = <1>; #size-cells = <0>;
Extend the cznic,turris-omnia-leds binding with interrupts property, specifying the global LED brightness changed by button press interrupt. Signed-off-by: Marek Behún <kabel@kernel.org> --- .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)