| Message ID | 20240825183116.102953-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4c621d6e667af6a41a0434fed6774abec7857801 |
| Headers | show |
| Series | pmdomain: rockchip: Simplify dropping OF node reference | expand |
Am Sonntag, 25. August 2024, 20:31:16 CEST schrieb Krzysztof Kozlowski: > Drop OF node reference immediately after using it in > syscon_node_to_regmap(), which is both simpler and typical/expected > code pattern. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On Sun, 25 Aug 2024 at 20:31, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Drop OF node reference immediately after using it in > syscon_node_to_regmap(), which is both simpler and typical/expected > code pattern. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied for next, thanks! Kind regards Uffe > --- > drivers/pmdomain/rockchip/pm-domains.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c > index 64b4d7120d83..5ee7efbd2ef8 100644 > --- a/drivers/pmdomain/rockchip/pm-domains.c > +++ b/drivers/pmdomain/rockchip/pm-domains.c > @@ -716,12 +716,11 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu, > goto err_unprepare_clocks; > } > pd->qos_regmap[j] = syscon_node_to_regmap(qos_node); > + of_node_put(qos_node); > if (IS_ERR(pd->qos_regmap[j])) { > error = -ENODEV; > - of_node_put(qos_node); > goto err_unprepare_clocks; > } > - of_node_put(qos_node); > } > } > > -- > 2.43.0 >
> Drop OF node reference immediately after using it in > syscon_node_to_regmap(), which is both simpler and typical/expected > code pattern. Dear Krzysztof, I noticed also this contribution. I found it easy to convert it also into the following small script variant for the semantic patch language (Coccinelle software). @adjustment@ expression e, x; @@ +of_node_put(e); if (...) { <+... when != e = x - of_node_put(e); ...+> } -of_node_put(e); 58 patches were accordingly generated for source files of the software “Linux next-20240913”. How would we like to tackle remaining update candidates according to similar transformation patterns? Regards, Markus
diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c index 64b4d7120d83..5ee7efbd2ef8 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -716,12 +716,11 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu, goto err_unprepare_clocks; } pd->qos_regmap[j] = syscon_node_to_regmap(qos_node); + of_node_put(qos_node); if (IS_ERR(pd->qos_regmap[j])) { error = -ENODEV; - of_node_put(qos_node); goto err_unprepare_clocks; } - of_node_put(qos_node); } }
Drop OF node reference immediately after using it in syscon_node_to_regmap(), which is both simpler and typical/expected code pattern. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/pmdomain/rockchip/pm-domains.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)