| Message ID | 20240911084353.28888-2-towinchenmi@gmail.com |
|---|---|
| Headers | show |
| Series | Initial device trees for A7-A11 based Apple devices | expand |
On Wed, 11 Sep 2024 16:40:50 +0800, Nick Chan wrote: > Hi, > > This series adds device trees for all A7-A11 SoC based iPhones, iPads, > iPod touches and Apple TVs. > > The following devices has been excluded from this series: > - All T2 devices (A10-based): bootloader does not work (yet) > - HomePod: Not tested, and it's also a different form factor > > This series supports the following on all devices: > - SMP (spin-table) > - UART > - simple-framebuffer > - watchdog > - timer > - pinctrl > - AIC interrupts > > The following is supported on A7-A10: > - gpio-keys > The buttons on A11 based devices like the iPhone X is a SMC subdevice, > and cannot be supported in this way. > > The following is supported on A10: > - cpufreq > > A10(X) has performance and efficiency core pairs that act as single logical > cores, and only one type of core can be active at a given time. This results > in a core that suddenly have its capacity lowered in low p-states, > so the frequencies of the low p-states must be adjusted. > > Patch dependencies: > - The required AIC patches[1] has been sitting in linux-next since > next-20240906, through the tip tree. > - The important serial fixes[2] will go through the samsung tree and should > be in good shape though those have not been merged. > - The optional patch to disable 32-bit EL0 on A10(X)[3] has not received > any comments (v1 or v2). > > Authorship information: > - The commits to actually add the dts files are mostly made by Konard, > and Konard's sign-off is added by me with permission. I also updated the > Konrad's email in the actual dts files. Konrad can confirm this. > > - Everything else is entirely made by me, including the cpufreq additions > into the dts file for A10. > > [1]: https://lore.kernel.org/asahi/20240901034143.12731-1-towinchenmi@gmail.com > [2]: https://lore.kernel.org/asahi/20240911050741.14477-1-towinchenmi@gmail.com > [3]: https://lore.kernel.org/asahi/20240909091425.16258-1-towinchenmi@gmail.com > > Nick Chan > --- > > Konrad Dybcio (8): > arm64: dts: apple: Add A7 devices > arm64: dts: apple: Add A8 devices > arm64: dts: apple: Add A8X devices > arm64: dts: apple: Add A9 devices > arm64: dts: apple: Add A9X devices > arm64: dts: apple: Add A10 devices > arm64: dts: apple: Add A10X devices > arm64: dts: apple: Add A11 devices > > Nick Chan (14): > dt-bindings: arm: cpus: Add Apple A7-A11 CPU cores > dt-bindings: watchdog: apple,wdt: Add A7-A11 compatibles > dt-bindings: cpufreq: apple,cluster-cpufreq: Add A10 compatible > dt-bindings: pinctrl: apple,pinctrl: Add A7-A11 compatibles > dt-bindings: arm: apple: Add A7 devices > dt-bindings: arm: apple: Add A8 devices > dt-bindings: arm: apple: Add A8X devices > dt-bindings: arm: apple: Add A9 devices > dt-bindings: arm: apple: Add A9X devices > dt-bindings: arm: apple: Add A10 devices > dt-bindings: arm: apple: Add A10X devices > dt-bindings: arm: apple: Add A11 devices > arm64: dts: apple: t8010: Add cpufreq nodes > arm64: Kconfig: Update help text for CONFIG_ARCH_APPLE > > .../devicetree/bindings/arm/apple.yaml | 160 ++++++++++- > .../devicetree/bindings/arm/cpus.yaml | 6 + > .../cpufreq/apple,cluster-cpufreq.yaml | 4 +- > .../bindings/pinctrl/apple,pinctrl.yaml | 5 + > .../bindings/watchdog/apple,wdt.yaml | 5 + > arch/arm64/Kconfig.platforms | 4 +- > arch/arm64/boot/dts/apple/Makefile | 52 ++++ > arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi | 52 ++++ > arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi | 52 ++++ > arch/arm64/boot/dts/apple/s5l8960x-j71.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j72.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j73.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j85.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j85m.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j86.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j86m.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j87.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-j87m.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi | 52 ++++ > arch/arm64/boot/dts/apple/s5l8960x-mini3.dtsi | 13 + > arch/arm64/boot/dts/apple/s5l8960x-n51.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x-n53.dts | 14 + > arch/arm64/boot/dts/apple/s5l8960x.dtsi | 147 ++++++++++ > arch/arm64/boot/dts/apple/s8000-j71s.dts | 15 + > arch/arm64/boot/dts/apple/s8000-j72s.dts | 15 + > arch/arm64/boot/dts/apple/s8000-n66.dts | 15 + > arch/arm64/boot/dts/apple/s8000-n69u.dts | 15 + > arch/arm64/boot/dts/apple/s8000-n71.dts | 15 + > arch/arm64/boot/dts/apple/s8000.dtsi | 179 ++++++++++++ > arch/arm64/boot/dts/apple/s8001-j127.dts | 14 + > arch/arm64/boot/dts/apple/s8001-j128.dts | 14 + > arch/arm64/boot/dts/apple/s8001-j98a.dts | 14 + > arch/arm64/boot/dts/apple/s8001-j99a.dts | 14 + > arch/arm64/boot/dts/apple/s8001-pro.dtsi | 45 +++ > arch/arm64/boot/dts/apple/s8001.dtsi | 167 +++++++++++ > arch/arm64/boot/dts/apple/s8003-j71t.dts | 15 + > arch/arm64/boot/dts/apple/s8003-j72t.dts | 15 + > arch/arm64/boot/dts/apple/s8003-n66m.dts | 15 + > arch/arm64/boot/dts/apple/s8003-n69.dts | 15 + > arch/arm64/boot/dts/apple/s8003-n71m.dts | 15 + > arch/arm64/boot/dts/apple/s8003.dtsi | 19 ++ > arch/arm64/boot/dts/apple/s800x-6s.dtsi | 50 ++++ > arch/arm64/boot/dts/apple/s800x-ipad5.dtsi | 44 +++ > arch/arm64/boot/dts/apple/s800x-se.dtsi | 50 ++++ > arch/arm64/boot/dts/apple/t7000-6.dtsi | 50 ++++ > arch/arm64/boot/dts/apple/t7000-j42d.dts | 18 ++ > arch/arm64/boot/dts/apple/t7000-j96.dts | 14 + > arch/arm64/boot/dts/apple/t7000-j97.dts | 14 + > arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 51 ++++ > arch/arm64/boot/dts/apple/t7000-n102.dts | 49 ++++ > arch/arm64/boot/dts/apple/t7000-n56.dts | 14 + > arch/arm64/boot/dts/apple/t7000-n61.dts | 14 + > arch/arm64/boot/dts/apple/t7000.dtsi | 147 ++++++++++ > arch/arm64/boot/dts/apple/t7001-air2.dtsi | 44 +++ > arch/arm64/boot/dts/apple/t7001-j81.dts | 14 + > arch/arm64/boot/dts/apple/t7001-j82.dts | 14 + > arch/arm64/boot/dts/apple/t7001.dtsi | 154 ++++++++++ > arch/arm64/boot/dts/apple/t8010-7.dtsi | 45 +++ > arch/arm64/boot/dts/apple/t8010-d10.dts | 14 + > arch/arm64/boot/dts/apple/t8010-d101.dts | 14 + > arch/arm64/boot/dts/apple/t8010-d11.dts | 14 + > arch/arm64/boot/dts/apple/t8010-d111.dts | 14 + > arch/arm64/boot/dts/apple/t8010-fast.dtsi | 27 ++ > arch/arm64/boot/dts/apple/t8010-ipad6.dtsi | 45 +++ > arch/arm64/boot/dts/apple/t8010-ipad7.dtsi | 15 + > arch/arm64/boot/dts/apple/t8010-j171.dts | 14 + > arch/arm64/boot/dts/apple/t8010-j172.dts | 14 + > arch/arm64/boot/dts/apple/t8010-j71b.dts | 14 + > arch/arm64/boot/dts/apple/t8010-j72b.dts | 14 + > arch/arm64/boot/dts/apple/t8010-n112.dts | 48 ++++ > arch/arm64/boot/dts/apple/t8010.dtsi | 227 +++++++++++++++ > arch/arm64/boot/dts/apple/t8011-j105a.dts | 14 + > arch/arm64/boot/dts/apple/t8011-j120.dts | 14 + > arch/arm64/boot/dts/apple/t8011-j121.dts | 14 + > arch/arm64/boot/dts/apple/t8011-j207.dts | 14 + > arch/arm64/boot/dts/apple/t8011-j208.dts | 14 + > arch/arm64/boot/dts/apple/t8011-pro2.dtsi | 45 +++ > arch/arm64/boot/dts/apple/t8011.dtsi | 175 ++++++++++++ > arch/arm64/boot/dts/apple/t8015-8.dtsi | 12 + > arch/arm64/boot/dts/apple/t8015-8plus.dtsi | 9 + > arch/arm64/boot/dts/apple/t8015-d20.dts | 14 + > arch/arm64/boot/dts/apple/t8015-d201.dts | 14 + > arch/arm64/boot/dts/apple/t8015-d21.dts | 14 + > arch/arm64/boot/dts/apple/t8015-d211.dts | 14 + > arch/arm64/boot/dts/apple/t8015-d22.dts | 14 + > arch/arm64/boot/dts/apple/t8015-d221.dts | 14 + > arch/arm64/boot/dts/apple/t8015-x.dtsi | 15 + > arch/arm64/boot/dts/apple/t8015.dtsi | 269 ++++++++++++++++++ > 88 files changed, 3257 insertions(+), 4 deletions(-) > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j71.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j72.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j73.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j85.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j85m.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j86.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j86m.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j87.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-j87m.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-mini3.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-n51.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-n53.dts > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8000-j71s.dts > create mode 100644 arch/arm64/boot/dts/apple/s8000-j72s.dts > create mode 100644 arch/arm64/boot/dts/apple/s8000-n66.dts > create mode 100644 arch/arm64/boot/dts/apple/s8000-n69u.dts > create mode 100644 arch/arm64/boot/dts/apple/s8000-n71.dts > create mode 100644 arch/arm64/boot/dts/apple/s8000.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8001-j127.dts > create mode 100644 arch/arm64/boot/dts/apple/s8001-j128.dts > create mode 100644 arch/arm64/boot/dts/apple/s8001-j98a.dts > create mode 100644 arch/arm64/boot/dts/apple/s8001-j99a.dts > create mode 100644 arch/arm64/boot/dts/apple/s8001-pro.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8001.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8003-j71t.dts > create mode 100644 arch/arm64/boot/dts/apple/s8003-j72t.dts > create mode 100644 arch/arm64/boot/dts/apple/s8003-n66m.dts > create mode 100644 arch/arm64/boot/dts/apple/s8003-n69.dts > create mode 100644 arch/arm64/boot/dts/apple/s8003-n71m.dts > create mode 100644 arch/arm64/boot/dts/apple/s8003.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s800x-6s.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s800x-ipad5.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s800x-se.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7000-6.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7000-j42d.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000-j96.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000-j97.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000-mini4.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7000-n102.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000-n56.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000-n61.dts > create mode 100644 arch/arm64/boot/dts/apple/t7000.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7001-air2.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7001-j81.dts > create mode 100644 arch/arm64/boot/dts/apple/t7001-j82.dts > create mode 100644 arch/arm64/boot/dts/apple/t7001.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-7.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-d10.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-d101.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-d11.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-d111.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-fast.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-ipad6.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-ipad7.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-j171.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-j172.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-j71b.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-j72b.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010-n112.dts > create mode 100644 arch/arm64/boot/dts/apple/t8010.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8011-j105a.dts > create mode 100644 arch/arm64/boot/dts/apple/t8011-j120.dts > create mode 100644 arch/arm64/boot/dts/apple/t8011-j121.dts > create mode 100644 arch/arm64/boot/dts/apple/t8011-j207.dts > create mode 100644 arch/arm64/boot/dts/apple/t8011-j208.dts > create mode 100644 arch/arm64/boot/dts/apple/t8011-pro2.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8011.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8015-8.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8015-8plus.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8015-d20.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-d201.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-d21.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-d211.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-d22.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-d221.dts > create mode 100644 arch/arm64/boot/dts/apple/t8015-x.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8015.dtsi > > > base-commit: 6708132e80a2ced620bde9b9c36e426183544a23 > -- > 2.46.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y apple/s5l8960x-j71.dtb apple/s5l8960x-j72.dtb apple/s5l8960x-j73.dtb apple/s5l8960x-j85.dtb apple/s5l8960x-j85m.dtb apple/s5l8960x-j86.dtb apple/s5l8960x-j86m.dtb apple/s5l8960x-j87.dtb apple/s5l8960x-j87m.dtb apple/s5l8960x-n51.dtb apple/s5l8960x-n53.dtb apple/s8000-j71s.dtb apple/s8000-j72s.dtb apple/s8000-n66.dtb apple/s8000-n69u.dtb apple/s8000-n71.dtb apple/s8001-j127.dtb apple/s8001-j128.dtb apple/s8001-j98a.dtb apple/s8001-j99a.dtb apple/s8003-j71t.dtb apple/s8003-j72t.dtb apple/s8003-n66m.dtb apple/s8003-n69.dtb apple/s8003-n71m.dtb apple/t7000-j42d.dtb apple/t7000-j96.dtb apple/t7000-j97.dtb apple/t7000-n102.dtb apple/t7000-n56.dtb apple/t7000-n61.dtb apple/t7001-j81.dtb apple/t7001-j82.dtb apple/t8010-d10.dtb apple/t8010-d101.dtb apple/t8010-d11.dtb apple/t8010-d111.dtb apple/t8010-j171.dtb apple/t8010-j172.dtb apple/t8010-j71b.dtb apple/t8010-j72b.dtb apple/t8010-n112.dtb apple/t8011-j105a.dtb apple/t8011-j120.dtb apple/t8011-j121.dtb apple/t8011-j207.dtb apple/t8011-j208.dtb apple/t8015-d20.dtb apple/t8015-d201.dtb apple/t8015-d21.dtb apple/t8015-d211.dtb apple/t8015-d22.dtb apple/t8015-d221.dtb' for 20240911084353.28888-2-towinchenmi@gmail.com: Error: arch/arm64/boot/dts/apple/t8010-n112.dts:21.18-19 syntax error FATAL ERROR: Unable to parse input tree make[3]: *** [scripts/Makefile.dtbs:129: arch/arm64/boot/dts/apple/t8010-n112.dtb] Error 1 make[2]: *** [scripts/Makefile.build:478: arch/arm64/boot/dts/apple] Error 2 make[2]: Target 'arch/arm64/boot/dts/apple/t8010-n112.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1392: apple/t8010-n112.dtb] Error 2 make: *** [Makefile:224: __sub-make] Error 2 make: Target 'apple/s5l8960x-j71.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j72.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j73.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j85.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j85m.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j86.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j86m.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j87.dtb' not remade because of errors. make: Target 'apple/s5l8960x-j87m.dtb' not remade because of errors. make: Target 'apple/s5l8960x-n51.dtb' not remade because of errors. make: Target 'apple/s5l8960x-n53.dtb' not remade because of errors. make: Target 'apple/s8000-j71s.dtb' not remade because of errors. make: Target 'apple/s8000-j72s.dtb' not remade because of errors. make: Target 'apple/s8000-n66.dtb' not remade because of errors. make: Target 'apple/s8000-n69u.dtb' not remade because of errors. make: Target 'apple/s8000-n71.dtb' not remade because of errors. make: Target 'apple/s8001-j127.dtb' not remade because of errors. make: Target 'apple/s8001-j128.dtb' not remade because of errors. make: Target 'apple/s8001-j98a.dtb' not remade because of errors. make: Target 'apple/s8001-j99a.dtb' not remade because of errors. make: Target 'apple/s8003-j71t.dtb' not remade because of errors. make: Target 'apple/s8003-j72t.dtb' not remade because of errors. make: Target 'apple/s8003-n66m.dtb' not remade because of errors. make: Target 'apple/s8003-n69.dtb' not remade because of errors. make: Target 'apple/s8003-n71m.dtb' not remade because of errors. make: Target 'apple/t7000-j42d.dtb' not remade because of errors. make: Target 'apple/t7000-j96.dtb' not remade because of errors. make: Target 'apple/t7000-j97.dtb' not remade because of errors. make: Target 'apple/t7000-n102.dtb' not remade because of errors. make: Target 'apple/t7000-n56.dtb' not remade because of errors. make: Target 'apple/t7000-n61.dtb' not remade because of errors. make: Target 'apple/t7001-j81.dtb' not remade because of errors. make: Target 'apple/t7001-j82.dtb' not remade because of errors. make: Target 'apple/t8010-d10.dtb' not remade because of errors. make: Target 'apple/t8010-d101.dtb' not remade because of errors. make: Target 'apple/t8010-d11.dtb' not remade because of errors. make: Target 'apple/t8010-d111.dtb' not remade because of errors. make: Target 'apple/t8010-j171.dtb' not remade because of errors. make: Target 'apple/t8010-j172.dtb' not remade because of errors. make: Target 'apple/t8010-j71b.dtb' not remade because of errors. make: Target 'apple/t8010-j72b.dtb' not remade because of errors. make: Target 'apple/t8010-n112.dtb' not remade because of errors. make: Target 'apple/t8011-j105a.dtb' not remade because of errors. make: Target 'apple/t8011-j120.dtb' not remade because of errors. make: Target 'apple/t8011-j121.dtb' not remade because of errors. make: Target 'apple/t8011-j207.dtb' not remade because of errors. make: Target 'apple/t8011-j208.dtb' not remade because of errors. make: Target 'apple/t8015-d20.dtb' not remade because of errors. make: Target 'apple/t8015-d201.dtb' not remade because of errors. make: Target 'apple/t8015-d21.dtb' not remade because of errors. make: Target 'apple/t8015-d211.dtb' not remade because of errors. make: Target 'apple/t8015-d22.dtb' not remade because of errors. make: Target 'apple/t8015-d221.dtb' not remade because of errors.
On 11/9/2024 21:57, Nick Chan wrote: > > > On 11/9/2024 21:50, Rob Herring (Arm) wrote: >> >> On Wed, 11 Sep 2024 16:40:50 +0800, Nick Chan wrote: >> ... >> Error: arch/arm64/boot/dts/apple/t8010-n112.dts:21.18-19 syntax error > Note: this is caused by missing #include <dt-bindings/input/input.h> > This was not caught due to another error: It was not included in the > Makefile. I mean, it is added into the Makefile, but it got removed by the commit to add A10X dts files... > > Nick Chan
There is a recommended device tree node `chassis-type` to specify the type of the chassis. For iPhones, iPod touches and iPads it is pretty obvious that they are `handset` and `tablet`. However, nothing really fits for Apple TV so a new chassis-type value may need to be added. Nick Chan
On Wed, Sep 11, 2024 at 04:40:51PM +0800, Nick Chan wrote: > Add the following CPU cores: > > - apple,cyclone: A7 cores > - apple,typhoon: A8 cores > - apple,twister: A9 cores > - apple,hurricane-zephyr: A10 logical cores > - apple,monsoon: A11 performance cores > - apple,mistral: A11 efficiency cores > > In the Apple A10, there are physical performance-efficiency cores that > forms logical cores to software depending on the current p-state, and > only one type of core may be active at one time. > > Signed-off-by: Nick Chan <towinchenmi@gmail.com> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > index f308ff6c3532..3959e022079f 100644 > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > @@ -89,6 +89,12 @@ properties: > - apple,blizzard > - apple,icestorm > - apple,firestorm > + - apple,mistral > + - apple,monsoon > + - apple,hurricane-zephyr > + - apple,twister > + - apple,typhoon > + - apple,cyclone Same on this one, can you add these in alphanumerical order, even if the existing 3 devices are not in it? You could take the opportunity to reshuffle icestorm and firestorm while you're at it. Cheers, Conor. > - arm,arm710t > - arm,arm720t > - arm,arm740t > -- > 2.46.0 >
On Thu, Sep 12, 2024 at 02:24:22AM +0800, Nick Chan wrote: > > > On 12/9/2024 02:13, Conor Dooley wrote: > > On Wed, Sep 11, 2024 at 04:40:55PM +0800, Nick Chan wrote: > >> This adds the following apple,s5l8960x platforms: > >> > >> - iPhone 5s > >> - iPad Air (1) > >> - iPad Mini 2 > >> - iPad Mini 3 > >> > >> Signed-off-by: Nick Chan <towinchenmi@gmail.com> > >> --- > >> .../devicetree/bindings/arm/apple.yaml | 26 ++++++++++++++++++- > >> 1 file changed, 25 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > >> index 883fd67e3752..3c81008f0e96 100644 > >> --- a/Documentation/devicetree/bindings/arm/apple.yaml > >> +++ b/Documentation/devicetree/bindings/arm/apple.yaml > >> @@ -12,7 +12,14 @@ maintainers: > >> description: | > >> ARM platforms using SoCs designed by Apple Inc., branded "Apple Silicon". > >> > >> - This currently includes devices based on the "M1" SoC: > >> + This currently includes devices based on the "A7" SoC: > >> + > >> + - iPhone 5s > >> + - iPad Air (1) > >> + - iPad Mini 2 > >> + - iPad Mini 3 > >> + > >> + Devices based on the "M1" SoC: > >> > >> - Mac mini (M1, 2020) > >> - MacBook Pro (13-inch, M1, 2020) > >> @@ -65,6 +72,23 @@ properties: > >> const: "/" > >> compatible: > >> oneOf: > >> + - description: Apple A7 SoC based platforms > >> + items: > >> + - enum: > >> + - apple,j71 # iPad Air (Wi-Fi) > >> + - apple,j72 # iPad Air (Cellular) > >> + - apple,j73 # iPad Air (Cellular, China) > >> + - apple,j85 # iPad mini 2 (Wi-Fi) > >> + - apple,j85m # iPad mini 3 (Wi-Fi) > >> + - apple,j86 # iPad mini 2 (Cellular) > >> + - apple,j86m # iPad mini 3 (Cellular) > >> + - apple,j87 # Apple iPad Mini 2 (Cellular, China) > >> + - apple,j87m # Apple iPad Mini 3 (Cellular, China) > >> + - apple,n51 # iPhone 5s (GSM) > >> + - apple,n53 # iPhone 5s (LTE) > >> + - const: apple,s5l8960x > > > > Is the "x" here a wildcard? > No. This is part of the SoC ID. This is the legacy naming from when Apple > used Samsung SoCs for iPhones and iPods, and every SoC would have an ID > beginning with "s5l", and ending with a "x". Apple A7 is last SoC to use > this legacy naming scheme. Okay, thanks for explaining. Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.