mbox series

[v2,0/2] qcom: allow msm_gpio to set special pins direction & value

Message ID 20240911-topic-sm8x50-msm-gpio-special-pins-sm8250-v2-0-c49834055128@linaro.org
Headers show
Series qcom: allow msm_gpio to set special pins direction & value | expand

Message

Neil Armstrong Sept. 11, 2024, 6:07 p.m. UTC 
After struct msm_special_pin_data was introduced in [1], use the data
to setup the pin direction and/or value if supported by the pin data.

Add the proper msm_special_pin_data for sm8250 after sm8550 and sm8650.

[1] https://lore.kernel.org/all/20240528-topic-sm8x50-pinctrl-pinconf-v1-0-54d1e9ad7dfa@linaro.org/

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v2:
- dropped last line of sm8250_pin_offsets
- Link to v1: https://lore.kernel.org/r/20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-v1-0-50623a7e4931@linaro.org

---
Neil Armstrong (2):
      gpio: msm: add support for special pins
      pinctr: qcom: sm8250: add special pins pins configuration data

 drivers/gpio/msm_gpio.c               | 97 ++++++++++++++++++++++++++++++++---
 drivers/pinctrl/qcom/pinctrl-sm8250.c | 42 +++++++++++++--
 2 files changed, 127 insertions(+), 12 deletions(-)
---
base-commit: ca55cf8104c0dd78aae45fa66dd8400ef1b3d0ac
change-id: 20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-943311b483e2

Best regards,

Comments

Caleb Connolly Sept. 12, 2024, 11:43 a.m. UTC | #1 
Hi Neil,

On 11/09/2024 20:07, Neil Armstrong wrote:
> After struct msm_special_pin_data was introduced in [1], use the data
> to setup the pin direction and/or value if supported by the pin data.
> 
> Add the proper msm_special_pin_data for sm8250 after sm8550 and sm8650.
> 
> [1] https://lore.kernel.org/all/20240528-topic-sm8x50-pinctrl-pinconf-v1-0-54d1e9ad7dfa@linaro.org/
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks for this!

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

Kind regards,
> ---
> Changes in v2:
> - dropped last line of sm8250_pin_offsets
> - Link to v1: https://lore.kernel.org/r/20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-v1-0-50623a7e4931@linaro.org
> 
> ---
> Neil Armstrong (2):
>       gpio: msm: add support for special pins
>       pinctr: qcom: sm8250: add special pins pins configuration data
> 
>  drivers/gpio/msm_gpio.c               | 97 ++++++++++++++++++++++++++++++++---
>  drivers/pinctrl/qcom/pinctrl-sm8250.c | 42 +++++++++++++--
>  2 files changed, 127 insertions(+), 12 deletions(-)
> ---
> base-commit: ca55cf8104c0dd78aae45fa66dd8400ef1b3d0ac
> change-id: 20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-943311b483e2
> 
> Best regards,
Caleb Connolly Oct. 2, 2024, 2:52 p.m. UTC | #2 
On Wed, 11 Sep 2024 20:07:13 +0200, Neil Armstrong wrote:
> After struct msm_special_pin_data was introduced in [1], use the data
> to setup the pin direction and/or value if supported by the pin data.
> 
> Add the proper msm_special_pin_data for sm8250 after sm8550 and sm8650.
> 
> [1] https://lore.kernel.org/all/20240528-topic-sm8x50-pinctrl-pinconf-v1-0-54d1e9ad7dfa@linaro.org/
> 
> [...]

Applied, thanks!

[1/2] gpio: msm: add support for special pins
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/5fe73d1ecad4
[2/2] pinctr: qcom: sm8250: add special pins pins configuration data
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/43a6e47a5366

Best regards,