mbox series

[v4,0/5] target/sparc: emulate floating point queue when raising fp traps

Message ID 20240909180712.651651-1-richard.henderson@linaro.org
Headers show
Series target/sparc: emulate floating point queue when raising fp traps | expand

Message

Richard Henderson Sept. 9, 2024, 6:07 p.m. UTC 
Changes for v5:
  - Fix stdfq advance_pc.

r~

Carl Hauser (2):
  target/sparc: Add FQ and FSR.QNE
  target/sparc: Populate sparc32 FQ when raising fp exception

Richard Henderson (3):
  target/sparc: Add FSR_QNE to tb_flags
  target/sparc: Implement STDFQ
  target/sparc: Add gen_trap_if_nofpu_fpexception

 target/sparc/cpu.h          |  30 ++++++++-
 target/sparc/fop_helper.c   |   4 ++
 target/sparc/int32_helper.c |  40 ++++++-----
 target/sparc/machine.c      |  25 +++++++
 target/sparc/translate.c    | 128 ++++++++++++++++++++++++++----------
 target/sparc/insns.decode   |   2 +-
 6 files changed, 178 insertions(+), 51 deletions(-)

Comments

Mark Cave-Ayland Sept. 10, 2024, 8:21 p.m. UTC | #1 
On 09/09/2024 19:07, Richard Henderson wrote:

> Changes for v5:
>    - Fix stdfq advance_pc.
> 
> r~
> 
> Carl Hauser (2):
>    target/sparc: Add FQ and FSR.QNE
>    target/sparc: Populate sparc32 FQ when raising fp exception
> 
> Richard Henderson (3):
>    target/sparc: Add FSR_QNE to tb_flags
>    target/sparc: Implement STDFQ
>    target/sparc: Add gen_trap_if_nofpu_fpexception
> 
>   target/sparc/cpu.h          |  30 ++++++++-
>   target/sparc/fop_helper.c   |   4 ++
>   target/sparc/int32_helper.c |  40 ++++++-----
>   target/sparc/machine.c      |  25 +++++++
>   target/sparc/translate.c    | 128 ++++++++++++++++++++++++++----------
>   target/sparc/insns.decode   |   2 +-
>   6 files changed, 178 insertions(+), 51 deletions(-)

Should there be a:

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2340

somewhere in this series? I've not had to look at the FP exceptions in this level of 
detail before (so unsure that I have any suitable test cases lying around), but it 
looks reasonable so:

Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.