| Message ID | 20240903163033.3170815-3-ukaszb@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: Implement UCSI driver for ChromeOS | expand |
On Tue, Sep 03, 2024 at 04:30:27PM +0000, Łukasz Bartosik wrote: > From: Pavan Holla <pholla@chromium.org> > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > driver. Also, add any feature flags that are implemented by the EC > but are missing in the kernel header. > > Signed-off-by: Pavan Holla <pholla@chromium.org> Same as previous patch, it needs your S-o-b tag at the end. See [1]. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
On Fri, Sep 6, 2024 at 10:44 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > On Tue, Sep 03, 2024 at 04:30:27PM +0000, Łukasz Bartosik wrote: > > From: Pavan Holla <pholla@chromium.org> > > > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > > driver. Also, add any feature flags that are implemented by the EC > > but are missing in the kernel header. > > > > Signed-off-by: Pavan Holla <pholla@chromium.org> > > Same as previous patch, it needs your S-o-b tag at the end. See [1]. > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by I have not added any modifications to this patch. I understand that my S-o-b tag is not needed in such a case. Is that not correct ? Thanks, Lukasz
On Fri, Sep 06, 2024 at 03:53:06PM +0200, Łukasz Bartosik wrote: > On Fri, Sep 6, 2024 at 10:44 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > On Tue, Sep 03, 2024 at 04:30:27PM +0000, Łukasz Bartosik wrote: > > > From: Pavan Holla <pholla@chromium.org> > > > > > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > > > driver. Also, add any feature flags that are implemented by the EC > > > but are missing in the kernel header. > > > > > > Signed-off-by: Pavan Holla <pholla@chromium.org> > > > > Same as previous patch, it needs your S-o-b tag at the end. See [1]. > > > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > I have not added any modifications to this patch. I understand that my > S-o-b tag is not needed in such a case. Is that not correct ? If you are forwarding on patches from someone else, yes, you HAVE TO sign off on it as well saying that you are allowed to do the forwarding. thanks, greg k-h
On Fri, Sep 6, 2024 at 4:07 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Fri, Sep 06, 2024 at 03:53:06PM +0200, Łukasz Bartosik wrote: > > On Fri, Sep 6, 2024 at 10:44 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > > > On Tue, Sep 03, 2024 at 04:30:27PM +0000, Łukasz Bartosik wrote: > > > > From: Pavan Holla <pholla@chromium.org> > > > > > > > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > > > > driver. Also, add any feature flags that are implemented by the EC > > > > but are missing in the kernel header. > > > > > > > > Signed-off-by: Pavan Holla <pholla@chromium.org> > > > > > > Same as previous patch, it needs your S-o-b tag at the end. See [1]. > > > > > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > > > I have not added any modifications to this patch. I understand that my > > S-o-b tag is not needed in such a case. Is that not correct ? > > If you are forwarding on patches from someone else, yes, you HAVE TO > sign off on it as well saying that you are allowed to do the forwarding. > Thanks for the clarification Greg. I will add S-o-b then. Thanks, Lukasz > thanks, > > greg k-h >
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h index 08b6c98ed890..2998d956ba14 100644 --- a/include/linux/platform_data/cros_ec_commands.h +++ b/include/linux/platform_data/cros_ec_commands.h @@ -1312,6 +1312,38 @@ enum ec_feature_code { * The EC supports the AP composing VDMs for us to send. */ EC_FEATURE_TYPEC_AP_VDM_SEND = 46, + /* + * The EC supports system safe mode panic recovery. + */ + EC_FEATURE_SYSTEM_SAFE_MODE = 47, + /* + * The EC will reboot on runtime assertion failures. + */ + EC_FEATURE_ASSERT_REBOOTS = 48, + /* + * The EC image is built with tokenized logging enabled. + */ + EC_FEATURE_TOKENIZED_LOGGING = 49, + /* + * The EC supports triggering an STB dump. + */ + EC_FEATURE_AMD_STB_DUMP = 50, + /* + * The EC supports memory dump commands. + */ + EC_FEATURE_MEMORY_DUMP = 51, + /* + * The EC supports DP2.1 capability + */ + EC_FEATURE_TYPEC_DP2_1 = 52, + /* + * The MCU is System Companion Processor Core 1 + */ + EC_FEATURE_SCP_C1 = 53, + /* + * The EC supports UCSI PPM. + */ + EC_FEATURE_UCSI_PPM = 54, }; #define EC_FEATURE_MASK_0(event_code) BIT(event_code % 32)