| Message ID | 20240822090927.1444466-1-liyuesong@vivo.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc_bind() | expand |
Hi Yuesong Li, 2024년 8월 22일 (목) 오후 6:09, Yuesong Li <liyuesong@vivo.com>님이 작성: > > cocci reported a double assignment problem. Upon reviewing previous > commits, it appears this may actually be an incorrect assignment. > > Fixes: 8b9550344d39 ("drm/ipp: clean up debug messages") > Signed-off-by: Yuesong Li <liyuesong@vivo.com> > --- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > index 1b111e2c3347..752339d33f39 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > @@ -1174,7 +1174,7 @@ static int gsc_bind(struct device *dev, struct device *master, void *data) > struct exynos_drm_ipp *ipp = &ctx->ipp; > > ctx->drm_dev = drm_dev; > - ctx->drm_dev = drm_dev; > + ipp->drm_dev = drm_dev; Correct. drm_dev should be set to ipp->drm_dev like other sub modules of ipp - fimc, scaler and rotator - did. Applied. Thanks, Inki Dae > exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv); > > exynos_drm_ipp_register(dev, ipp, &ipp_funcs, > -- > 2.34.1 > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 1b111e2c3347..752339d33f39 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1174,7 +1174,7 @@ static int gsc_bind(struct device *dev, struct device *master, void *data) struct exynos_drm_ipp *ipp = &ctx->ipp; ctx->drm_dev = drm_dev; - ctx->drm_dev = drm_dev; + ipp->drm_dev = drm_dev; exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv); exynos_drm_ipp_register(dev, ipp, &ipp_funcs,
cocci reported a double assignment problem. Upon reviewing previous commits, it appears this may actually be an incorrect assignment. Fixes: 8b9550344d39 ("drm/ipp: clean up debug messages") Signed-off-by: Yuesong Li <liyuesong@vivo.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)