| Message ID | 20240826024705.55474-1-zhenghaowei@loongson.cn |
|---|---|
| Headers | show |
| Series | uart: Introduce uart driver for the Loongson family chips | expand |
On Mon, Aug 26, 2024 at 10:47:05AM +0800, zhenghaowei@loongson.cn wrote: > From: Haowei Zheng <zhenghaowei@loongson.cn> > > Change to use the Loongson UART driver for Loongson-2K2000, > Loongson-2K1000 and Loongson-2K0500. Why? That's what commit msg should explain. This is not bisectable and breaks users without any reasonable need/explanation. Best regards, Krzysztof
在 2024/8/26 14:00, Krzysztof Kozlowski 写道: > On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@loongson.cn wrote: >> From: Haowei Zheng<zhenghaowei@loongson.cn> >> >> Change to use the Loongson UART driver for Loongson-2K2000, >> Loongson-2K1000 and Loongson-2K0500. > Why? > > That's what commit msg should explain. This is not bisectable and > breaks users without any reasonable need/explanation. > > Best regards, > Krzysztof I got it, and I will provide detailed explanations like this: We have provided separate UART drivers for ls2k0500, ls2k1000, and ls2k2000, which solves the issue of the full-featured serial port being unusable. Additionally, we have implemented fractional division functionality for ls2k2000. Best regards, Haowei Zheng
On 26/08/2024 08:54, 郑豪威 wrote: > > 在 2024/8/26 14:00, Krzysztof Kozlowski 写道: >> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@loongson.cn wrote: >>> From: Haowei Zheng<zhenghaowei@loongson.cn> >>> >>> Change to use the Loongson UART driver for Loongson-2K2000, >>> Loongson-2K1000 and Loongson-2K0500. >> Why? >> >> That's what commit msg should explain. This is not bisectable and >> breaks users without any reasonable need/explanation. >> >> Best regards, >> Krzysztof > > I got it, and I will provide detailed explanations like this: > > We have provided separate UART drivers for ls2k0500, ls2k1000, and > > ls2k2000, which solves the issue of the full-featured serial port being > > unusable. Additionally, we have implemented fractional division > > functionality for ls2k2000. You still break the users. Explain the problem you are fixing. NAK. Best regards, Krzysztof
From: Haowei Zheng <zhenghaowei@loongson.cn> Hi all: This patchset introduce a generic UART framework driver for Loongson family. It can be found on Loongson3 series cpus, Loongson-2K series cpus and Loongson LS7A bridge chips. Thanks. Haowei Zheng (3): dt-bindings: serial: Add Loongson UART controller tty: serial: 8250: Add loongson uart driver support LoongArch: Update dts to support Loongson UART driver. .../bindings/serial/loongson,uart.yaml | 63 +++++ MAINTAINERS | 7 + arch/loongarch/boot/dts/loongson-2k0500.dtsi | 2 +- arch/loongarch/boot/dts/loongson-2k1000.dtsi | 2 +- arch/loongarch/boot/dts/loongson-2k2000.dtsi | 2 +- drivers/tty/serial/8250/8250_loongson.c | 228 ++++++++++++++++++ drivers/tty/serial/8250/8250_port.c | 8 + drivers/tty/serial/8250/Kconfig | 9 + drivers/tty/serial/8250/Makefile | 1 + include/uapi/linux/serial_core.h | 1 + 10 files changed, 320 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/serial/loongson,uart.yaml create mode 100644 drivers/tty/serial/8250/8250_loongson.c