diff mbox series

HID: winwing: constify read-only structs

Message ID 20240804-hid-const-winwing-v1-1-5a6c714753b1@weissschuh.net
State New
Headers show
Series HID: winwing: constify read-only structs | expand

Commit Message

Thomas Weißschuh Aug. 4, 2024, 4:29 p.m. UTC 
These structs are never modified, so mark them as const.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
While I stumbled upon this during the rdesc constification work,
this patch is unrelated to it and can be applied independently.
---
 drivers/hid/hid-winwing.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


---
base-commit: a5dbd76a89423eca9f8de338350f2666aacfb432
change-id: 20240804-hid-const-winwing-ca13bb09a5dc

Best regards,

Comments

Benjamin Tissoires Aug. 27, 2024, 4:27 p.m. UTC | #1 
On Sun, 04 Aug 2024 18:29:37 +0200, Thomas Weißschuh wrote:
> These structs are never modified, so mark them as const.
> 
> 

Applied to hid/hid.git (for-6.12/constify-rdesc), thanks!

[1/1] HID: winwing: constify read-only structs
      https://git.kernel.org/hid/hid/c/c1f9eff7b270

Cheers,
diff mbox series

Patch

diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c
index 10a5d87ccb96..7d1c0226ab60 100644
--- a/drivers/hid/hid-winwing.c
+++ b/drivers/hid/hid-winwing.c
@@ -27,7 +27,7 @@  struct winwing_led_info {
 	const char *led_name;
 };
 
-static struct winwing_led_info led_info[3] = {
+static const struct winwing_led_info led_info[3] = {
 	{ 0, 255, "backlight" },
 	{ 1, 1, "a-a" },
 	{ 2, 1, "a-g" },
@@ -94,7 +94,7 @@  static int winwing_init_led(struct hid_device *hdev,
 		return -ENOMEM;
 
 	for (i = 0; i < 3; i += 1) {
-		struct winwing_led_info *info = &led_info[i];
+		const struct winwing_led_info *info = &led_info[i];
 
 		led = &data->leds[i];
 		led->hdev = hdev;
@@ -150,7 +150,7 @@  static int winwing_input_configured(struct hid_device *hdev,
 	return ret;
 }
 
-static __u8 original_rdesc_buttons[] = {
+static const __u8 original_rdesc_buttons[] = {
 	0x05, 0x09, 0x19, 0x01, 0x29, 0x6F,
 	0x15, 0x00, 0x25, 0x01, 0x35, 0x00,
 	0x45, 0x01, 0x75, 0x01, 0x95, 0x6F,