diff mbox series

[1/2] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string

Message ID 20240821184356.163816-1-marex@denx.de
State New
Headers show
Series [1/2] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string | expand

Commit Message

Marek Vasut Aug. 21, 2024, 6:42 p.m. UTC
Document compatible string for the WILC3000 chip. The chip is similar
to WILC1000, except that the register layout is slightly different and
it does not support WPA3/SAE.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Adham Abozaeid <adham.abozaeid@microchip.com>
Cc: Ajay Singh <ajay.kathat@microchip.com>
Cc: Alexis Lothoré <alexis.lothore@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Marek Vasut <marex@denx.de>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
---
 .../devicetree/bindings/net/wireless/microchip,wilc1000.yaml  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Marek Vasut Aug. 23, 2024, 1:38 a.m. UTC | #1
On 8/22/24 10:07 AM, Krzysztof Kozlowski wrote:

Hi,

>> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> index 2460ccc082371..1bf3496c21e64 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>> @@ -16,7 +16,9 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: microchip,wilc1000
>> +    enum:
>> +      - microchip,wilc1000
>> +      - microchip,wilc3000
> 
> Your driver change suggests device type is fully auto-detectable

It seems that way, yes.

>, thus
> they are compatible.

I _think_ the hardware is internally somewhat different, the WILC1000 is 
WiFi-only device and the WILC3000 has some extra Bluetooth part (which 
is currently not supported).

Maybe a fallback compatible string would be better here ?
Krzysztof Kozlowski Aug. 23, 2024, 6:10 a.m. UTC | #2
On 23/08/2024 03:38, Marek Vasut wrote:
> On 8/22/24 10:07 AM, Krzysztof Kozlowski wrote:
> 
> Hi,
> 
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> index 2460ccc082371..1bf3496c21e64 100644
>>> --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> @@ -16,7 +16,9 @@ description:
>>>   
>>>   properties:
>>>     compatible:
>>> -    const: microchip,wilc1000
>>> +    enum:
>>> +      - microchip,wilc1000
>>> +      - microchip,wilc3000
>>
>> Your driver change suggests device type is fully auto-detectable
> 
> It seems that way, yes.
> 
>> , thus
>> they are compatible.
> 
> I _think_ the hardware is internally somewhat different, the WILC1000 is 
> WiFi-only device and the WILC3000 has some extra Bluetooth part (which 
> is currently not supported).
> 
> Maybe a fallback compatible string would be better here ?

Yes, that's what I meant by compatibility. 3000 followed by 1000.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
index 2460ccc082371..1bf3496c21e64 100644
--- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
@@ -16,7 +16,9 @@  description:
 
 properties:
   compatible:
-    const: microchip,wilc1000
+    enum:
+      - microchip,wilc1000
+      - microchip,wilc3000
 
   reg: true