mbox series

[v1,0/5] gpio: rockchip: Update the GPIO driver

Message ID 20240815071651.3645949-1-ye.zhang@rock-chips.com
Headers show
Series gpio: rockchip: Update the GPIO driver | expand

Message

Ye Zhang Aug. 15, 2024, 7:16 a.m. UTC 
GPIO driver support acpi and new version, set input direction in
irq_request_resources, fix division error and debounce config error.

Ye Zhang (5):
  gpio: rockchip: support acpi
  gpio: rockchip: support GPIO_TYPE_V2_2
  gpio: rockchip: Set input direction in irq_request_resources
  gpio: rockchip: avoid division by zero
  rockchip: gpio: fix debounce config error

 drivers/gpio/gpio-rockchip.c | 286 ++++++++++++++++++++++-------------
 1 file changed, 180 insertions(+), 106 deletions(-)

Comments

Bartosz Golaszewski Aug. 16, 2024, 9:46 a.m. UTC | #1 
On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@rock-chips.com> wrote:
>
> GPIO driver support acpi and new version, set input direction in
> irq_request_resources, fix division error and debounce config error.
>
> Ye Zhang (5):
>   gpio: rockchip: support acpi
>   gpio: rockchip: support GPIO_TYPE_V2_2
>   gpio: rockchip: Set input direction in irq_request_resources
>   gpio: rockchip: avoid division by zero
>   rockchip: gpio: fix debounce config error
>
>  drivers/gpio/gpio-rockchip.c | 286 ++++++++++++++++++++++-------------
>  1 file changed, 180 insertions(+), 106 deletions(-)
>
> --
> 2.34.1
>

Please Cc the GPIO ACPI maintainers on this series: Mika Westerberg
<mika.westerberg@linux.intel.com> and Andy Shevchenko
<andriy.shevchenko@linux.intel.com>.

Bart
Bartosz Golaszewski Aug. 16, 2024, 9:48 a.m. UTC | #2 
On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@rock-chips.com> wrote:
>
> 1. support ACPI
> 2. support 'clock-names' from dt nodes
> 3. driver works without pinctrl device

This is not how commit messages are written. Please take a look at
examples in kernel git history. Also: the three bullet points here
sound like they should be separate commits.

Bart
Bartosz Golaszewski Aug. 16, 2024, 9:49 a.m. UTC | #3 
On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@rock-chips.com> wrote:
>
> Support GPIO_TYPE_V2_2
>

I don't know what GPIO_TYPE_V2_2 is. Please explain in detail what
you're doing here.

Bart
Bartosz Golaszewski Aug. 16, 2024, 10:11 a.m. UTC | #4 
On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@rock-chips.com> wrote:
>
> 1. Prevent data from crossing boundaries

I don't understand.

> 2. Support GPIO_TYPE_V2_2 debounce config

Should this be a separate patch?

> 3. fix rockchip_gpio_set_config
>

Same? And a fix?

Bart