mbox series

[v2,0/2] selftests: harness: refactor __constructor_order

Message ID 20240727143816.1808657-1-masahiroy@kernel.org
Headers show
Series selftests: harness: refactor __constructor_order | expand

Message

Masahiro Yamada July 27, 2024, 2:37 p.m. UTC 
This series refactors __constructor_order because
__constructor_order_last() is unneeded.

No code change since v1.
I reworded "reverse-order" to "backward-order" in commit description.


Masahiro Yamada (2):
  selftests: harness: remove unneeded __constructor_order_last()
  selftests: harness: rename __constructor_order for clarification

 .../drivers/s390x/uvdevice/test_uvdevice.c     |  6 ------
 tools/testing/selftests/hid/hid_bpf.c          |  6 ------
 tools/testing/selftests/kselftest_harness.h    | 18 ++++--------------
 tools/testing/selftests/rtc/rtctest.c          |  7 -------
 4 files changed, 4 insertions(+), 33 deletions(-)

Comments

Kees Cook Aug. 6, 2024, 4:27 a.m. UTC | #1 
On Sat, Jul 27, 2024 at 11:37:35PM +0900, Masahiro Yamada wrote:
> 
> This series refactors __constructor_order because
> __constructor_order_last() is unneeded.
> 
> No code change since v1.
> I reworded "reverse-order" to "backward-order" in commit description.
> 
> 
> Masahiro Yamada (2):
>   selftests: harness: remove unneeded __constructor_order_last()
>   selftests: harness: rename __constructor_order for clarification

Thanks for resending this!

Reviewed-by: Kees Cook <kees@kernel.org>

Shuah, do you want to take this via kselftest? If not, I can carry it...

-Kees
Shuah Khan Aug. 6, 2024, 7:36 p.m. UTC | #2 
On 8/5/24 22:27, Kees Cook wrote:
> On Sat, Jul 27, 2024 at 11:37:35PM +0900, Masahiro Yamada wrote:
>>
>> This series refactors __constructor_order because
>> __constructor_order_last() is unneeded.
>>
>> No code change since v1.
>> I reworded "reverse-order" to "backward-order" in commit description.
>>
>>
>> Masahiro Yamada (2):
>>    selftests: harness: remove unneeded __constructor_order_last()
>>    selftests: harness: rename __constructor_order for clarification
> 
> Thanks for resending this!
> 
> Reviewed-by: Kees Cook <kees@kernel.org>
> 
> Shuah, do you want to take this via kselftest? If not, I can carry it...
> 
> -Kees
> 

Just about to ask you if you want me take it :)

Yes I can take this - I will apply this for Linux 6.12-rc1.

thanks,
-- Shuah