mbox series

[v3,0/2] arm64: Add basic support for LG H815

Message ID 20240727201413.114317-1-alexander.reimelt@posteo.de
Headers show
Series arm64: Add basic support for LG H815 | expand

Message

Alexander Reimelt July 27, 2024, 8:04 p.m. UTC 
Hello,

Changes in v3:
- use 0x0 consistently
- pad to 8 digits
- drop compatible = "framebuffer" because it's unused
- drop chosen

Thanks again for your time.

v2: https://lore.kernel.org/linux-devicetree/20240530135922.23326-1-alexander.reimelt@posteo.de/

Alexander Reimelt (2):
  dt-bindings: arm: qcom: Add LG G4 (h815)
  arm64: dts: qcom: msm8992-lg-h815: Initial support for LG G4 (H815)

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/msm8992-lg-h815.dts  | 231 ++++++++++++++++++
 3 files changed, 233 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-h815.dts

Comments

Petr Vorel July 28, 2024, 3:13 p.m. UTC | #1 
Hi all,

> International variant of the LG G4 from 2015.

Obviously correct.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Alexander, others have added their tags in previous versions. IMHO generally
it'd be worth if you carry others tags in next versions (when nothing changes).

I now see Krzysztof was faster to write this. Thus I put the tags with links:

https://lore.kernel.org/linux-arm-msm/171216461463.4018435.3466905061314737419.robh@kernel.org/
Acked-by: Rob Herring <robh@kernel.org>

https://lore.kernel.org/linux-arm-msm/d596abcd-8374-4a6f-ad98-c5a04416865d@linaro.org/
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Kind regards,
Petr

> Signed-off-by: Alexander Reimelt <alexander.reimelt@posteo.de>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f08e13b61172..f79730d02eb7 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -250,6 +250,7 @@ properties:
>        - items:
>            - enum:
>                - lg,bullhead
> +              - lg,h815
>                - microsoft,talkman
>                - xiaomi,libra
>            - const: qcom,msm8992
Alexander Reimelt July 28, 2024, 6:59 p.m. UTC | #2 
Hello,

> Alexander, others have added their tags in previous versions. IMHO generally
> it'd be worth if you carry others tags in next versions (when nothing
> changes).
I already replied to Krzysztof, but I messed it up and sent it only to him. 
I'm sorry I wasted everyone's time. I didn't fully understand how the system 
behind these tags worked until now. I should have asked earlier, but thanks 
for pointing it out.

Kind regards,
Alexander