mbox series

[for-6.10,0/2] ASoC: cs35l56: Set correct upper volume limit

Message ID 20240722102600.37931-1-rf@opensource.cirrus.com
Headers show
Series ASoC: cs35l56: Set correct upper volume limit | expand

Message

Richard Fitzgerald July 22, 2024, 10:25 a.m. UTC
Patch series to limit the upper range of the CS35L56 volume control to
+12 dB.

These commits were not marked 'Fixes' because they were thought to be only
a cosmetic issue. The user could reduce the volume to a usable value.

But for some complex audio topologies with SOF Audio DSP + CS42L43 +
multiple CS35L56 it has turned out to be not obvious to the user what the
problem actually is and what to do to fix it. As support for these
topologies went into 6.10 we would like this series to be applied to 6.10.

Richard Fitzgerald (2):
  ASoC: cs35l56: Use header defines for Speaker Volume control
    definition
  ASoC: cs35l56: Limit Speaker Volume to +12dB maximum

 include/sound/cs35l56.h    | 2 +-
 sound/soc/codecs/cs35l56.c | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Greg Kroah-Hartman July 23, 2024, 11:37 a.m. UTC | #1
On Mon, Jul 22, 2024 at 11:25:58AM +0100, Richard Fitzgerald wrote:
> Patch series to limit the upper range of the CS35L56 volume control to
> +12 dB.
> 
> These commits were not marked 'Fixes' because they were thought to be only
> a cosmetic issue. The user could reduce the volume to a usable value.
> 
> But for some complex audio topologies with SOF Audio DSP + CS42L43 +
> multiple CS35L56 it has turned out to be not obvious to the user what the
> problem actually is and what to do to fix it. As support for these
> topologies went into 6.10 we would like this series to be applied to 6.10.

Now queued up, thanks.

greg k-h