diff mbox series

[3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

Message ID 20240718200540.955370-3-festevam@gmail.com
State Superseded
Headers show
Series [1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd | expand

Commit Message

Fabio Estevam July 18, 2024, 8:05 p.m. UTC
There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.

There is an LCD controlled via SPI though.

Properly describe it by adding the "elgin,spi-lcd" compatible
string.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi Heiko,

Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:

https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/

If you prefer, I can send a patch on top of his.

Or you can apply this one instead.

 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heiko Stuebner July 19, 2024, 8:02 a.m. UTC | #1
Hi Fabio,

Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
> There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> 
> There is an LCD controlled via SPI though.
> 
> Properly describe it by adding the "elgin,spi-lcd" compatible
> string.
> 
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Heiko,
> 
> Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
> 
> https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> 
> If you prefer, I can send a patch on top of his.

The decision is interesting, one less patch vs. keeping Conor's separate
patch history. Maybe Conor voices his opinion while we're still in the merge
window :-) .


Heiko
> Or you can apply this one instead.
> 
>  arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> index 2d9994379eb2..971bb617e845 100644
> --- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> +++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> @@ -168,8 +168,8 @@ &spi {
>  	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
>  	status = "okay";
>  
> -	dh2228fv: dac@0 {
> -		compatible = "rohm,dh2228fv";
> +	display: display@0 {
> +		compatible = "elgin,spi-lcd";
>  		reg = <0>;
>  		spi-max-frequency = <24000000>;
>  		spi-cpha;
>
Conor Dooley July 19, 2024, 8:30 a.m. UTC | #2
On Fri, Jul 19, 2024 at 10:02:56AM +0200, Heiko Stübner wrote:
> Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
> > There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> > 
> > There is an LCD controlled via SPI though.
> > 
> > Properly describe it by adding the "elgin,spi-lcd" compatible
> > string.
> > 
> > Reported-by: Conor Dooley <conor.dooley@microchip.com>
> > Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Hi Heiko,
> > 
> > Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
> > 
> > https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > 
> > If you prefer, I can send a patch on top of his.
> 
> The decision is interesting, one less patch vs. keeping Conor's separate
> patch history. Maybe Conor voices his opinion while we're still in the merge
> window :-) .

Adding the correct device is an improvement over my patch, I don't see a
reason (other than vanity) for applying both. However, I don't think
that "elgin,spi-lcd" is a suitable compatible as it is far too generic.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@  &spi {
 	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
 	status = "okay";
 
-	dh2228fv: dac@0 {
-		compatible = "rohm,dh2228fv";
+	display: display@0 {
+		compatible = "elgin,spi-lcd";
 		reg = <0>;
 		spi-max-frequency = <24000000>;
 		spi-cpha;