| Message ID | 20240719120853.1924771-2-m.majewski2@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add initial Exynos 850 support to the thermal driver | expand |
On Fri, Jul 19, 2024 at 7:10 AM Mateusz Majewski <m.majewski2@samsung.com> wrote: > > SIMPLE_DEV_PM_OPS is deprecated, as noted next to its definition. > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/thermal/samsung/exynos_tmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 96cffb2c44ba..9b7ca93a72f1 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1150,8 +1150,8 @@ static int exynos_tmu_resume(struct device *dev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(exynos_tmu_pm, > - exynos_tmu_suspend, exynos_tmu_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_tmu_pm, > + exynos_tmu_suspend, exynos_tmu_resume); > #define EXYNOS_TMU_PM (&exynos_tmu_pm) > #else > #define EXYNOS_TMU_PM NULL > -- > 2.45.1 > >
Hi Mateusz, On Fri, 19 Jul 2024 at 17:40, Mateusz Majewski <m.majewski2@samsung.com> wrote: > > SIMPLE_DEV_PM_OPS is deprecated, as noted next to its definition. > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 96cffb2c44ba..9b7ca93a72f1 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1150,8 +1150,8 @@ static int exynos_tmu_resume(struct device *dev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(exynos_tmu_pm, > - exynos_tmu_suspend, exynos_tmu_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_tmu_pm, > + exynos_tmu_suspend, exynos_tmu_resume); > #define EXYNOS_TMU_PM (&exynos_tmu_pm) > #else > #define EXYNOS_TMU_PM NULL You can drop the CONFIG_PM_SLEEP guard and use pm_sleep_ptr macro for exynos_tmu_pm. Thanks -Anand
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 96cffb2c44ba..9b7ca93a72f1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1150,8 +1150,8 @@ static int exynos_tmu_resume(struct device *dev) return 0; } -static SIMPLE_DEV_PM_OPS(exynos_tmu_pm, - exynos_tmu_suspend, exynos_tmu_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_tmu_pm, + exynos_tmu_suspend, exynos_tmu_resume); #define EXYNOS_TMU_PM (&exynos_tmu_pm) #else #define EXYNOS_TMU_PM NULL
SIMPLE_DEV_PM_OPS is deprecated, as noted next to its definition. Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)