diff mbox series

[v3,1/3] dt-bindings: i2c: gpio: Add 'settle-time-us' property

Message ID 20240617120818.81237-2-bastien.curutchet@bootlin.com
State New
Headers show
Series [v3,1/3] dt-bindings: i2c: gpio: Add 'settle-time-us' property | expand

Commit Message

Bastien Curutchet June 17, 2024, 12:08 p.m. UTC
I2C MUXes described by the i2c-gpio-mux sometimes need a significant
amount of time to switch from a bus to another. When a new bus is
selected, the first I2C transfer can fail if it occurs too early. There
is no way to describe this transition delay that has to be waited before
starting the first I2C transfer.

Add a 'settle-time-us' property that indicates the delay to be
respected before doing the first i2c transfer.

Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
---
 Documentation/devicetree/bindings/i2c/i2c-mux-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andi Shyti July 9, 2024, 9:42 p.m. UTC | #1
Hi,

On Mon, Jun 17, 2024 at 02:08:16PM GMT, Bastien Curutchet wrote:
> I2C MUXes described by the i2c-gpio-mux sometimes need a significant
> amount of time to switch from a bus to another. When a new bus is
> selected, the first I2C transfer can fail if it occurs too early. There
> is no way to describe this transition delay that has to be waited before
> starting the first I2C transfer.
> 
> Add a 'settle-time-us' property that indicates the delay to be
> respected before doing the first i2c transfer.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Andi
Peter Rosin July 10, 2024, 8:01 a.m. UTC | #2
2024-06-17 at 14:08, Bastien Curutchet wrote:
> I2C MUXes described by the i2c-gpio-mux sometimes need a significant
> amount of time to switch from a bus to another. When a new bus is
> selected, the first I2C transfer can fail if it occurs too early. There
> is no way to describe this transition delay that has to be waited before
> starting the first I2C transfer.
> 
> Add a 'settle-time-us' property that indicates the delay to be
> respected before doing the first i2c transfer.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter
Wolfram Sang July 12, 2024, 7 a.m. UTC | #3
$subject should be "mux-gpio" instead of just "gpio". It could be mixed
up with the i2c-gpio controller driver otherwise.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.yaml
index f34cc7ad5a00..4a93d1f78f93 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.yaml
@@ -57,6 +57,9 @@  properties:
       last value used.
     $ref: /schemas/types.yaml#/definitions/uint32
 
+  settle-time-us:
+    description: Delay to wait before doing any transfer when a new bus gets selected.
+
 allOf:
   - $ref: i2c-mux.yaml