diff mbox series

[v47,19/19] hw/sd/sdcard: Enable TYPE_EMMC card model

Message ID 20240709152556.52896-20-philmd@linaro.org
State New
Headers show
Series [v47,01/19] hw/sd/sdcard: Basis for eMMC support | expand

Commit Message

Philippe Mathieu-Daudé July 9, 2024, 3:25 p.m. UTC 
Now than the implementation is functional, allow
to instantiate it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/sd/sd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Cédric Le Goater July 9, 2024, 3:42 p.m. UTC | #1 
On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote:
> Now than the implementation is functional, allow
> to instantiate it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

I don't think this is necessary. emmc should be functional once patch 1-15
are merged. The boot part is an extension.

Thanks,

C.



> ---
>   hw/sd/sd.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 6aa83251f7..4a6e9cc035 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2941,7 +2941,6 @@ static const TypeInfo sd_types[] = {
>           .name           = TYPE_EMMC,
>           .parent         = TYPE_SDMMC_COMMON,
>           .class_init     = emmc_class_init,
> -        .abstract       = true, /* FIXME: Remove once model fully functional */
>       },
>   };
>
diff mbox series

Patch

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 6aa83251f7..4a6e9cc035 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2941,7 +2941,6 @@  static const TypeInfo sd_types[] = {
         .name           = TYPE_EMMC,
         .parent         = TYPE_SDMMC_COMMON,
         .class_init     = emmc_class_init,
-        .abstract       = true, /* FIXME: Remove once model fully functional */
     },
 };