| Message ID | 20240703213756.3375978-8-dmitry.torokhov@gmail.com |
|---|---|
| State | Accepted |
| Commit | 735877fde06304ae9d90e17102dc2b139e8d802a |
| Headers | show |
| Series | Simplify event handling logic in input core | expand |
Hi Dmitry, On Wed, Jul 03, 2024 at 02:37:54PM -0700, Dmitry Torokhov wrote: > Now that the input_dev->vals array is always there we can be assured > that input_pass_values() is always called with a non-0 number of > events. Remove the check. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Jeff LaBundy <jeff@labundy.com> > --- > drivers/input/input.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 4e12fa79883e..54c57b267b25 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -115,9 +115,6 @@ static void input_pass_values(struct input_dev *dev, > > lockdep_assert_held(&dev->event_lock); > > - if (!count) > - return; > - > rcu_read_lock(); > > handle = rcu_dereference(dev->grab); > -- > 2.45.2.803.g4e1b14247a-goog > Kind regards, Jeff LaBundy
diff --git a/drivers/input/input.c b/drivers/input/input.c index 4e12fa79883e..54c57b267b25 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -115,9 +115,6 @@ static void input_pass_values(struct input_dev *dev, lockdep_assert_held(&dev->event_lock); - if (!count) - return; - rcu_read_lock(); handle = rcu_dereference(dev->grab);
Now that the input_dev->vals array is always there we can be assured that input_pass_values() is always called with a non-0 number of events. Remove the check. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/input.c | 3 --- 1 file changed, 3 deletions(-)