diff mbox series

[BlueZ] policy: Fix AutoEnable default when main.conf doesn't exist

Message ID 20240629201632.1356542-1-me@arnavion.dev
State New
Headers show
Series [BlueZ] policy: Fix AutoEnable default when main.conf doesn't exist | expand

Commit Message

Arnav Singh June 29, 2024, 8:16 p.m. UTC 
180cf09933b2d8eb03972c8638063429fe5fece5 changed the default to true
if the config file did not set it, but it still remained false if
the config file did not exist at all. This change fixes that.

Fixes: https://github.com/bluez/bluez/issues/886
---
 plugins/policy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com June 29, 2024, 10:03 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866862

---Test result---

Test Summary:
CheckPatch                    PASS      0.46 seconds
GitLint                       PASS      0.69 seconds
BuildEll                      PASS      25.27 seconds
BluezMake                     PASS      1642.43 seconds
MakeCheck                     PASS      13.64 seconds
MakeDistcheck                 PASS      192.64 seconds
CheckValgrind                 PASS      251.68 seconds
CheckSmatch                   PASS      354.58 seconds
bluezmakeextell               PASS      119.82 seconds
IncrementalBuild              PASS      1548.90 seconds
ScanBuild                     PASS      994.67 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org July 1, 2024, 2:20 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat, 29 Jun 2024 13:16:32 -0700 you wrote:
> 180cf09933b2d8eb03972c8638063429fe5fece5 changed the default to true
> if the config file did not set it, but it still remained false if
> the config file did not exist at all. This change fixes that.
> 
> Fixes: https://github.com/bluez/bluez/issues/886
> ---
>  plugins/policy.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] policy: Fix AutoEnable default when main.conf doesn't exist
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f40e88d0bd5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/plugins/policy.c b/plugins/policy.c
index 0bbdbfc88..9a449da61 100644
--- a/plugins/policy.c
+++ b/plugins/policy.c
@@ -74,6 +74,7 @@  static GSList *reconnects = NULL;
 static unsigned int service_id = 0;
 static GSList *devices = NULL;
 
+static const bool default_auto_enable = true;
 static bool auto_enable = false;
 
 struct policy_data {
@@ -858,6 +859,7 @@  static int policy_init(void)
 						sizeof(*reconnect_intervals);
 		reconnect_intervals = util_memdup(default_intervals,
 						sizeof(default_intervals));
+		auto_enable = default_auto_enable;
 		goto done;
 	}
 
@@ -895,7 +897,7 @@  static int policy_init(void)
 								&gerr);
 	if (gerr) {
 		g_clear_error(&gerr);
-		auto_enable = true;
+		auto_enable = default_auto_enable;
 	}
 
 	resume_delay = g_key_file_get_integer(