| Message ID | 20240703085907.66775-2-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/sd/sdcard: Cleanups before adding eMMC support | expand |
On Wed, 03 Jul 2024 11:59, Philippe Mathieu-Daudé <philmd@linaro.org> wrote: >Commit c3287c0f70 ("hw/sd: Introduce a "sd-card" SPI variant >model") removed the 'spi' property. Remove the comment left >over. > >Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >--- > hw/sd/sd.c | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/hw/sd/sd.c b/hw/sd/sd.c >index b158402704..53767beaf8 100644 >--- a/hw/sd/sd.c >+++ b/hw/sd/sd.c >@@ -2473,10 +2473,6 @@ static Property sd_properties[] = { > DEFINE_PROP_UINT8("spec_version", SDState, > spec_version, SD_PHY_SPECv2_00_VERS), > DEFINE_PROP_DRIVE("drive", SDState, blk), >- /* We do not model the chip select pin, so allow the board to select >- * whether card should be in SSI or MMC/SD mode. It is also up to the >- * board to ensure that ssi transfers only occur when the chip select >- * is asserted. */ > DEFINE_PROP_END_OF_LIST() > }; > >-- >2.41.0 > > Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
diff --git a/hw/sd/sd.c b/hw/sd/sd.c index b158402704..53767beaf8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2473,10 +2473,6 @@ static Property sd_properties[] = { DEFINE_PROP_UINT8("spec_version", SDState, spec_version, SD_PHY_SPECv2_00_VERS), DEFINE_PROP_DRIVE("drive", SDState, blk), - /* We do not model the chip select pin, so allow the board to select - * whether card should be in SSI or MMC/SD mode. It is also up to the - * board to ensure that ssi transfers only occur when the chip select - * is asserted. */ DEFINE_PROP_END_OF_LIST() };
Commit c3287c0f70 ("hw/sd: Introduce a "sd-card" SPI variant model") removed the 'spi' property. Remove the comment left over. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/sd/sd.c | 4 ---- 1 file changed, 4 deletions(-)