diff mbox series

[2/4] hw/sd/sdhci: Log non-sequencial access as GUEST_ERROR

Message ID 20240702140842.54242-3-philmd@linaro.org
State Superseded
Headers show
Series qtest/npcm7xx_sdhci: Use card-provided address (RCA) | expand

Commit Message

Philippe Mathieu-Daudé July 2, 2024, 2:08 p.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/sd/sdhci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Cédric Le Goater July 2, 2024, 2:16 p.m. UTC | #1 
On 7/2/24 4:08 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/sd/sdhci.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 27673e1c70..d02c3e3963 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -983,8 +983,9 @@ static inline bool
>   sdhci_buff_access_is_sequential(SDHCIState *s, unsigned byte_num)
>   {
>       if ((s->data_count & 0x3) != byte_num) {
> -        trace_sdhci_error("Non-sequential access to Buffer Data Port register"
> -                          "is prohibited\n");
> +        qemu_log_mask(LOG_GUEST_ERROR,
> +                      "SDHCI: Non-sequential access to Buffer Data Port"
> +                      " register is prohibited\n");
>           return false;
>       }
>       return true;
diff mbox series

Patch

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 27673e1c70..d02c3e3963 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -983,8 +983,9 @@  static inline bool
 sdhci_buff_access_is_sequential(SDHCIState *s, unsigned byte_num)
 {
     if ((s->data_count & 0x3) != byte_num) {
-        trace_sdhci_error("Non-sequential access to Buffer Data Port register"
-                          "is prohibited\n");
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "SDHCI: Non-sequential access to Buffer Data Port"
+                      " register is prohibited\n");
         return false;
     }
     return true;