mbox series

[00/22] dt-bindings: thermal: few cleanups

Message ID 20240614-dt-bindings-thermal-allof-v1-0-30b25a6ae24e@linaro.org
Headers show
Series dt-bindings: thermal: few cleanups | expand

Message

Krzysztof Kozlowski June 14, 2024, 9:45 a.m. UTC 
Hi,

Few cleanups witout practical impact, except maybe the Amlogic schema
(bringing required cells).

Best regards,
Krzysztof

---
Krzysztof Kozlowski (22):
      dt-bindings: thermal: samsung,exynos: specify cells
      dt-bindings: thermal: amlogic: reference thermal-sensor schema
      dt-bindings: thermal: allwinner,sun8i-a83t-ths: reference thermal-sensor schema
      dt-bindings: thermal: brcm,avs-ro: reference thermal-sensor schema
      dt-bindings: thermal: generic-adc: reference thermal-sensor schema
      dt-bindings: thermal: imx8mm: reference thermal-sensor schema
      dt-bindings: thermal: nvidia,tegra186-bpmp: reference thermal-sensor schema
      dt-bindings: thermal: nvidia,tegra30-tsensor: reference thermal-sensor schema
      dt-bindings: thermal: qcom-spmi-adc-tm-hc: reference thermal-sensor schema
      dt-bindings: thermal: qcom-spmi-adc-tm5: reference thermal-sensor schema
      dt-bindings: thermal: qcom-tsens: reference thermal-sensor schema
      dt-bindings: thermal: qoriq: reference thermal-sensor schema
      dt-bindings: thermal: rcar-gen3: reference thermal-sensor schema
      dt-bindings: thermal: rockchip: reference thermal-sensor schema
      dt-bindings: thermal: rzg2l: reference thermal-sensor schema
      dt-bindings: thermal: socionext,uniphier: reference thermal-sensor schema
      dt-bindings: thermal: sprd: reference thermal-sensor schema
      dt-bindings: thermal: st,stm32: reference thermal-sensor schema
      dt-bindings: thermal: ti,am654: reference thermal-sensor schema
      dt-bindings: thermal: ti,j72xx: reference thermal-sensor schema
      dt-bindings: thermal: simplify few bindings
      dt-bindings: thermal: cleanup examples indentation

 .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml |  6 +-
 .../bindings/thermal/amlogic,thermal.yaml          | 22 ++---
 .../bindings/thermal/brcm,avs-ro-thermal.yaml      | 22 ++---
 .../devicetree/bindings/thermal/brcm,avs-tmon.yaml | 17 ++--
 .../bindings/thermal/brcm,bcm2835-thermal.yaml     |  1 -
 .../bindings/thermal/fsl,scu-thermal.yaml          |  1 -
 .../bindings/thermal/generic-adc-thermal.yaml      |  5 +-
 .../bindings/thermal/imx8mm-thermal.yaml           |  5 +-
 .../bindings/thermal/loongson,ls2k-thermal.yaml    |  1 -
 .../bindings/thermal/mediatek,lvts-thermal.yaml    |  1 -
 .../bindings/thermal/nvidia,tegra124-soctherm.yaml |  1 -
 .../thermal/nvidia,tegra186-bpmp-thermal.yaml      | 12 +--
 .../bindings/thermal/nvidia,tegra30-tsensor.yaml   |  9 +-
 .../bindings/thermal/qcom,spmi-temp-alarm.yaml     |  1 -
 .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml      |  8 +-
 .../bindings/thermal/qcom-spmi-adc-tm5.yaml        |  8 +-
 .../devicetree/bindings/thermal/qcom-tsens.yaml    | 96 ++++++++++------------
 .../devicetree/bindings/thermal/qoriq-thermal.yaml |  5 +-
 .../bindings/thermal/rcar-gen3-thermal.yaml        | 69 ++++++++--------
 .../devicetree/bindings/thermal/rcar-thermal.yaml  | 60 +++++++-------
 .../bindings/thermal/rockchip-thermal.yaml         |  5 +-
 .../devicetree/bindings/thermal/rzg2l-thermal.yaml | 41 ++++-----
 .../bindings/thermal/samsung,exynos-thermal.yaml   |  3 +-
 .../thermal/socionext,uniphier-thermal.yaml        |  5 +-
 .../devicetree/bindings/thermal/sprd-thermal.yaml  | 47 +++++------
 .../bindings/thermal/st,stm32-thermal.yaml         |  5 +-
 .../bindings/thermal/ti,am654-thermal.yaml         | 15 ++--
 .../bindings/thermal/ti,j72xx-thermal.yaml         |  5 +-
 28 files changed, 230 insertions(+), 246 deletions(-)
---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240614-dt-bindings-thermal-allof-401c50e61ef2

Best regards,

Comments

Biju Das June 14, 2024, 10:22 a.m. UTC | #1 
Hi Krzysztof Kozlowski,

Thanks for the patch.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, June 14, 2024 10:46 AM
> Subject: [PATCH 15/22] dt-bindings: thermal: rzg2l: reference thermal-sensor schema
> 
> Device is a thermal sensor and it requires '#thermal-sensor-cells', so reference the thermal-
> sensor.yaml to simplify it and bring the common definition of '#thermal-sensor-cells' property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju
> ---
>  Documentation/devicetree/bindings/thermal/rzg2l-thermal.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/rzg2l-thermal.yaml
> b/Documentation/devicetree/bindings/thermal/rzg2l-thermal.yaml
> index 03f4b926e53c..2f96c0fe0f75 100644
> --- a/Documentation/devicetree/bindings/thermal/rzg2l-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rzg2l-thermal.yaml
> @@ -13,6 +13,8 @@ description:
>  maintainers:
>    - Biju Das <biju.das.jz@bp.renesas.com>
> 
> +$ref: thermal-sensor.yaml#
> +
>  properties:
>    compatible:
>      items:
> @@ -43,9 +45,8 @@ required:
>    - clocks
>    - power-domains
>    - resets
> -  - "#thermal-sensor-cells"
> 
> -additionalProperties: false
> +unevaluatedProperties: false
> 
>  examples:
>    - |
> 
> --
> 2.43.0
Dmitry Baryshkov June 14, 2024, 10:35 a.m. UTC | #2 
On Fri, Jun 14, 2024 at 11:46:08AM GMT, Krzysztof Kozlowski wrote:
> Device is a thermal sensor and it requires '#thermal-sensor-cells', so
> reference the thermal-sensor.yaml to simplify it and bring the
> common definition of '#thermal-sensor-cells' property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml          | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Dmitry Baryshkov June 14, 2024, 10:35 a.m. UTC | #3 
On Fri, Jun 14, 2024 at 11:46:10AM GMT, Krzysztof Kozlowski wrote:
> Device is a thermal sensor and it requires '#thermal-sensor-cells', so
> reference the thermal-sensor.yaml to simplify it and bring the
> common definition of '#thermal-sensor-cells' property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Baolin Wang June 14, 2024, 11:25 a.m. UTC | #4 
On 2024/6/14 17:46, Krzysztof Kozlowski wrote:
> Device is a thermal sensor and it requires '#thermal-sensor-cells', so
> reference the thermal-sensor.yaml to simplify it and bring the
> common definition of '#thermal-sensor-cells' property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   Documentation/devicetree/bindings/thermal/sprd-thermal.yaml | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/sprd-thermal.yaml b/Documentation/devicetree/bindings/thermal/sprd-thermal.yaml
> index 76aaa004c8ac..f65076fc68f9 100644
> --- a/Documentation/devicetree/bindings/thermal/sprd-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/sprd-thermal.yaml
> @@ -11,6 +11,8 @@ maintainers:
>     - Baolin Wang <baolin.wang7@gmail.com>
>     - Chunyan Zhang <zhang.lyra@gmail.com>
>   
> +$ref: thermal-sensor.yaml#
> +
>   properties:
>     compatible:
>       const: sprd,ums512-thermal
> @@ -77,11 +79,10 @@ required:
>     - clock-names
>     - nvmem-cells
>     - nvmem-cell-names
> -  - "#thermal-sensor-cells"
>     - "#address-cells"
>     - "#size-cells"
>   
> -additionalProperties: false
> +unevaluatedProperties: false
>   
>   examples:
>     - |
>
Alim Akhtar June 14, 2024, 2:29 p.m. UTC | #5 
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, June 14, 2024 3:16 PM
> To: Daniel Lezcano <daniel.lezcano@linaro.org
.stormreply.com;
> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
> 
> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
> make '#thermal-sensor-cells' fixed at 0.
> 
This is not entirely true, there are SoCs which have multiple temp sensors.
It is true that currently only one sensor support is added though.

So we can leave this as is or you suggest to make it to support only one sensor
(to match the current DT support), and later (in near future) change it again to
match what HW actually support?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> index 1344df708e2d..29a08b0729ee 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.y
> +++ aml
> @@ -61,7 +61,8 @@ properties:
>            TRIMINFO at 0x10068000 contains data for TMU channel 2
>      minItems: 1
> 
> -  '#thermal-sensor-cells': true
> +  '#thermal-sensor-cells':
> +    const: 0
> 
>    vtmu-supply:
>      description: The regulator node supplying voltage to TMU.
> 
> --
> 2.43.0
Krzysztof Kozlowski June 15, 2024, 9:39 a.m. UTC | #6 
On 14/06/2024 16:29, Alim Akhtar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, June 14, 2024 3:16 PM
>> To: Daniel Lezcano <daniel.lezcano@linaro.org
> .stormreply.com;
>> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
>>
>> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
>> make '#thermal-sensor-cells' fixed at 0.
>>
> This is not entirely true, there are SoCs which have multiple temp sensors.
> It is true that currently only one sensor support is added though.

All supported by mainline. Others do not exist now :)

> 
> So we can leave this as is or you suggest to make it to support only one sensor
> (to match the current DT support), and later (in near future) change it again to
> match what HW actually support?

Yes, different devices can have different value (and bindings).
Best regards,
Krzysztof
Conor Dooley June 16, 2024, 6:49 p.m. UTC | #7 
On Fri, Jun 14, 2024 at 11:45:59AM +0200, Krzysztof Kozlowski wrote:
> 
> Few cleanups witout practical impact, except maybe the Amlogic schema
> (bringing required cells).

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Alim Akhtar June 24, 2024, 4:06 a.m. UTC | #8 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Saturday, June 15, 2024 3:09 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; 'Krzysztof Kozlowski'
> <krzysztof.kozlowski@linaro.org>; 'Daniel Lezcano'
[snip]
> On 14/06/2024 16:29, Alim Akhtar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Friday, June 14, 2024 3:16 PM
> >> To: Daniel Lezcano <daniel.lezcano@linaro.org
> > .stormreply.com;
> >> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify
> >> cells
> >>
> >> All Samsung Exynos SoCs Thermal Management Units have only one
> >> sensor, so make '#thermal-sensor-cells' fixed at 0.
> >>
> > This is not entirely true, there are SoCs which have multiple temp sensors.
> > It is true that currently only one sensor support is added though.
> 
> All supported by mainline. Others do not exist now :)
> 
> >
> > So we can leave this as is or you suggest to make it to support only
> > one sensor (to match the current DT support), and later (in near
> > future) change it again to match what HW actually support?
> 
> Yes, different devices can have different value (and bindings).
Ok, this is fine for now.

> Best regards,
> Krzysztof