| Message ID | 20240620132511.4291-8-elinor.montmasson@savoirfairelinux.com |
|---|---|
| State | New |
| Headers | show |
| Series | [PATCHv5,1/9] ASoC: fsl-asoc-card: set priv->pdev before using it | expand |
On 20/06/2024 15:25, Elinor Montmasson wrote: > imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore > removed. So what happens with all existing users (e.g. DTS)? They become invalid/not supported? After quick look, I do not see backwards compatibility in the driver and above commit msg tells me nothing about ABI break. Best regards, Krzysztof
From: "Krzysztof Kozlowski" <krzk@kernel.org> Sent: Sunday, 23 June, 2024 13:09:33 > On 20/06/2024 15:25, Elinor Montmasson wrote: >> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore >> removed. > > So what happens with all existing users (e.g. DTS)? They become > invalid/not supported? Next commits, 8/9 and 9/9, update all DTS files that currently use the "fsl,imx-audio-spdif" compatible. >From the users point of view, currently configured spdif audio cards will behave just the same. > After quick look, I do not see backwards compatibility in the driver and > above commit msg tells me nothing about ABI break. For the next version I will state in this commit message the upcoming modifications to DTS and compatibility, why it will be done, and that support for existing DTS is not dropped. Previous `imx-spdif` driver used the dummy codec instead of using declared spdif codecs. It was discussed in previous version of this contribution that using the dummy codec isn't good practice. So one to one backward compatibility isn't really possible. Best regards, Elinor Montmasson
On 24/06/2024 10:51, Elinor Montmasson wrote: > From: "Krzysztof Kozlowski" <krzk@kernel.org> > Sent: Sunday, 23 June, 2024 13:09:33 >> On 20/06/2024 15:25, Elinor Montmasson wrote: >>> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore >>> removed. >> >> So what happens with all existing users (e.g. DTS)? They become >> invalid/not supported? > > > Next commits, 8/9 and 9/9, update all DTS files that currently use > the "fsl,imx-audio-spdif" compatible. You mean in-tree. I mean all users, in- and out-of-tree. Other projects. > From the users point of view, currently configured spdif audio cards > will behave just the same. > > >> After quick look, I do not see backwards compatibility in the driver and >> above commit msg tells me nothing about ABI break. > > > For the next version I will state in this commit message the upcoming modifications to DTS > and compatibility, why it will be done, and that support for existing DTS is not dropped. > > Previous `imx-spdif` driver used the dummy codec instead of > using declared spdif codecs. It was discussed in previous version of this contribution > that using the dummy codec isn't good practice. So one to one backward compatibility > isn't really possible. Heh, that's not good. This is improvement, cleanup. While it is important and useful, it should also not break existing users. Best regards, Krzysztof
From: "Krzysztof Kozlowski" <krzk@kernel.org> Sent: Monday, 24 June, 2024 10:55:31 > On 24/06/2024 10:51, Elinor Montmasson wrote: >> From: "Krzysztof Kozlowski" <krzk@kernel.org> >> Sent: Sunday, 23 June, 2024 13:09:33 >>> On 20/06/2024 15:25, Elinor Montmasson wrote: >>>> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore >>>> removed. >>> >>> So what happens with all existing users (e.g. DTS)? They become >>> invalid/not supported? >> >> >> Next commits, 8/9 and 9/9, update all DTS files that currently use >> the "fsl,imx-audio-spdif" compatible. > > You mean in-tree. I mean all users, in- and out-of-tree. Other projects. Oh you're right >> From the users point of view, currently configured spdif audio cards >> will behave just the same. >> >> >>> After quick look, I do not see backwards compatibility in the driver and >>> above commit msg tells me nothing about ABI break. >> >> >> For the next version I will state in this commit message the upcoming >> modifications to DTS >> and compatibility, why it will be done, and that support for existing DTS is not >> dropped. >> >> Previous `imx-spdif` driver used the dummy codec instead of >> using declared spdif codecs. It was discussed in previous version of this >> contribution >> that using the dummy codec isn't good practice. So one to one backward >> compatibility >> isn't really possible. > > Heh, that's not good. This is improvement, cleanup. While it is > important and useful, it should also not break existing users. Should I introduce then the use of the dummy codec in `fsl-asoc-card` to assure backward compatibility at least for a time ? With maybe warning messages in code to indicate that spdif codecs drivers should be declared and used in the future ? Best regards, Elinor Montmasson
On 24/06/2024 11:18, Elinor Montmasson wrote: >>> >>> Previous `imx-spdif` driver used the dummy codec instead of >>> using declared spdif codecs. It was discussed in previous version of this >>> contribution >>> that using the dummy codec isn't good practice. So one to one backward >>> compatibility >>> isn't really possible. >> >> Heh, that's not good. This is improvement, cleanup. While it is >> important and useful, it should also not break existing users. > > > Should I introduce then the use of the dummy codec in `fsl-asoc-card` to > assure backward compatibility at least for a time ? > With maybe warning messages in code to indicate that spdif codecs drivers > should be declared and used in the future ? > If it is doable (reasonable code), then yes, please keep backwards compatibility with old DTS. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml deleted file mode 100644 index 5fc543d02ecb..000000000000 --- a/Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml +++ /dev/null @@ -1,66 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/sound/fsl,imx-audio-spdif.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Freescale i.MX audio complex with S/PDIF transceiver - -maintainers: - - Shengjiu Wang <shengjiu.wang@nxp.com> - -properties: - compatible: - oneOf: - - items: - - enum: - - fsl,imx-sabreauto-spdif - - fsl,imx6sx-sdb-spdif - - const: fsl,imx-audio-spdif - - enum: - - fsl,imx-audio-spdif - - model: - $ref: /schemas/types.yaml#/definitions/string - description: User specified audio sound card name - - spdif-controller: - $ref: /schemas/types.yaml#/definitions/phandle - description: The phandle of the i.MX S/PDIF controller - - spdif-out: - type: boolean - description: - If present, the transmitting function of S/PDIF will be enabled, - indicating there's a physical S/PDIF out connector or jack on the - board or it's connecting to some other IP block, such as an HDMI - encoder or display-controller. - - spdif-in: - type: boolean - description: - If present, the receiving function of S/PDIF will be enabled, - indicating there is a physical S/PDIF in connector/jack on the board. - -required: - - compatible - - model - - spdif-controller - -anyOf: - - required: - - spdif-in - - required: - - spdif-out - -additionalProperties: false - -examples: - - | - sound-spdif { - compatible = "fsl,imx-audio-spdif"; - model = "imx-spdif"; - spdif-controller = <&spdif>; - spdif-out; - spdif-in; - };
imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore removed. Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com> --- .../bindings/sound/fsl,imx-audio-spdif.yaml | 66 ------------------- 1 file changed, 66 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml