| Message ID | 20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com |
|---|---|
| Headers | show |
| Series | media: qcom: camss: Add sc7180 support | expand |
On 21/06/2024 11:40, George Chan via B4 Relay wrote: > From: George Chan <gchan9527@gmail.com> > > Adds a CAMSS SoC identifier for the SC7180. > > Signed-off-by: George Chan <gchan9527@gmail.com> > --- > drivers/media/platform/qcom/camss/camss.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h > index ac15fe23a702..5e750c481b74 100644 > --- a/drivers/media/platform/qcom/camss/camss.h > +++ b/drivers/media/platform/qcom/camss/camss.h > @@ -76,6 +76,7 @@ enum camss_version { > CAMSS_8x96, > CAMSS_660, > CAMSS_845, > + CAMSS_7180, This patch on its own makes no sense. Squash it with patch adding 7180. Best regards, Krzysztof
On 21/06/2024 11:03, Krzysztof Kozlowski wrote: > On 21/06/2024 11:40, George Chan via B4 Relay wrote: >> From: George Chan <gchan9527@gmail.com> >> >> Adds a CAMSS SoC identifier for the SC7180. >> >> Signed-off-by: George Chan <gchan9527@gmail.com> >> --- >> drivers/media/platform/qcom/camss/camss.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >> index ac15fe23a702..5e750c481b74 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -76,6 +76,7 @@ enum camss_version { >> CAMSS_8x96, >> CAMSS_660, >> CAMSS_845, >> + CAMSS_7180, > > This patch on its own makes no sense. Squash it with patch adding 7180. > > Best regards, > Krzysztof > Agreed you can put it into the PHY init sequence in patch #3 --- bod
On 21.06.2024 11:40 AM, George Chan via B4 Relay wrote: > From: George Chan <gchan9527@gmail.com> > > This commit describes the hardware layout for the sc7180 for the > following hardware blocks: > > - 2 x VFE > - 1 x VFE Lite > - 2 x CSID > - 1 x CSID Lite > - 4 x CSI PHY > > Signed-off-by: George Chan <gchan9527@gmail.com> > --- [...] > if (ret) { > - dev_err(dev, "clock enable failed: %d\n", ret); > + dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret); This is a good change, but should be separate Generally this looks quite in line with [1], although I wasn't able to find the matching clock rates Konrad [1] https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/UC.UM.1.0.r1-02500-sa8155.0/arch/arm64/boot/dts/qcom/atoll-camera.dtsi
On Sat, Jun 22, 2024 at 7:18 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > although I wasn't able to find > the matching clock rates The clk rate is in the camcc clk driver, isn't it? ;-)
On 23/06/2024 22:48, george chan wrote: > On Sat, Jun 22, 2024 at 7:18 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> although I wasn't able to find >> the matching clock rates > The clk rate is in the camcc clk driver, isn't it? ;-) > Yes but what we are saying here is you should have two patches. One patch to add the resources and a separate patch to add extended error messaging. --- bod
On Mon, Jun 24, 2024 at 6:14 AM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > Yes but what we are saying here is you should have two patches. One > patch to add the resources and a separate patch to add extended error > messaging. Sure, v2 is available with split patches for sure.
SM7125 is the SoC found in the Xiaomi Redmi Note 9 Pro(joyeuse) cellphone. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces. Since SM7125 is a low-speed variant of SC7180, SC7180 testers please take a look and have a test as well. sc7180 provides - 2 x VFE - 1 x VFE Lite - 2 x CSID - 1 x CSID Lite - 4 x CSI PHY The sc7180-camss binding should be comaptible with sdm845 yaml. I've copied a new yaml from sdm845-camss.yaml, strip all _src clk and leave original maintainer. If this is not desirable then i can add binding to existing sdm845 yaml instead. In addition, a bootable tree of sm7125/joyeuse is availble at: https://github.com/99degree/linux/tree/camss Signed-off-by: George Chan <gchan9527@gmail.com> --- George Chan (6): media: dt-bindings: media: camss: Add qcom,sc7180-camss binding media: qcom: camss: Add CAMSS_SC7180 enum media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init media: qcom: camss: Add sc7180 support media: qcom: camss: Add sc7180 resources [RFT]arm64: dts: qcom: sc7180: Add support for camss subsys .../bindings/media/qcom,sc7180-camss.yaml | 324 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 134 +++++++++ .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 120 ++++++++ drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-vfe.c | 3 + drivers/media/platform/qcom/camss/camss-video.c | 1 + drivers/media/platform/qcom/camss/camss.c | 218 +++++++++++++- drivers/media/platform/qcom/camss/camss.h | 1 + 8 files changed, 801 insertions(+), 1 deletion(-) --- base-commit: 2102cb0d050d34d50b9642a3a50861787527e922 change-id: 20240621-b4-sc7180-camss-cddc6b60a9b4 Best regards,