| Message ID | 1718009524-5579-1-git-send-email-quic_vjakkam@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: cfg80211: fix per-STA profile BSS entry issues | expand |
On Mon, 2024-06-10 at 14:22 +0530, Veerendranath Jakkam wrote: > This patch set contains bugfixes and cleanups related to per-STA > profile BSS entries. > It also has RCU bugs (per warnings in the hwsim tests). johannes
On 6/12/2024 4:36 PM, Johannes Berg wrote: > On Mon, 2024-06-10 at 14:22 +0530, Veerendranath Jakkam wrote: >> This patch set contains bugfixes and cleanups related to per-STA >> profile BSS entries. >> > It also has RCU bugs (per warnings in the hwsim tests). > > johannes Thanks for reviewing the patches. I was able to run most of the hwsim tests except few tests (around 20) which are failing due to other reasons which are not relevant to the changes I submitted. But I didn't observe any RCU warnings in my hwsim setup. Not sure if it is due to difference in kernel .config between our setups. I enabled below kernel config additionally to find out RCU warnings but with no luck. It would be very help for me if you can share kernel ".config" from your hwsim setup. CONFIG_RCU_TRACE=y - veeru
On Tue, 2024-08-13 at 10:19 +0530, Veerendranath Jakkam wrote: > > But I didn't observe any RCU warnings in my hwsim setup. Not sure if it > is due to difference in kernel .config between our setups. > > I enabled below kernel config additionally to find out RCU warnings but > with no luck. It would be very help for me if you can share kernel > ".config" from your hwsim setup. > > CONFIG_RCU_TRACE=y > You want CONFIG_PROVE_RCU=y/CONFIG_PROVE_LOCKING=y I think? I don't think my config as is would be all that useful since I have UML patches too. johanness
On 8/19/2024 5:57 PM, Johannes Berg wrote: > On Tue, 2024-08-13 at 10:19 +0530, Veerendranath Jakkam wrote: > > You want CONFIG_PROVE_RCU=y/CONFIG_PROVE_LOCKING=y I think? I don't > think my config as is would be all that useful since I have UML patches > too. > > johanness Thanks a lot for the inputs. It helped me to identify the issue. I submitted the fix for RCU warning with below patch - https://lore.kernel.org/linux-wireless/20240904015520.3571295-1-quic_vjakkam@quicinc.com/ Also, I submitted v2 for this patch set after some code changes. The above RCU warning not applicable to v2 patch set of this series hence I sent the RCU bug fix as separate fix.
This patch set contains bugfixes and cleanups related to per-STA profile BSS entries. Veerendranath Jakkam (4): wifi: cfg80211: make BSS source types public wifi: cfg80211: skip indicating signal for per-STA profile BSSs wifi: cfg80211: skip overriding direct/MBSSID BSS with per-STA profile BSS wifi: cfg80211: make sure to process all per-STA profiles net/wireless/core.h | 8 ++++++++ net/wireless/nl80211.c | 26 +++++++++++++++----------- net/wireless/scan.c | 14 ++++++++------ 3 files changed, 31 insertions(+), 17 deletions(-) base-commit: a46300b1b09ba260c2c2b00f06f6e34482a8ec01