| Message ID | cover.1718199918.git.geert+renesas@glider.be |
|---|---|
| Headers | show |
| Series | drm/panic: Fixes and graphical logo | expand |
On 12/06/2024 15:54, Geert Uytterhoeven wrote: > Hi all, > > If drm/panic is enabled, a user-friendly message is shown on screen when > a kernel panic occurs, together with an ASCII art penguin logo. > Of course we can do better ;-) > Hence this patch series extends drm/panic to draw the monochrome > graphical boot logo, when available, preceded by the customary fix. Thanks for your patch. I've tested it, and it works great. You need to rebase your series on top of drm-misc-next, because it conflicts with a series I pushed last week: https://patchwork.freedesktop.org/series/134286/ This rebase should simplify the draw_logo_mono() function. > > This has been tested with rcar-du. > > Thanks for your comments! > > Geert Uytterhoeven (3): > drm/panic: Fix off-by-one logo size checks > drm/panic: Rename logo to logo_ascii > drm/panic: Add support for drawing a monochrome graphical logo > > drivers/gpu/drm/drm_panic.c | 81 +++++++++++++++++++++++++++++++++---- > drivers/video/logo/Kconfig | 2 + > 2 files changed, 75 insertions(+), 8 deletions(-) >
Hi Jocelyn, On Thu, Jun 13, 2024 at 10:38 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: > On 12/06/2024 15:54, Geert Uytterhoeven wrote: > > If drm/panic is enabled, a user-friendly message is shown on screen when > > a kernel panic occurs, together with an ASCII art penguin logo. > > Of course we can do better ;-) > > Hence this patch series extends drm/panic to draw the monochrome > > graphical boot logo, when available, preceded by the customary fix. > > Thanks for your patch. > > I've tested it, and it works great. Thank you! > You need to rebase your series on top of drm-misc-next, because it > conflicts with a series I pushed last week: > https://patchwork.freedesktop.org/series/134286/ I had seen that you said you had pushed this to drm-misc-next[1] before I posted my series, but couldn't find the actual commits in drm-misc/for-linux-next, which is still at commit dfc1209ed5a3861c ("arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations", so I assumed you just forgot to push? However, the latest pull request[2] does include them, while linux-next does not. Has the drm-misc git repo moved? Thanks! [1] https://lore.kernel.org/all/3649ff15-df2b-49ba-920f-c418355d79b5@redhat.com/ [2] "[PULL] drm-misc-next" https://lore.kernel.org/all/20240613-cicada-of-infinite-unity-0955ca@houat/ Gr{oetje,eeting}s, Geert
On 13/06/2024 11:32, Geert Uytterhoeven wrote: > Hi Jocelyn, > > On Thu, Jun 13, 2024 at 10:38 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: >> On 12/06/2024 15:54, Geert Uytterhoeven wrote: >>> If drm/panic is enabled, a user-friendly message is shown on screen when >>> a kernel panic occurs, together with an ASCII art penguin logo. >>> Of course we can do better ;-) >>> Hence this patch series extends drm/panic to draw the monochrome >>> graphical boot logo, when available, preceded by the customary fix. >> >> Thanks for your patch. >> >> I've tested it, and it works great. > > Thank you! > >> You need to rebase your series on top of drm-misc-next, because it >> conflicts with a series I pushed last week: >> https://patchwork.freedesktop.org/series/134286/ > > I had seen that you said you had pushed this to drm-misc-next[1] > before I posted my series, but couldn't find the actual commits in > drm-misc/for-linux-next, which is still at commit dfc1209ed5a3861c > ("arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations", > so I assumed you just forgot to push? > However, the latest pull request[2] does include them, while linux-next > does not. > > Has the drm-misc git repo moved? It moved to gitlab recently, the new url is git@gitlab.freedesktop.org:drm/misc/kernel.git and the drm_panic kmsg screen commit is there: https://gitlab.freedesktop.org/drm/misc/kernel/-/commits/drm-misc-next?ref_type=heads > > Thanks! > > [1] https://lore.kernel.org/all/3649ff15-df2b-49ba-920f-c418355d79b5@redhat.com/ > [2] "[PULL] drm-misc-next" > https://lore.kernel.org/all/20240613-cicada-of-infinite-unity-0955ca@houat/ > > Gr{oetje,eeting}s, > > Geert >
Hi Jocelyn, CC sfr On Thu, Jun 13, 2024 at 11:41 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: > On 13/06/2024 11:32, Geert Uytterhoeven wrote: > > On Thu, Jun 13, 2024 at 10:38 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: > >> On 12/06/2024 15:54, Geert Uytterhoeven wrote: > >>> If drm/panic is enabled, a user-friendly message is shown on screen when > >>> a kernel panic occurs, together with an ASCII art penguin logo. > >>> Of course we can do better ;-) > >>> Hence this patch series extends drm/panic to draw the monochrome > >>> graphical boot logo, when available, preceded by the customary fix. > >> > >> Thanks for your patch. > >> > >> I've tested it, and it works great. > > > > Thank you! > > > >> You need to rebase your series on top of drm-misc-next, because it > >> conflicts with a series I pushed last week: > >> https://patchwork.freedesktop.org/series/134286/ > > > > I had seen that you said you had pushed this to drm-misc-next[1] > > before I posted my series, but couldn't find the actual commits in > > drm-misc/for-linux-next, which is still at commit dfc1209ed5a3861c > > ("arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations", > > so I assumed you just forgot to push? > > However, the latest pull request[2] does include them, while linux-next > > does not. > > > > Has the drm-misc git repo moved? > > It moved to gitlab recently, the new url is > git@gitlab.freedesktop.org:drm/misc/kernel.git Time to tell Stephen... > and the drm_panic kmsg screen commit is there: > > https://gitlab.freedesktop.org/drm/misc/kernel/-/commits/drm-misc-next?ref_type=heads Thanks! Gr{oetje,eeting}s, Geert
Hi Geert, On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > Has the drm-misc git repo moved? > > > > It moved to gitlab recently, the new url is > > git@gitlab.freedesktop.org:drm/misc/kernel.git > > Time to tell Stephen... linux-next has been using that URL for some time.
Hi Stephen and Maxime, On Fri, Jun 14, 2024 at 12:00 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > Has the drm-misc git repo moved? > > > > > > It moved to gitlab recently, the new url is > > > git@gitlab.freedesktop.org:drm/misc/kernel.git > > > > Time to tell Stephen... > > linux-next has been using that URL for some time. OK. Looks like the top commit of last drm-misc PR [1] is part of the drm-misc-next branch. but not of the for-linux-next branch, while Stephen pulls the latter. Is that a drm-misc or a linux-next issue? Thanks! [1] a13aaf157467e694a3824d81304106b58d4c20d6 Gr{oetje,eeting}s, Geert
Hi, On Fri, Jun 14, 2024 at 08:58:26AM GMT, Geert Uytterhoeven wrote: > Hi Stephen and Maxime, > > On Fri, Jun 14, 2024 at 12:00 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > Has the drm-misc git repo moved? > > > > > > > > It moved to gitlab recently, the new url is > > > > git@gitlab.freedesktop.org:drm/misc/kernel.git > > > > > > Time to tell Stephen... > > > > linux-next has been using that URL for some time. > > OK. > > Looks like the top commit of last drm-misc PR [1] is part of the > drm-misc-next branch. but not of the for-linux-next branch, while > Stephen pulls the latter. > Is that a drm-misc or a linux-next issue? This was a drm-misc issue, it should now be solved Maxime
Hi Maxime, On Fri, Jun 14, 2024 at 10:35 AM Maxime Ripard <mripard@kernel.org> wrote: > On Fri, Jun 14, 2024 at 08:58:26AM GMT, Geert Uytterhoeven wrote: > > Looks like the top commit of last drm-misc PR [1] is part of the > > drm-misc-next branch. but not of the for-linux-next branch, while > > Stephen pulls the latter. > > Is that a drm-misc or a linux-next issue? > > This was a drm-misc issue, it should now be solved Thanks, confirmed! (and updated my .git/config for next renesas-drivers release again ;-) Gr{oetje,eeting}s, Geert