| Message ID | 20240603-md-snd-soc-qcom-sdw-v1-1-101ea8bcdd38@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 65909a7e7aa8b25c9cc5f04c1fd5d6f0f1d76fcd |
| Headers | show |
| Series | ASoC: qcom: add missing MODULE_DESCRIPTION() macro | expand |
On Tue, Jun 04, 2024 at 12:56:09PM +0100, Mark Brown wrote: > On Mon, Jun 03, 2024 at 05:16:07PM -0700, Jeff Johnson wrote: > > make allmodconfig && make W=1 C=1 reports: > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/qcom/snd-soc-qcom-sdw.o > > Is anyone getting any value from these MODULE_DESCRIPTION()s? This all > just seems like a huge amount of noise and I'm having trouble thinking > of a use case. The missing MODULE_DESCRIPTION() warnings are very annoying. We recently missed a link error issue because the warning was drowned out in MODULE_DESCRIPTION() warnings. https://lore.kernel.org/all/202405182038.ncf1mL7Z-lkp@intel.com/ regards, dan carpenter
On 2024-06-04 13:56, Mark Brown wrote: > On Mon, Jun 03, 2024 at 05:16:07PM -0700, Jeff Johnson wrote: >> make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> sound/soc/qcom/snd-soc-qcom-sdw.o > > Is anyone getting any value from these MODULE_DESCRIPTION()s? This all > just seems like a huge amount of noise and I'm having trouble thinking > of a use case. FWIW, I find module descriptions useful. Of course, there are some of them that don't provide much value, but the well-written ones are good.
diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c index eaa8bb016e50..f2eda2ff46c0 100644 --- a/sound/soc/qcom/sdw.c +++ b/sound/soc/qcom/sdw.c @@ -160,4 +160,5 @@ int qcom_snd_sdw_hw_free(struct snd_pcm_substream *substream, return 0; } EXPORT_SYMBOL_GPL(qcom_snd_sdw_hw_free); +MODULE_DESCRIPTION("Qualcomm ASoC SoundWire helper functions"); MODULE_LICENSE("GPL");
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/qcom/snd-soc-qcom-sdw.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- sound/soc/qcom/sdw.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a change-id: 20240602-md-snd-soc-qcom-sdw-07dac5b62d65